* [dpdk-dev] [PATCH] rte_eth_af_packet: check return value from sendto call
@ 2015-08-27 17:50 John W. Linville
2015-10-20 16:01 ` Thomas Monjalon
0 siblings, 1 reply; 2+ messages in thread
From: John W. Linville @ 2015-08-27 17:50 UTC (permalink / raw)
To: dev
Coverity CID # 13200
If sendto fails, the packets will not get transmitted. Return 0 as
the number of packets transmitted.
Signed-off-by: John W. Linville <linville@tuxdriver.com>
---
drivers/net/af_packet/rte_eth_af_packet.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/net/af_packet/rte_eth_af_packet.c b/drivers/net/af_packet/rte_eth_af_packet.c
index cac26e533813..bfde66115708 100644
--- a/drivers/net/af_packet/rte_eth_af_packet.c
+++ b/drivers/net/af_packet/rte_eth_af_packet.c
@@ -220,7 +220,8 @@ eth_af_packet_tx(void *queue, struct rte_mbuf **bufs, uint16_t nb_pkts)
}
/* kick-off transmits */
- sendto(pkt_q->sockfd, NULL, 0, MSG_DONTWAIT, NULL, 0);
+ if (sendto(pkt_q->sockfd, NULL, 0, MSG_DONTWAIT, NULL, 0) == -1)
+ return 0; /* error sending -- no packets transmitted */
pkt_q->framenum = framenum;
pkt_q->tx_pkts += num_tx;
--
2.4.3
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [dpdk-dev] [PATCH] rte_eth_af_packet: check return value from sendto call
2015-08-27 17:50 [dpdk-dev] [PATCH] rte_eth_af_packet: check return value from sendto call John W. Linville
@ 2015-10-20 16:01 ` Thomas Monjalon
0 siblings, 0 replies; 2+ messages in thread
From: Thomas Monjalon @ 2015-10-20 16:01 UTC (permalink / raw)
To: John W. Linville; +Cc: dev
2015-08-27 13:50, John W. Linville:
> Coverity CID # 13200
>
> If sendto fails, the packets will not get transmitted. Return 0 as
> the number of packets transmitted.
>
> Signed-off-by: John W. Linville <linville@tuxdriver.com>
Applied, thanks
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-10-20 16:02 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-08-27 17:50 [dpdk-dev] [PATCH] rte_eth_af_packet: check return value from sendto call John W. Linville
2015-10-20 16:01 ` Thomas Monjalon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).