From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id 8F06E6CBD for ; Tue, 11 Oct 2016 15:13:10 +0200 (CEST) Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 6D208A24CD; Tue, 11 Oct 2016 13:13:09 +0000 (UTC) Received: from [10.36.6.57] (vpn1-6-57.ams2.redhat.com [10.36.6.57]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u9BDD4Oo011846 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Tue, 11 Oct 2016 09:13:06 -0400 To: Olivier Matz , dev@dpdk.org, yuanhan.liu@linux.intel.com References: <1469088510-7552-1-git-send-email-olivier.matz@6wind.com> <1475485223-30566-1-git-send-email-olivier.matz@6wind.com> <1475485223-30566-4-git-send-email-olivier.matz@6wind.com> Cc: konstantin.ananyev@intel.com, sugesh.chandran@intel.com, bruce.richardson@intel.com, jianfeng.tan@intel.com, helin.zhang@intel.com, adrien.mazarguil@6wind.com, stephen@networkplumber.org, dprovan@bivio.net, xiao.w.wang@intel.com From: Maxime Coquelin Message-ID: <215a9898-34fc-ecfa-0dd0-b04a14a67ccb@redhat.com> Date: Tue, 11 Oct 2016 15:13:03 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <1475485223-30566-4-git-send-email-olivier.matz@6wind.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.68 on 10.5.11.22 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.39]); Tue, 11 Oct 2016 13:13:09 +0000 (UTC) Subject: Re: [dpdk-dev] [PATCH v2 03/12] virtio: reinitialize the device in configure callback X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 11 Oct 2016 13:13:10 -0000 On 10/03/2016 11:00 AM, Olivier Matz wrote: > Add the ability to reset the virtio device in the configure callback > if the features flag changed since previous reset. This will be possible > with the introduction of offload support in next commits. > > Signed-off-by: Olivier Matz > --- > drivers/net/virtio/virtio_ethdev.c | 26 +++++++++++++++++++------- > drivers/net/virtio/virtio_pci.h | 1 + > 2 files changed, 20 insertions(+), 7 deletions(-) Looks good to me. Reviewed-by: Maxime Coquelin Thanks, Maxime