From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 37709A053B; Thu, 6 Feb 2020 15:18:04 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 7D38C1C0D2; Thu, 6 Feb 2020 15:18:03 +0100 (CET) Received: from wout4-smtp.messagingengine.com (wout4-smtp.messagingengine.com [64.147.123.20]) by dpdk.org (Postfix) with ESMTP id E313E1BE9E; Thu, 6 Feb 2020 15:18:01 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.west.internal (Postfix) with ESMTP id D337049A; Thu, 6 Feb 2020 09:18:00 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Thu, 06 Feb 2020 09:18:01 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=ZwhJm7rMnemAOM3R7bin1kUgOat6AntBHuFw9G6vpK0=; b=Q6KnKzaRMUZ5 xPOpBEgAG4YG3BIbOg/cD01QVFQL2Y/LU2q9yasD+U3NXSfjXl4QvotNg4hEiBvp +ihykRfULfzfs0RbEiwlf7kKY77CoOXXa/zEXqHQiPtcdxxo1cIZMaxbe3dMzqkB tjvv7KeaHzH1ofU1QpfKoc7tJeEVjmk= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=ZwhJm7rMnemAOM3R7bin1kUgOat6AntBHuFw9G6vp K0=; b=L16ECRj/7Oi/NZKjrRGEAgXkeYp5VC46AyBOfnxxEaGQ80CBav5mxfd9u h/gErFxw7O+kLHS/oIES3E5tWGrpNZvn7iWs+jmBL7RyFNdVNY2/sPYYBb7p45J8 mky8c8FWQvmxbnA4HS4URWsKRTcLFuriYSFJkqk5FK9BYBgzyY0fwQ+z2JnZP3Li dtXcZb0yeaU9p+wzqjJYvo48JaCOnkcwMU12vD8rNCefeMkV3aykHURuuhGXbrio prY5Ca0XUU4iTV7VzJwlmla3lAUkO7zAbyqV0pK2zqYK3yNkXrPse2U1U1sMO1+z rxTGwyHu/a1cfZqKiXfV3KO/gMUyw== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedugedrheefgdeivdcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucfkph epjeejrddufeegrddvtdefrddukeegnecuvehluhhsthgvrhfuihiivgeptdenucfrrghr rghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 9400330605C8; Thu, 6 Feb 2020 09:17:59 -0500 (EST) From: Thomas Monjalon To: Stephen Hemminger Cc: dev@dpdk.org, stable@dpdk.org, anatoly.burakov@intel.com Date: Thu, 06 Feb 2020 15:17:58 +0100 Message-ID: <2160794.bcXerOTE6V@xps> In-Reply-To: <20200122170611.23121-1-stephen@networkplumber.org> References: <20200106205553.3696-1-stephen@networkplumber.org> <20200122170611.23121-1-stephen@networkplumber.org> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH v2] mem: fix incorrect munmap in error unwind X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 22/01/2020 18:06, Stephen Hemminger: > The loop to unwind existing mmaps was only unmapping the > first segment and the error paths after mmap() were not > doing munmap of the current segment. > > Fixes: 66cc45e293ed ("mem: replace memseg with memseg lists") > Cc: anatoly.burakov@intel.com > Cc: stable@dpdk.org > Signed-off-by: Stephen Hemminger > Acked-by: Anatoly Burakov > --- > v2 - incorporate feedback from David Marchand > fix missing munmap of current segment Applied, thanks