From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2FE0E4330F; Sun, 12 Nov 2023 14:37:04 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id AC7E24026B; Sun, 12 Nov 2023 14:37:03 +0100 (CET) Received: from wout4-smtp.messagingengine.com (wout4-smtp.messagingengine.com [64.147.123.20]) by mails.dpdk.org (Postfix) with ESMTP id 06A414021E for <dev@dpdk.org>; Sun, 12 Nov 2023 14:37:01 +0100 (CET) Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.west.internal (Postfix) with ESMTP id 39E31320069B; Sun, 12 Nov 2023 08:36:59 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute3.internal (MEProxy); Sun, 12 Nov 2023 08:36:59 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm3; t= 1699796218; x=1699882618; bh=7rFxj+J+XtvAHTJKHhMlBzLv30BRO5xboyp rr4ejXKw=; b=A7d7xT9jNdLaEpB1ppNAcPDJX7rIJYuUHuonDFgeykl2Zymd3O0 YdmIM493Cw+pEyROXKru7cGOBefuThdLzQFGAljiSwmbEZSGPoUMNAei1my/pCaB thwCcUokWPQNiT7d8LZQD3ny6mPtadGLB/nZgw3zG0itwdS0DH0DaCX1r81ALSFa MgwSRoYtPMeED/YIaV1kolTXRazavyx34QqJlo3WPkSFUirG8zFWKd5tQl/vDkBd 0JzVySwU21WR3CRLnaDWUYR5ny2wOabIseGXa01wfqM7z3owUsRpdpxxvH/P9BIy Psoy6Cc11wDssZLSJizZ58LQ5hm73Le/pTA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t= 1699796218; x=1699882618; bh=7rFxj+J+XtvAHTJKHhMlBzLv30BRO5xboyp rr4ejXKw=; b=U2sckm0gKK03C7Z8zPv7WKnP/VbiCxBHDJnD3BQXh6uA9RsqGYz 5FQaVsU2boNdtiiMZMkMYTC/VEHdPWeFgVoV3ZIYPCx396xFE8xlGbJ+Cc5ttQmZ mtFi4W1vKrWfDFFi48/9t3TULNl5nNbEGG+iZpTsNB+yoGO3VJkPSC6ELcSaT8HC 0Wtoe6uNn779+I7rpn2JVV14KfR3wOCxXOkKk/I7fx3SuKW0mzf0jFigk5tR6kNM SVufqmvtzlClheCwm6w+GKneT7+OTzLZ8ckgdm+93zIr19mn6RwubAhxFUPIJ/mu tQNcvHTgkzmIix6S+198byW+v7rl8Iik3gA== X-ME-Sender: <xms:-tRQZTQSp7idurh6SW7pxFMdMvgHf6lzoD1KT8QrkI0xkCmsiLhwGQ> <xme:-tRQZUyUY-GX9eb6brfgLjBE_ezQ-VeS66gzHm43VH-Ahd8XRIaTvxNKlweyPWfjZ hJydXSV2mT3QrgkIg> X-ME-Received: <xmr:-tRQZY3EEgQCce9uSApMWChrVubAMr102xd4-rexCsP9E0qgnirZRkO0zlNjMjk6fzFjL0YEMGa5RWLE5P95QSOISA> X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvkedruddvkedgheegucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhm rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc ggtffrrghtthgvrhhnpedtjeeiieefhedtfffgvdelteeufeefheeujefgueetfedttdei kefgkeduhedtgfenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfh hrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: <xmx:-tRQZTDKc1WUUwTZPD1B_z05IGky4wPNCvuszFLI53eIg_wtuFsvdA> <xmx:-tRQZcj6d6oyzM52XMNbGhvchBBSu_FtQ84ktk3CdxyWxbPNsv-mhQ> <xmx:-tRQZXoTrIHAWCOBhs9FdaP4Cg4M4wc5eR0f9JtF_7VJAfEkDx4bUQ> <xmx:-tRQZWYkiCOTEXlWmQHFvV_D69Jd4akDSeFQ3Kv37mg68ij0yjk0rQ> Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sun, 12 Nov 2023 08:36:57 -0500 (EST) From: Thomas Monjalon <thomas@monjalon.net> To: Shubham Rohila <shubham.rohila@amd.com> Cc: nikhil.agarwal@amd.com, david.marchand@redhat.com, dev@dpdk.org, ferruh.yigit@amd.com, anatoly.burakov@intel.com, "Gupta, Nipun" <nipun.gupta@amd.com> Subject: Re: [PATCH v2 2/2] bus/cdx: add bus master enable/disable APIs Date: Sun, 12 Nov 2023 14:36:56 +0100 Message-ID: <2161608.irdbgypaU6@thomas> In-Reply-To: <a44e58b0-4878-4825-9c91-6b3c02ed7594@amd.com> References: <20231027162212.3353973-1-ferruh.yigit@amd.com> <20231103112016.1945684-2-shubham.rohila@amd.com> <a44e58b0-4878-4825-9c91-6b3c02ed7594@amd.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org 07/11/2023 15:25, Gupta, Nipun: > > On 11/3/2023 4:50 PM, Shubham Rohila wrote: > > Define rte_cdx_vfio_bm_enable and rte_cdx_vfio_bm_disable to > > enable or disable bus master functionality for cdx devices. > > > > Signed-off-by: Shubham Rohila <shubham.rohila@amd.com> > > --- > > v2 > > - Fix indentations and alphabetical orderings. > > - Wrap checks in parenthesis for readability > > - Assign argsz before using in rte_cdx_vfio_bm_disable > > - Remove unecessary variable initialisation > > Acked-by: Nipun Gupta <nipun.gupta@amd.com> Applied, thanks.