From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Hiroyuki Mikita <h.mikita89@gmail.com>, konstantin.ananyev@intel.com
Cc: dev@dpdk.org, olivier.matz@6wind.com
Subject: Re: [dpdk-dev] [PATCH v2] mbuf: decrease refcnt when detaching
Date: Tue, 17 May 2016 14:43:19 +0200 [thread overview]
Message-ID: <2164081.rUYNJaTDcf@xps13> (raw)
In-Reply-To: <1463417600-20943-1-git-send-email-h.mikita89@gmail.com>
2016-05-17 01:53, Hiroyuki Mikita:
> The rte_pktmbuf_detach() function should decrease refcnt on a direct
> buffer.
>
> Signed-off-by: Hiroyuki Mikita <h.mikita89@gmail.com>
> ---
> v2:
> * introduced a new function rte_pktmbuf_detach2() which decrease refcnt.
As you have noticed, "whenever the indirect buffer is detached,
the reference counter on the direct buffer is decremented."
So the current behaviour of rte_pktmbuf_detach() is buggy.
Why not fix it without renaming?
If you consider this behavioral bug is part of the API, we
can fix it in a new function unattach and deprecate detach.
But Konstantin, why do you want to keep a restore function?
What is the need?
Please explicit the function name for the detach operation in
doc/guides/prog_guide/mbuf_lib.rst (whatever detach2 or unattach).
> * marked rte_pktmbuf_detach() as deprecated.
> * added comments about refcnt to rte_pktmbuf_attach() and rte_pktmbuf_detach().
> * checked refcnt when detaching in unit tests.
> * added this issue to release notes.
next prev parent reply other threads:[~2016-05-17 12:43 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-15 15:50 [dpdk-dev] [PATCH] " Hiroyuki Mikita
2016-05-16 0:05 ` Ananyev, Konstantin
2016-05-16 2:46 ` Hiroyuki MIKITA
2016-05-16 8:49 ` Ananyev, Konstantin
2016-05-16 9:13 ` Thomas Monjalon
2016-05-16 16:24 ` Hiroyuki MIKITA
2016-05-16 8:52 ` Olivier Matz
2016-05-16 16:53 ` [dpdk-dev] [PATCH v2] " Hiroyuki Mikita
2016-05-17 10:58 ` Bruce Richardson
2016-05-17 11:06 ` Ananyev, Konstantin
2016-05-17 12:43 ` Thomas Monjalon [this message]
2016-05-17 12:59 ` Ananyev, Konstantin
2016-05-17 13:39 ` Thomas Monjalon
2016-05-17 13:44 ` Ananyev, Konstantin
2016-05-17 14:19 ` Thomas Monjalon
2016-05-17 15:45 ` Ananyev, Konstantin
2016-05-17 16:12 ` Hiroyuki MIKITA
2016-05-17 16:35 ` [dpdk-dev] [PATCH v3] " Hiroyuki Mikita
2016-05-18 11:58 ` Olivier Matz
2016-05-18 14:29 ` Hiroyuki Mikita
2016-05-18 14:41 ` [dpdk-dev] [PATCH v4] " Hiroyuki Mikita
2016-05-18 15:51 ` Olivier Matz
2016-05-19 12:38 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2164081.rUYNJaTDcf@xps13 \
--to=thomas.monjalon@6wind.com \
--cc=dev@dpdk.org \
--cc=h.mikita89@gmail.com \
--cc=konstantin.ananyev@intel.com \
--cc=olivier.matz@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).