From: Thomas Monjalon <thomas@monjalon.net>
To: Jun Qiu <jun.qiu@jaguarmicro.com>
Cc: dev@dpdk.org, chas3@att.com, radu.nicolau@intel.com,
stable@dpdk.org, "humin (Q)" <humin29@huawei.com>
Subject: Re: [PATCH 1/2] net/bonding: fix xmit l34 hash calculate for tcp
Date: Sun, 09 Oct 2022 19:41:49 +0200 [thread overview]
Message-ID: <2164244.ZfL8zNpBrT@thomas> (raw)
In-Reply-To: <1151c8fa-d75f-7598-9fc9-80ded85fb5e6@huawei.com>
> > In the following two cases, tcp_hdr + sizeof(*tcp_hdr) == pkt_end,
> > and the TCP port is not taken into account in calculating the HASH
> > value of TCP packets. TCP connections with the same source and
> > destination IP addresses will be hashed to the same slave port,
> > which may cause load imbalance.
> > 1. TCP Pure ACK packets with no options, The header length is 20
> > and there is no data.
> > 2. A TCP packet contains data, but the first seg of the mbuf
> > contains only the header information (ETH, IP, TCP), and the
> > data is in subsequent segs, which is usually the case in the
> > indirect mbuf used for zero-copy.
> >
> > Fixes: 726158060d55 ("net/bonding: fix potential out of bounds read")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Jun Qiu <jun.qiu@jaguarmicro.com>
> Acked-by: Min Hu (Connor) <humin29@huawei.com>
Applied, thanks.
prev parent reply other threads:[~2022-10-09 17:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-26 6:19 Jun Qiu
2022-08-16 1:21 ` humin (Q)
2022-10-09 17:41 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2164244.ZfL8zNpBrT@thomas \
--to=thomas@monjalon.net \
--cc=chas3@att.com \
--cc=dev@dpdk.org \
--cc=humin29@huawei.com \
--cc=jun.qiu@jaguarmicro.com \
--cc=radu.nicolau@intel.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).