From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9B10DA04C7; Wed, 20 Nov 2019 19:56:41 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 1012827D; Wed, 20 Nov 2019 19:56:41 +0100 (CET) Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by dpdk.org (Postfix) with ESMTP id 30BF4271 for <dev@dpdk.org>; Wed, 20 Nov 2019 19:56:40 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id D0D8321C4D; Wed, 20 Nov 2019 13:56:38 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Wed, 20 Nov 2019 13:56:38 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=/NOpM9krR4UjpNFbJsI/oueY+TEdDkgACuRqfB50SXw=; b=pesij/DvQW5o UQZULuHKJqMNAJdOfcQOawLSEM/FpetdZvJQMOIjX7LO3Xbehg1SYJm9B054kunJ w1g54lA5TS6ypZYowCI1bKPsbvpf3ACxdiC4SuFodFq70NJmdYls4riC4s9p5bB5 0udZdrPhwHj2Q57kb1Y4z5xqDXqp8Mk= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=/NOpM9krR4UjpNFbJsI/oueY+TEdDkgACuRqfB50S Xw=; b=KLSCLv9sc+4mY97hA5U7BlCCL6CIusqOFT6wa/AQcku33dvJQWXCJlz0Q V49km6nOBmhhvyLS36V93ITVhh3gW4rqF2hIqwAtnGy6H864D9nSmk//lLQSMnxA jtGp+PyBiyYohGVucguhtnvIKHN5TMGSnbU/tOZG6B3teAfypsl1U0xQY2jqs896 1lJCcELeRlQnlRZIR4MdzvOIoApr1+x6cthvubmYFFwOkj19NJQMmoJpe2jsoq5W OM377DXk8xNdh7MB/Z4g4xsSR9zHiMbrcxt0Uy5RfpCBTCCFfOtlp6bk3mgjAcRs DpPcTKJridQS72V2FUvFW94nP8LpA== X-ME-Sender: <xms:ZYzVXW1DLd2URoKWqNHy5Dgihz0BLd2P_uNIxJz7mCwL6c1zjEehUg> X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedufedrudehtddguddukecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhm rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc fkphepjeejrddufeegrddvtdefrddukeegnecurfgrrhgrmhepmhgrihhlfhhrohhmpeht hhhomhgrshesmhhonhhjrghlohhnrdhnvghtnecuvehluhhsthgvrhfuihiivgeptd X-ME-Proxy: <xmx:ZozVXbLmKdVXGHLAbmaLIcOojM7izXn8kVnc6v-sLP6jpOhc3bVYjQ> <xmx:ZozVXdArCOmYO0jV0wtDS2O9tmU41EXb0nHzrbipD-Odrv4bAxEbAA> <xmx:ZozVXcz7bP-8aF6itnnEfi6XetgyT_a-thq09xXTcHQcJShLToYNag> <xmx:ZozVXUZ-UsYWP5ON0JThOq3lTyDR5Rt1oN5RX-fG5pz8VYuSnBt_Yg> Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 42A51306005E; Wed, 20 Nov 2019 13:56:37 -0500 (EST) From: Thomas Monjalon <thomas@monjalon.net> To: Qi Zhang <qi.z.zhang@intel.com> Cc: dev@dpdk.org, xiaolong.ye@intel.com, ferruh.yigit@intel.com, arybchenko@solarflare.com, orika@mellanox.com Date: Wed, 20 Nov 2019 19:56:35 +0100 Message-ID: <2166340.TqaS7Hc55D@xps> In-Reply-To: <20191119061442.21369-1-qi.z.zhang@intel.com> References: <20191119061442.21369-1-qi.z.zhang@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v4] net/ice: add flow mark hint support X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> 19/11/2019 07:14, Qi Zhang: > Since not all data paths support flow mark, the driver needs > a hint from application to select the correct data path if > flow mark is required. The patch introduces a devarg > "flow-mark-support" as a workaround solution, since a standard > way is still ongoing. > > Signed-off-by: Qi Zhang <qi.z.zhang@intel.com> > Acked-by: Qiming Yang <qiming.yang@intel.com> > --- > > v4: > - remove debug code, fix typos > > v3: > - add "experimental notification" in ice.rst > > v2: > - fix typos Please use --in-reply-to to help tracking all the versions together. > +- ``Flow Mark Support`` (default ``0``) > + > + This is a hint to the driver to select the data path that supports flow mark extraction > + by default. > + NOTE: This is an experimental devarg, it will be removed when any of below conditions > + is ready. > + 1) all data paths support flow mark (currently vPMD does not) > + 2) a new offload like RTE_DEV_RX_OFFLOAD_FLOW_MARK be introduced as a standard way to hint. When the data path is selected? I suppose such decision should be done when starting the port, after everything is configured. So you can check if a rte_flow rule was added for mark action. Why the user needs to use an explicit option?