From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 468AEA2E1B for ; Wed, 4 Sep 2019 21:42:02 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 2AFB21E9B1; Wed, 4 Sep 2019 21:42:01 +0200 (CEST) Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by dpdk.org (Postfix) with ESMTP id 65D5B1E9B0 for ; Wed, 4 Sep 2019 21:42:00 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id A8D8221FDF; Wed, 4 Sep 2019 15:41:59 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Wed, 04 Sep 2019 15:41:59 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=p0vSvs/ZnG/TcWCxSCP/+nbLrYSPkYv1g7XW3YK+xDc=; b=hCmDxs6SufQ/ 7WeVWWgxdJrfsk4SfQae1z9pgZ0gwW1pE7ilq+Yxbhc+lXhj5nq+v5Hxo/vvxFd4 71vrHPLZ2MO4lUNax0K/+xxrHG7efzszoZDFWjmt6BHhdtPKpNtAg+M5RGcYK2m/ AHbPpuQ0CKCSpB7wsgARPFUnOEWFpFA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=p0vSvs/ZnG/TcWCxSCP/+nbLrYSPkYv1g7XW3YK+x Dc=; b=tFamX9mpdmHLJBWfoqm8E2Q5yd/Xj75nW2M1XvcqchDR7tduyxr9i8DNF jJBMoOrlFxSro5i6ZJ2QGPQvEgpBPZy7mFm2xKmWrfgoeszPsIlFF9g1M+NxqU1R +ua8w2tgMuZMOUM4EGLl1SBPuXyxMimB0tDEZYkPO5eGND+VcYSLaYofqB/oUGbv LiGqgKEcor0T3EKJJrFQ0Dfn54TXfgLbiodtPWvya7N9XRFeNpvc3KjqFm0wCU3a FEsZXltOih0hu/eUYJrZ1u7BwKH+pzIwA7PpK91H1BnT1CQah8vmD+FSriqm55jM 2oz/Ru5z6LSHZMqMlCTf1ElCIs8Jw== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduvddrudejhedgudefkecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhm rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc ffohhmrghinhepughpughkrdhorhhgnecukfhppeejjedrudefgedrvddtfedrudekgeen ucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth enucevlhhushhtvghrufhiiigvpedt X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 5C388D6005E; Wed, 4 Sep 2019 15:41:58 -0400 (EDT) From: Thomas Monjalon To: Andrew Rybchenko Cc: Ferruh Yigit , David Marchand , dev@dpdk.org Date: Wed, 04 Sep 2019 21:41:57 +0200 Message-ID: <2169155.oR67J0XmJ6@xps> In-Reply-To: <87c65c82-87c8-374d-1b62-36e5bd02335a@solarflare.com> References: <1566214919-32250-1-git-send-email-david.marchand@redhat.com> <3044851.BoT7FmBCyV@xps> <87c65c82-87c8-374d-1b62-36e5bd02335a@solarflare.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH 02/11] log: define logtype register wrapper for drivers X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 04/09/2019 21:21, Andrew Rybchenko: > On 9/4/19 8:45 PM, Thomas Monjalon wrote: > > 03/09/2019 10:47, Ferruh Yigit: > >> On 9/3/2019 9:06 AM, David Marchand wrote: > >>> On Mon, Sep 2, 2019 at 4:29 PM Ferruh Yigit wrote: > >>>> On 8/19/2019 12:41 PM, David Marchand wrote: > >>>>> The function rte_log_register_type_and_pick_level() fills a gap for > >>>>> dynamically loaded code (especially drivers) who would not pick up > >>>>> the log level passed at startup. > >>>>> > >>>>> Let's promote it to stable and export it for use by drivers via > >>>>> a wrapper. > >>>>> > >>>>> Signed-off-by: David Marchand > >>>>> --- > > [...] > >>>>> /** > >>>>> - * @warning > >>>>> - * @b EXPERIMENTAL: this API may change without prior notice > >>>>> - * > >>>>> * Register a dynamic log type and try to pick its level from EAL options > > [...] > >>>>> -__rte_experimental > >>>>> int rte_log_register_type_and_pick_level(const char *name, uint32_t level_def); > >>>> +1 to remove experimental from the API. > > I am not sure about this function API. > > Why we combined register and level setting in one function? > > See [1] > > [1] http://git.dpdk.org/dpdk/commit/?id=b22e77c026 Sorry, it does not explain why we mix both operations in one function.