From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-we0-f176.google.com (mail-we0-f176.google.com [74.125.82.176]) by dpdk.org (Postfix) with ESMTP id 354A4AD9E for ; Tue, 24 Feb 2015 00:40:30 +0100 (CET) Received: by wesw55 with SMTP id w55so21994973wes.4 for ; Mon, 23 Feb 2015 15:40:30 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=fgTguA0IcSVw5gwQb+BOXrTXOV5wzLrZLxeQdxizw5c=; b=Ufi2ySC3JIey0d54OhJmoQ3som8OpOE8YYVS6mE4Z2wD6U1U3G+0FN9T0WV8GC30kn cx53PVrytA21EvYMB0Cu8fgEN3ie3cG02sXegXh8ufs6WjUdBCH/Yz2biXaSyx86GQHu CqkwFMUoNokjU0t+xopC/WXZRlsuWaFkFAWr/K1QkFL6h3WZp6yNlvhPWNrL/mrBnmOU TnuVlfKEtRrQl/WnExKAouF7p2e/nn+lqEmoW6Gkx+THP/QcrK68zbLNvpfXPTZsMLmh g24FTTyYLv9Vka9Mfsr075wv7IdGlWgR+HJpzn11wOFU2ynU+6Xp1IauT0NirRQ8Ca4z dYKA== X-Gm-Message-State: ALoCoQllqWu66j26jLLuUBoyfyDMax3TW5gYmvCkwyZ7rfFoSlOfXs6dnbW97bkKQV9UZ+Net8YL X-Received: by 10.194.178.161 with SMTP id cz1mr27707014wjc.102.1424734829984; Mon, 23 Feb 2015 15:40:29 -0800 (PST) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by mx.google.com with ESMTPSA id vh8sm57656566wjc.12.2015.02.23.15.40.28 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 23 Feb 2015 15:40:28 -0800 (PST) From: Thomas Monjalon To: John McNamara , bruce.richardson@intel.com Date: Tue, 24 Feb 2015 00:39:58 +0100 Message-ID: <2169176.yPx3Hmtc39@xps13> Organization: 6WIND User-Agent: KMail/4.14.4 (Linux/3.18.4-1-ARCH; KDE/4.14.4; x86_64; ; ) In-Reply-To: <1424716210-25773-1-git-send-email-john.mcnamara@intel.com> References: <1424281343-2994-1-git-send-email-john.mcnamara@intel.com> <1424716210-25773-1-git-send-email-john.mcnamara@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v6 0/3] DPDK ethdev callback support X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 23 Feb 2015 23:40:30 -0000 2015-02-23 18:30, John McNamara: > This patchset is for a small optional addition to the ethdev library, > to add support for callbacks at the RX and TX stages. This allows > packet processing to be done on packets before they get returned > to applications using rte_eth_rx_burst call. > > See the RFC cover letter for the use cases: > > http://dpdk.org/ml/archives/dev/2014-December/010491.html > > For this version we spent some time investigating Stephen Hemminger's > suggestion of using the userspace RCU (read-copy-update) library for > SMP safety: > > http://urcu.so/ > > The default liburcu (which defaulted to liburcu-mb) requires the least > interaction from the end user but showed a 25% drop in packet throughput > in the callback sample app. > > The liburcu-qsbr (quiescent state) variant showed a 1% drop in packet > throughput in the callback sample app. However it requires registered > RCU threads in the program to periodically announce quiescent states. > This makes it more difficult to implement for end user applications. > > For this release we will document that adding and removing callbacks > is not thread safe. > > Note: Sample application documentation to follow in a patch update. > > Version 6 changes: > * RX/TX callback functions are no longer #ifdefed out if callback > option is off. Instead they return ENOTSUP. > * Simplified callbacks #ifdefs in rte_ethdev. > > Version 5 changes: > * Turned the callback feature on by default. > * Simplified #define name. > > Version 4 changes: > * Made the callback feature a compile time option. > > Version 3 changes: > * Removed unnecessary header file from example folder > (which included baremetal reference). > * Renamed the interrupt, RX and TX callbacks to make their function > clearer (using the names suggested in the mailing list comments). > * Squashed ABI version update into the commit it relates to. > * Fixed various checkpatch warnings. > > Version 2 changes: > * Added ABI versioning. > * Doxygen clarifications. > > Version 1 changes: > * Added callback removal functions. > * Minor fixes. > > Richardson, Bruce (3): > ethdev: rename callbacks field to link_intr_cbs > ethdev: add optional rxtx callback support > examples: example showing use of callbacks. Applied, thanks