From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f42.google.com (mail-wm0-f42.google.com [74.125.82.42]) by dpdk.org (Postfix) with ESMTP id DC4F095D2 for ; Mon, 7 Dec 2015 15:33:24 +0100 (CET) Received: by wmww144 with SMTP id w144so152595100wmw.0 for ; Mon, 07 Dec 2015 06:33:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:organization:user-agent :in-reply-to:references:mime-version:content-transfer-encoding :content-type; bh=IMppYDwd9A1hoPmIfQ8icO+hWqpUJVa+8BzFyYr97+Y=; b=q+HVV8XHZptcoCUqaOqvQIS2FI+CwspyTPSD3oDwlB72Q5HOztskTgYcOF10NoC+Yp TRxTXUC2bKdSa1cgTiAK9aXQFJLOoTsqjLePP+/uSKAFTk5qKTaRItbQmRCEoVnTxTJd SGif3SNnUAzJ99Fj0UI/Ay1rhP/CMa2XxTMbPdciSis9PwvRhIlOscuX242LF+TZbpif HBTZ61VQSMlVZemMDNukgHAGCQAqxOjvr+msIcVnnqnU0AxkA2HeJhoaogYkjfD0qkkh DEH9dbF+MGqpuLP2ptrveGRcAXYW4leQDj9C2kDrfOFjlBIDFIDwtgDV7ToHFMrxj7tp c78g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=IMppYDwd9A1hoPmIfQ8icO+hWqpUJVa+8BzFyYr97+Y=; b=OjGuVJ9ereFnGd+FkTkojHOmHTrh8w+6ZY6mSFqwdsgvYSv2Rb1tImDUta9TbRRGcQ GYyteiaUaO2EQCe9uAow1KiixMD5YGM/vI2OkbKsdh2RhZzsFNfJAbAPPAH1VRDCBQ9R dKE556tsGSbXu0EDQmvRlKKVOpoUi0T3XXEBHn4GQ4xBm5gxlJTgjuM1EBI/pTrys9/r SBFmLo5pqqVF557XJuGStMy0xbxDccyi+rK2CZhRqtvntsCj6ymtX2d7u33O9g6ADx2Y CwNJEGkL7CoKGkTvFqBTAnCrSgiq1SxeilksVEPEUcms7l9W8ju86XPOFzBV+ENxu0iU EQtQ== X-Gm-Message-State: ALoCoQlD+DXTXMjOjQ8DpxcacdR6xgJ6SzK5ysq8uhl6dk0+sXLV5FwUjeY/9Sh9khehNcDxCPSu X-Received: by 10.28.126.197 with SMTP id z188mr22692873wmc.88.1449498804677; Mon, 07 Dec 2015 06:33:24 -0800 (PST) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by smtp.gmail.com with ESMTPSA id bg10sm25494065wjb.46.2015.12.07.06.33.23 (version=TLSv1/SSLv3 cipher=OTHER); Mon, 07 Dec 2015 06:33:24 -0800 (PST) From: Thomas Monjalon To: Panu Matilainen Date: Mon, 07 Dec 2015 15:32:11 +0100 Message-ID: <2170557.zTAETIpyLV@xps13> Organization: 6WIND User-Agent: KMail/4.14.10 (Linux/4.1.6-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <56659309.6010305@redhat.com> References: <56659309.6010305@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v2] scripts: support any legal git revisions as abi validation range X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 07 Dec 2015 14:33:25 -0000 2015-12-07 16:09, Panu Matilainen: > On 12/03/2015 04:05 PM, Panu Matilainen wrote: > > In addition to git tags, support validating abi between any legal > > gitrevisions(7) syntaxes, such as "validate-abi.sh -1 . " > > "validate-abi.sh master mybranch " etc in addition to > > validating between tags. Makes it easier to run the validator > > for in-development work. > > > > Signed-off-by: Panu Matilainen > > Acked-by: Neil Horman > > --- > > > > v2 changes: > > - update usage and error messages to match new behavior > > - update documentation too (as suggested by John McNamara) > > > > I started wondering why this didn't get applied along with the other > abi-validator changes and noticed this is sitting in patchwork in > "changes requested" state, which doesn't seem right: v2 added the > requested documentation. It seems to be an error. > The discussion around this patch did spur another request (ability to > pass parallel build flags to make) but that's entirely unrelated, so it > shouldn't hold up this one. Yes > I've no intention of sending a v3 of this patch because AFAIK there's > nothing to fix and the make-flags thing does not belong here, but > resetting the state to "new" by myself feels like cheating or something > :) So what's the correct action here? There's preciously little > documentation about expected patchwork workflow and such. It's not cheating. Changing patchwork status and send such an email looks to be the right thing to do. Yes maybe we can improve the contributing guide. Thanks