[dpdk-dev] [PATCH] vhost: Add -lfuse into the LDFLAGS list

[dpdk-dev] [PATCH] vhost: Add -lfuse into the LDFLAGS list

[Neil Horman]

the vhost library relies on libfuse, and thats included when we do a normal
shared object build, but when we specify combined libs, its gets left out.  Add
it back in

Signed-off-by: Neil Horman <nhorman@tuxdriver.com>
---
 mk/rte.app.mk | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/mk/rte.app.mk b/mk/rte.app.mk
index e1a0dbf..86d9865 100644
--- a/mk/rte.app.mk
+++ b/mk/rte.app.mk
@@ -127,6 +127,10 @@ ifeq ($(CONFIG_RTE_LIBRTE_PMD_PCAP),y)
 LDLIBS += -lpcap
 endif
 
+ifeq ($(CONFIG_RTE_LIBRTE_VHOST),y)
+LDLIBS += -lfuse
+endif
+
 LDLIBS += --start-group
 
 ifeq ($(CONFIG_RTE_BUILD_COMBINE_LIBS),n)
-- 
2.1.0

Re: [dpdk-dev] [PATCH] vhost: Add -lfuse into the LDFLAGS list

[Flavio Leitner]

On Tuesday, January 20, 2015 03:49:58 PM Neil Horman wrote:
> the vhost library relies on libfuse, and thats included when we do a normal
> shared object build, but when we specify combined libs, its gets left out.  Add
> it back in
> 
> Signed-off-by: Neil Horman <nhorman@tuxdriver.com>

Fixes the build issue here.
Reported-by: Flavio Leitner <fbl@redhat.com>
Tested-by: Flavio Leitner <fbl@redhat.com>

Thanks Neil!
fbl

Re: [dpdk-dev] [PATCH] vhost: Add -lfuse into the LDFLAGS list

[Thomas Monjalon]

2015-01-20 15:49, Neil Horman:
> the vhost library relies on libfuse, and thats included when we do a normal
> shared object build, but when we specify combined libs, its gets left out.  Add
> it back in
> 
> Signed-off-by: Neil Horman <nhorman@tuxdriver.com>
> ---
>  mk/rte.app.mk | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> --- a/mk/rte.app.mk
> +++ b/mk/rte.app.mk
> +ifeq ($(CONFIG_RTE_LIBRTE_VHOST),y)
> +LDLIBS += -lfuse
> +endif

There was already a line for -lfuse below in the file.
You are adding it in a place where it applies to every cases,
so you should remove the old special case.

Thanks
-- 
Thomas

[dpdk-dev] [PATCH v2] vhost: Add -lfuse into the LDFLAGS list

[Neil Horman]

the vhost library relies on libfuse, and thats included when we do a normal
shared object build, but when we specify combined libs, its gets left out.  Add
it back in

Signed-off-by: Neil Horman <nhorman@tuxdriver.com>

---
Change notes:
v2) Removed normal shared object inclusion of libfuse since its always included
now
---
 mk/rte.app.mk | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/mk/rte.app.mk b/mk/rte.app.mk
index 9c8b06a..4294d9a 100644
--- a/mk/rte.app.mk
+++ b/mk/rte.app.mk
@@ -131,6 +131,10 @@ ifeq ($(CONFIG_RTE_LIBRTE_PMD_PCAP),y)
 LDLIBS += -lpcap
 endif
 
+ifeq ($(CONFIG_RTE_LIBRTE_VHOST),y)
+LDLIBS += -lfuse
+endif
+
 LDLIBS += --start-group
 
 ifeq ($(CONFIG_RTE_BUILD_COMBINE_LIBS),n)
@@ -197,7 +201,6 @@ endif
 
 ifeq ($(CONFIG_RTE_LIBRTE_VHOST), y)
 LDLIBS += -lrte_vhost
-LDLIBS += -lfuse
 endif
 
 ifeq ($(CONFIG_RTE_LIBRTE_ENIC_PMD),y)
-- 
2.1.0

Re: [dpdk-dev] [PATCH v2] vhost: Add -lfuse into the LDFLAGS list

[Thomas Monjalon]

2015-01-27 09:39, Neil Horman:
> the vhost library relies on libfuse, and thats included when we do a normal
> shared object build, but when we specify combined libs, its gets left out.  Add
> it back in
> 
> Signed-off-by: Neil Horman <nhorman@tuxdriver.com>
> 
> ---
> Change notes:
> v2) Removed normal shared object inclusion of libfuse since its always included
> now

Acked-by: Thomas Monjalon <thomas.monjalon@6wind.com>

Applied

Thanks
-- 
Thomas