DPDK patches and discussions
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Tetsuya Mukawa <mukawa@igel.co.jp>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v11 2/2] librte_pmd_null: Support port hotplug function
Date: Thu, 26 Feb 2015 11:57:23 +0100
Message-ID: <2176123.7naUroNpz4@xps13> (raw)
In-Reply-To: <CAKU8wkcwLqHnHSx3qREXVcQJZQJpZ0rWtDu7We=kGM9iG4zjSA@mail.gmail.com>

2015-02-26 18:06, Tetsuya Mukawa:
> 2015-02-26 16:03 GMT+09:00 Thomas Monjalon <thomas.monjalon@6wind.com>:
> > 2015-02-25 16:49, Stephen Hemminger:
> >> Build fails if HOTPLUG is disabled
> 
> Hi Stephen,
> 
> I appreciate for you reporting.
> 
> >
> > OK thanks for reporting.
> > Actually there is no good reason to disable hotplug on Linux.
> > Though it means that it's impossible to build on FreeBSD.
> >
> > Tetsuya, the right fix is to remove this option.
> 
> Hi Thomas,
> 
> Yes, I agree with it. I will add some codes to remove the option.
> Please let me have a few days, I need to prepare BSD machine for compile test.
> 
> > You should manage to graceful degrades hotplug in not supported
> > cases supported: devices cannot be detachable in case of VFIO or nic_uio.
> > What about uio_pci_generic?
> 
> We cannot detach a vfio device so far. But we can detach a igb_uio and
> uio_pci_generic device.
> About a vfio ddevice, I haven't checked related code yet, but I guess
> I will submit code to detach a vfio device in post-rc1.

OK thanks.
I made a quick fix (moving #ifdef) waiting the option removal:
	http://dpdk.org/browse/dpdk/commit/?id=7609e6609350

  reply	other threads:[~2015-02-26 10:57 UTC|newest]

Thread overview: 37+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <mukawa@igel.co.jp>
2014-10-01  4:57 ` [dpdk-dev] [PATCH v2] PMD for performance measurement mukawa
2014-10-01  4:57   ` [dpdk-dev] [PATCH v2] librte_pmd_null: Add null PMD mukawa
2014-11-13 12:17     ` Thomas Monjalon
2014-12-16  8:39     ` [dpdk-dev] [PATCH v3] " Tetsuya Mukawa
2014-12-16  8:44       ` Tetsuya Mukawa
2014-12-16  8:47         ` Thomas Monjalon
2014-12-16  8:49           ` Tetsuya Mukawa
2015-01-20  3:00       ` [dpdk-dev] [PATCH v4 1/2] " Tetsuya Mukawa
2015-01-20  3:00         ` [dpdk-dev] [PATCH v4 2/2] librte_pmd_null: Support port hotplug function Tetsuya Mukawa
2015-02-06  4:38           ` [dpdk-dev] [PATCH v6 1/2] librte_pmd_null: Add null PMD Tetsuya Mukawa
2015-02-06  4:38             ` [dpdk-dev] [PATCH v6 2/2] librte_pmd_null: Support port hotplug function Tetsuya Mukawa
2015-02-06 11:37               ` Iremonger, Bernard
2015-02-06 11:32             ` [dpdk-dev] [PATCH v6 1/2] librte_pmd_null: Add null PMD Iremonger, Bernard
2015-02-09  8:54               ` Tetsuya Mukawa
2015-02-12  2:44             ` [dpdk-dev] [PATCH v7 1/2] librte_pmd_null: Add Null PMD Tetsuya Mukawa
2015-02-12  2:44               ` [dpdk-dev] [PATCH v7 2/2] librte_pmd_null: Support port hotplug function Tetsuya Mukawa
2015-02-16  4:19               ` [dpdk-dev] [PATCH v8 1/2] librte_pmd_null: Add Null PMD Tetsuya Mukawa
2015-02-16  4:19                 ` [dpdk-dev] [PATCH v8 2/2] librte_pmd_null: Support port hotplug function Tetsuya Mukawa
2015-02-16 16:38                   ` Iremonger, Bernard
2015-02-16 16:38                 ` [dpdk-dev] [PATCH v8 1/2] librte_pmd_null: Add Null PMD Iremonger, Bernard
2015-02-19 10:41                 ` [dpdk-dev] [PATCH v9 " Tetsuya Mukawa
2015-02-19 10:41                   ` [dpdk-dev] [PATCH v9 2/2] librte_pmd_null: Support port hotplug function Tetsuya Mukawa
2015-02-20  6:41                   ` [dpdk-dev] [PATCH v10 1/2] librte_pmd_null: Add Null PMD Tetsuya Mukawa
2015-02-20  6:41                     ` [dpdk-dev] [PATCH v10 2/2] librte_pmd_null: Support port hotplug function Tetsuya Mukawa
2015-02-23  5:12                     ` [dpdk-dev] [PATCH v11 1/2] librte_pmd_null: Add Null PMD Tetsuya Mukawa
2015-02-23  5:12                       ` [dpdk-dev] [PATCH v11 2/2] librte_pmd_null: Support port hotplug function Tetsuya Mukawa
2015-02-25 23:35                         ` Thomas Monjalon
2015-02-26  0:49                           ` Stephen Hemminger
2015-02-26  7:03                             ` Thomas Monjalon
2015-02-26  9:06                               ` Tetsuya Mukawa
2015-02-26 10:57                                 ` Thomas Monjalon [this message]
2015-02-26 11:50                                   ` Tetsuya Mukawa
2015-03-04  3:37                                   ` Tetsuya Mukawa
2015-02-26 12:21                                 ` Mcnamara, John
2015-02-26 15:36                                   ` Mcnamara, John
2015-02-27  1:31                                     ` Tetsuya Mukawa
2015-02-27 23:29                                   ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2176123.7naUroNpz4@xps13 \
    --to=thomas.monjalon@6wind.com \
    --cc=dev@dpdk.org \
    --cc=mukawa@igel.co.jp \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git