From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 36D5FA09E0; Fri, 13 Nov 2020 20:09:37 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 8607DC868; Fri, 13 Nov 2020 20:09:35 +0100 (CET) Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by dpdk.org (Postfix) with ESMTP id 97FA74CA6 for ; Fri, 13 Nov 2020 20:09:33 +0100 (CET) Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.nyi.internal (Postfix) with ESMTP id 474925C019C; Fri, 13 Nov 2020 14:09:32 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Fri, 13 Nov 2020 14:09:32 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm2; bh= aFxDajvjEAMWNKqtaeyh0B9mly+UWR5Lpd6mBOebrzc=; b=GdlfoRulK/B4NmMp t6ShDrau9Y7T0nTux9S9u9k7d5RaXiLhcKYpnra/VaZHDFDlBc86xARN/SwFh501 Zq8cykcESGMd4GKl5r9vzEgNwoYQ4SMcwrcOJO0SCeLaQ+AqGOIC+wR549l9Pmsv 4fNEnwFJMszPz/Z+JxH1J7q145zNfh1V+9cO2SeZwop6GVYb4BnVRWp2mSiPXrr5 HsJyWprek7ySP5/N74zrATSNQo/tX+tO3IwoJ/Wg5T7OxPOMWG/oKFoU/Y+3Kgss ijHvBDEi7RzFXygQaDiIbEJpZCWPkVTNSyK9JR+J4tFSD7bvS8jH0HnAAA64ZCwe Hq54NA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=aFxDajvjEAMWNKqtaeyh0B9mly+UWR5Lpd6mBOebr zc=; b=oNpWI3OTYGbmJrxT2ibNZ2jRHCbtYCigfSjfwDrn8Nz7Ox3D4zb967z+s Mo6zA+Z/QhjgNdcYPmrPTJAThRSO0LxD3FUSge8bI+nqCLaTiPtr5lgNOWYokZ7D LF+LYceq0w1BP7j5To0XYzyeIFY6UTmtew6pVsWdRuB7+norKXnBALx+FI/Ri5br aJDnxAGX+jIbIy+/RE0Iiu0BScLAJ30sm6+85KqXDoroyAjE6Ka0GEw6HaIJjjYs dms74HcFbh2oOBRhcNpn+GvTsSUNh+moI+lBMeNFx6Uc0GcUJOBnQkSvVTXadm5P Bf3INkHoOAoPTiiV/Rjdf6NOJeUqg== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedujedruddvhedguddvudcutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhm rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc ggtffrrghtthgvrhhnpedugefgvdefudfftdefgeelgffhueekgfffhfeujedtteeutdej ueeiiedvffegheenucfkphepjeejrddufeegrddvtdefrddukeegnecuvehluhhsthgvrh fuihiivgepudenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgr lhhonhdrnhgvth X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 4BFDA3064AB4; Fri, 13 Nov 2020 14:09:31 -0500 (EST) From: Thomas Monjalon To: Bing Zhao Cc: viacheslavo@nvidia.com, matan@nvidia.com, dev@dpdk.org, orika@nvidia.com, rasland@nvidia.com, asafp@nvidia.com Date: Fri, 13 Nov 2020 20:09:30 +0100 Message-ID: <2176186.QZRYtJoNy7@thomas> In-Reply-To: <1605251133-325948-1-git-send-email-bingz@nvidia.com> References: <1605251133-325948-1-git-send-email-bingz@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] net/mlx5: fix wrong function of hairpin unbind X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 13/11/2020 08:05, Bing Zhao: > In the implementation of mlx5_hairpin_unbind, a copy-paste error was > inside. If a single peer Rx port needed to be unbound, it would be > bound again by mistake. > > All the hardware resources were released when stopping the device and > no mess of the configuration was introduced. But when trying to unbind > the ports again, the issue would appear. > > The typo of the function call is fixed. If there is no hairpin queue > bound between two ports, the unbinding process should be considered > successful. > > Fixes: 37cd4501e873 ("net/mlx5: support two ports hairpin mode") > > Signed-off-by: Bing Zhao > Acked-by: Viacheslav Ovsiienko Applied in next-net-mlx, thanks.