From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 65F32689E for ; Thu, 20 Apr 2017 00:31:18 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id B663B210A4; Wed, 19 Apr 2017 18:31:17 -0400 (EDT) Received: from frontend1 ([10.202.2.160]) by compute1.internal (MEProxy); Wed, 19 Apr 2017 18:31:17 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc:x-sasl-enc; s=mesmtp; bh=98FYCB1SZ4ILdgS DQqA5Fdh8QAJ/mzfS8WAm0OBiNm0=; b=nHoNDYml8yuqS4XS1OdtpNWvw9iExKD EpUX01fKt6IwU7mjzhS+P/XJOjupoas8ra1HvqAOzlBgVrOB10Z3pQMu12JWvmm3 cuEpjwf38v0KKl1xBlv0caBvw9UM7x1fd7ljl1a5up2P54FADZtN8/yTFftduO4y IybmwpSz6rPw= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc:x-sasl-enc; s= fm1; bh=98FYCB1SZ4ILdgSDQqA5Fdh8QAJ/mzfS8WAm0OBiNm0=; b=nDhOHVs3 PlBRkGfVc1giXiDegX8DowOqPLAV7TjXTSsPqTY/tnM4rMsyXx5AGk0bMp3BetXT KJfWo3ysmFspqBgrLEVVM/YQEN4YDOTlQl3rjQIUfNH/fUznG7+cXLyQQuhqt6/K Bepi4XF/oUxgLhRB+QX74ypV5Wvjdz26pgkS4HBepfim+ycQD+6Om1Ba+CoccCJr ndDFstGpEo6xCw2jaHco+f6dEzMxAa+E+U8vrcpTUKTFRQHqN1SgRQY7xR61JnTx wt9E8r3iEd6YGAhG34XBWjN6x9G5srH7mCcZ0Tt9p2LIH2lsatlBj//XZa8/vk3o kF2OpeGz0xl4Fg== X-ME-Sender: X-Sasl-enc: gxbQCJKa737PGBHu7Q3PQRX8V/w0qdG7j3WpfH8fN5zZ 1492641077 Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 741C27E0EE; Wed, 19 Apr 2017 18:31:17 -0400 (EDT) From: Thomas Monjalon To: "Richardson, Bruce" Cc: dev@dpdk.org, "Van Haaren, Harry" Date: Thu, 20 Apr 2017 00:31:16 +0200 Message-ID: <2176270.5Bc8X6HNAl@xps> In-Reply-To: References: <20170414151815.12850-1-bruce.richardson@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] event/sw: fix events mis-identified as needing reorder X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 19 Apr 2017 22:31:18 -0000 14/04/2017 17:28, Van Haaren, Harry: > From: Richardson, Bruce > Sent: Friday, April 14, 2017 4:18 PM > > > > When taking events from a port, we checked the history list to check if > > the > > event needed to be put back in order i.e. originally came from a reordered > > queue type. The check for reordering involved checking if the reorder > > buffer entry pointer was null. However, after that pointer was used it was > > never cleared to null again. > > > > This caused problems when we had mixed reordered and atomic or parallel > > events, as the events from the latter two queue types were misidentified > > as > > needing reordering. This let in some cases to crashes, but mostly led to > > dropping events, and then application lock-up. > > > > Fixes: 617995dfc5b2 ("event/sw: add scheduling logic") > > > > Signed-off-by: Bruce Richardson > > +CC Thomas, would you pick this directly to master please, as no > next-eventdev will be merged, thanks. > > Acked-by: Harry van Haaren Applied, thanks