From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f44.google.com (mail-wm0-f44.google.com [74.125.82.44]) by dpdk.org (Postfix) with ESMTP id AF4FA2C11 for ; Wed, 30 Mar 2016 18:18:52 +0200 (CEST) Received: by mail-wm0-f44.google.com with SMTP id 20so78385896wmh.1 for ; Wed, 30 Mar 2016 09:18:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:organization:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=ZNKMlMqCnWEejpyYrqjAlm7VZjFzSwuN7CcDvg7M9/o=; b=rvPxHjE2JMLjYNlDKGIop9NA5HoNhFM5PkIx7FzO1X6xNPN8Znu2VBQZQ0BCHgvCAl d9y0dnO5Rqbh4O9xJYv4Cc5t4zAMW+cq29Dh2ApsBYza0eoD+qb30ADq9ogN60VqGJwb 36T3r6oaf+6YW1tfyRysGKUa/z/vcEDDnLf4ij7GtJMOAaQizxh5VpkCOD2Izf+iirJr Xh/Y2HDMhxBdaAiCgmudYVddZBDD8+hlHHsv8EzPhD0wlHVTZI76hlux3z5tLGpBzKpq AAFj10lCOdEY0WhxmEnq7wj4oTuDLnM9C8xyCzvHEKdPdhx59QPE/OKd+/J8UH8N3nkn MCPg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding; bh=ZNKMlMqCnWEejpyYrqjAlm7VZjFzSwuN7CcDvg7M9/o=; b=j5PNX202EX9avXw+Qx4A7JeXOfOQEgnQBNNQZVsOvjKYCd9vlkmZDnfKQwJbRblrWh 597Oom+6fbjvdX4uAMnw6sPHlTApL7f64NpruTrvtAD7UecuXT9VbV0e0aLbCVP94lPo AlYN9JqhvoV4gffuNWJ4H4eA3U4Lm3RslPQJpHekG1BQc3W8yGcoElbHf56Z4fyFthoZ jmeXWlqtXCExUeQPIUG4pZ+867n9ft0voKBNnyoy6daCnLklgSmh7OwEzOOWHVHLtHyd CGSqytmsFRIPVUmrLzgR0cpz67pzXgtpM8myFTqM/0ZBUxVuqclVKVMOhsqnyHHPsUdG Y9lQ== X-Gm-Message-State: AD7BkJKqFenpTf2F7ZraMOFM3ME3Aoj7C+mKzY0LG1VMmVHW44LWBUvt16Iv0JshWTbwE0Vn X-Received: by 10.28.22.74 with SMTP id 71mr11189873wmw.47.1459354732513; Wed, 30 Mar 2016 09:18:52 -0700 (PDT) Received: from xps13.localnet (164.17.90.92.rev.sfr.net. [92.90.17.164]) by smtp.gmail.com with ESMTPSA id u202sm20536967wmd.24.2016.03.30.09.18.50 (version=TLSv1/SSLv3 cipher=OTHER); Wed, 30 Mar 2016 09:18:52 -0700 (PDT) From: Thomas Monjalon To: "Dumitrescu, Cristian" Cc: dev@dpdk.org, "Singh, Jasvinder" , "Zhang, Roy Fan" , "Hunt, David" Date: Wed, 30 Mar 2016 17:50:18 +0200 Message-ID: <2177795.lZF7jR9sKJ@xps13> Organization: 6WIND User-Agent: KMail/4.14.10 (Linux/4.1.6-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <3EB4FA525960D640B5BDFFD6A3D89126479745AA@IRSMSX108.ger.corp.intel.com> References: <1455605170-16137-1-git-send-email-thomas.monjalon@6wind.com> <1519299.Ljb19TASP1@xps13> <3EB4FA525960D640B5BDFFD6A3D89126479745AA@IRSMSX108.ger.corp.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v2 2/4] examples/ip_pipeline: fix build for x86_64 without SSE4.2 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 30 Mar 2016 16:18:52 -0000 2016-03-30 14:15, Dumitrescu, Cristian: > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > > 2016-03-30 13:57, Dumitrescu, Cristian: > > > I think the correct fix is: > > > #if defined(__x86_64__) && (defined(RTE_MACHINE_CPUFLAG_SSE4_2) > > || defined(RTE_MACHINE_CPUFLAG_CRC32)) > > > > > > We'll test it and send a patch asap. > > > > I had prepared this patch. Please be inspired: > > > > examples/ip_pipeline: fix SSE4.2 optimization branch > > > > The branch was disabled because of a typo in the SSE4.2 flag. > > Change also the x86_64 flag to use a DPDK one. > > > > Fixes: 28377375c6c0 ("examples/ip_pipeline: fix build for x86_64 without > > SSE4.2") > > > > -#if defined(__x86_64__) && defined(RTE_CPUFLAG_SSE4_2) > > +#if defined(RTE_ARCH_X86_64) && > > defined(RTE_MACHINE_CPUFLAG_SSE4_2) > > Acked-by: Cristian Dumitrescu I thought you wanted to send a patch with another CPUFLAG (CRC32)?