From: Thomas Monjalon <thomas@monjalon.net>
To: dev@dpdk.org
Cc: bruce.richardson@intel.com, Liang Ma <liang.j.ma@intel.com>,
Peter Mccarthy <peter.mccarthy@intel.com>,
Harry van Haaren <harry.van.haaren@intel.com>,
Qi Zhang <qi.z.zhang@intel.com>,
Xiao Wang <xiao.w.wang@intel.com>,
Beilei Xing <beilei.xing@intel.com>,
Alfredo Cardigliano <cardigliano@ntop.org>,
Ferruh Yigit <ferruh.yigit@intel.com>
Subject: Re: [dpdk-dev] [PATCH] mk: ignore missing field initializers warning
Date: Thu, 06 Feb 2020 03:13:19 +0100 [thread overview]
Message-ID: <2178584.BjyWNHgNrj@xps> (raw)
In-Reply-To: <6b022ebe-0c6e-df76-bb83-90f5774be721@intel.com>
21/01/2020 16:55, Ferruh Yigit:
> On 1/21/2020 2:35 PM, Thomas Monjalon wrote:
> > Three warnings are commonly disabled in DPDK with make and meson:
> > * address-of-packed-member
> > always disabled
> > * missing-field-initializers
> > disabled with meson
> > disabled with make + clang or make + gcc < 4.7
> > disabled with make + gcc <= 5 for test files and event drivers
> > * packed-not-aligned
> > disabled with meson
> >
> > This change is removing exceptions for missing-field-initializers.
> > As it is always disabled, some redundant configs are cleaned up.
> >
> > Now the situation is:
> > * address-of-packed-member
> > always disabled
> > * missing-field-initializers
> > always disabled
> > * packed-not-aligned
> > disabled with meson
> >
> > It could alternatively be decided to disable missing-field-initializers
> > only for old gcc (< 6).
>
> I am not sure if we ever want 'missing-field-initializers' warnings, so +1 to
> drop it without version check as it is done in this patch.
>
> >
> > The warning packed-not-aligned is not modified in this change.
> >
> > Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
>
> Acked-by: Ferruh Yigit <ferruh.yigit@intel.com>
Applied
prev parent reply other threads:[~2020-02-06 2:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-21 14:35 Thomas Monjalon
2020-01-21 15:55 ` Ferruh Yigit
2020-02-06 2:13 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2178584.BjyWNHgNrj@xps \
--to=thomas@monjalon.net \
--cc=beilei.xing@intel.com \
--cc=bruce.richardson@intel.com \
--cc=cardigliano@ntop.org \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=harry.van.haaren@intel.com \
--cc=liang.j.ma@intel.com \
--cc=peter.mccarthy@intel.com \
--cc=qi.z.zhang@intel.com \
--cc=xiao.w.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).