From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id A2B7F2BC8 for ; Mon, 15 Oct 2018 10:51:34 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 4D98821FC7; Mon, 15 Oct 2018 04:51:34 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Mon, 15 Oct 2018 04:51:34 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=QzFeAx5mVFrulA1fWA7Xfc362+Rxz+wj38DOi5yaJiQ=; b=DznzN64+XUP/ jJvEqZGSAUGV6b2etYGyjh+CXfnOnvEHu4vcYzvBthyF1ZcXg0SbVghO312r+dwR pFv7pYAVSUwiVFyTI6PixP2VmLtWQTR1oLmukIQzO7OlkpGE+DVyS5LjOPtGhbi+ KJFQZvtzD+4brwVnhTTUXm556MpRvBc= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=QzFeAx5mVFrulA1fWA7Xfc362+Rxz+wj38DOi5yaJ iQ=; b=up1B59MW5ch//8w7AV9H8TsLuVTQHS4NHuzydt3+7g1PEBxzYaSDNfZAq hrpD6zhSwrSv7wfz9FsNEE8VzHETdPWLzUpdaXFGCC8CubO17ezQ+PNX5pTLtz7E sMwqFjgugLFhqq4OLSEvo55fA/3pPcrpYflOVmLpBhXPh6QWfz+1cglbCtj9PuoO 5NBin5qfRZnhn6wZcj0ELXo6liQsLaOfrxmsB0ouyjOhcXII3VPha2wasGYAmhHr V4wKVvl/Jg7dvQMw5gQC8W/Dizu1DnVHt7C9tzf819CivDscjtLfnUQGXoveoG/6 gWkzv8cdIFd6aOSugxaAmAhFhVjfA== X-ME-Sender: X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 026FAE4439; Mon, 15 Oct 2018 04:51:32 -0400 (EDT) From: Thomas Monjalon To: dev@dpdk.org Cc: gaetan.rivet@6wind.com, ophirmu@mellanox.com, qi.z.zhang@intel.com, ferruh.yigit@intel.com, Fiona Trahe , Ashish Gupta Date: Mon, 15 Oct 2018 10:51:33 +0200 Message-ID: <2178625.HfJZiVN0zS@xps> In-Reply-To: <20181014204747.26621-5-thomas@monjalon.net> References: <20180907230958.21402-1-thomas@monjalon.net> <20181014204747.26621-1-thomas@monjalon.net> <20181014204747.26621-5-thomas@monjalon.net> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v5 4/7] compressdev: remove driver name from logs X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 15 Oct 2018 08:51:34 -0000 +Cc Fiona and Ashish 14/10/2018 22:47, Thomas Monjalon: > The logs printed by COMPRESSDEV_LOG were prefixed with the driver name. > > In order to avoid assigning the driver before the end of the probing, > the driver name is removed from the compressdev library logs. > > Signed-off-by: Thomas Monjalon > --- > lib/librte_compressdev/rte_compressdev_pmd.c | 23 ++++++++------------ > 1 file changed, 9 insertions(+), 14 deletions(-) > > diff --git a/lib/librte_compressdev/rte_compressdev_pmd.c b/lib/librte_compressdev/rte_compressdev_pmd.c > index 7de4f339e..95beb26ab 100644 > --- a/lib/librte_compressdev/rte_compressdev_pmd.c > +++ b/lib/librte_compressdev/rte_compressdev_pmd.c > @@ -92,24 +92,20 @@ rte_compressdev_pmd_create(const char *name, > struct rte_compressdev *compressdev; > > if (params->name[0] != '\0') { > - COMPRESSDEV_LOG(INFO, "[%s] User specified device name = %s\n", > - device->driver->name, params->name); > + COMPRESSDEV_LOG(INFO, "User specified device name = %s\n", > + params->name); > name = params->name; > } > > - COMPRESSDEV_LOG(INFO, "[%s] - Creating compressdev %s\n", > - device->driver->name, name); > + COMPRESSDEV_LOG(INFO, "Creating compressdev %s\n", name); > > - COMPRESSDEV_LOG(INFO, > - "[%s] - Init parameters - name: %s, socket id: %d", > - device->driver->name, name, > - params->socket_id); > + COMPRESSDEV_LOG(INFO, "Init parameters - name: %s, socket id: %d", > + name, params->socket_id); > > /* allocate device structure */ > compressdev = rte_compressdev_pmd_allocate(name, params->socket_id); > if (compressdev == NULL) { > - COMPRESSDEV_LOG(ERR, "[%s] Failed to allocate comp device %s", > - device->driver->name, name); > + COMPRESSDEV_LOG(ERR, "Failed to allocate comp device %s", name); > return NULL; > } > > @@ -123,8 +119,8 @@ rte_compressdev_pmd_create(const char *name, > > if (compressdev->data->dev_private == NULL) { > COMPRESSDEV_LOG(ERR, > - "[%s] Cannot allocate memory for compressdev %s private data", > - device->driver->name, name); > + "Cannot allocate memory for compressdev" > + " %s private data", name); > > rte_compressdev_pmd_release_device(compressdev); > return NULL; > @@ -141,8 +137,7 @@ rte_compressdev_pmd_destroy(struct rte_compressdev *compressdev) > { > int retval; > > - COMPRESSDEV_LOG(INFO, "[%s] Closing comp device %s", > - compressdev->device->driver->name, > + COMPRESSDEV_LOG(INFO, "Closing comp device %s", > compressdev->device->name); > > /* free comp device */ >