From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM01-SN1-obe.outbound.protection.outlook.com (mail-sn1nam01on0069.outbound.protection.outlook.com [104.47.32.69]) by dpdk.org (Postfix) with ESMTP id DD2FE7CE2 for ; Mon, 17 Sep 2018 14:36:45 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=RFEP7cGSe7hSPCF0+C8FWnwucAvm9W5b7a0n8mQQ0Pc=; b=maXEC6pjz/RAMVZokaeo7N0pKM47vLwonav9zPIHOHHW8q1WmrEs9I5hc3nW9wVWeS90r7xOzlENB3IHWGLeL9dNu28H9eMSNLNqerTM+G+5FvI8wJJ3f6aUAZOHDB7Qnu67P9eN1Ns5vMG6Ja1p6LVyD+Srwj4cxfXYhxpTqWI= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Anoob.Joseph@cavium.com; Received: from [10.88.100.222] (115.113.156.2) by BN7PR07MB4899.namprd07.prod.outlook.com (2603:10b6:406:ef::28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1143.17; Mon, 17 Sep 2018 12:34:07 +0000 To: Akhil Goyal , Anoob Joseph , Pablo de Lara , Thomas Monjalon Cc: Murthy NSSR , Jerin Jacob , Narayana Prasad , dev@dpdk.org, Ankur Dwivedi , Nithin Dabilpuram , Ragothaman Jayaraman , Srisivasubramanian S , Tejasree Kondoj References: <1528476325-15585-1-git-send-email-anoob.joseph@caviumnetworks.com> <1536033560-21541-1-git-send-email-ajoseph@caviumnetworks.com> <1536033560-21541-10-git-send-email-ajoseph@caviumnetworks.com> <0b2cecb1-f055-61d6-3c10-802d0d647b96@nxp.com> From: "Joseph, Anoob" Message-ID: <21787cc6-1151-53e9-a86b-aa008b421fb1@caviumnetworks.com> Date: Mon, 17 Sep 2018 18:05:00 +0530 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <0b2cecb1-f055-61d6-3c10-802d0d647b96@nxp.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US X-Originating-IP: [115.113.156.2] X-ClientProxiedBy: PN1PR0101CA0057.INDPRD01.PROD.OUTLOOK.COM (2603:1096:c00:d::19) To BN7PR07MB4899.namprd07.prod.outlook.com (2603:10b6:406:ef::28) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: c05ef426-c558-4bd8-a143-08d61c99deb0 X-Microsoft-Antispam: BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989137)(5600074)(711020)(2017052603328)(7153060)(7193020); SRVR:BN7PR07MB4899; X-Microsoft-Exchange-Diagnostics: 1; BN7PR07MB4899; 3:dQoH/4ybejjUuimH7YIF20Le0gwvIPnepfUpnURCFPzPC9L/D0pOFOew32FHkP4Jk7ZJw2jhf9Xo8LXvoweaNuSal6K1cAM7W3u1nd/EZasMxCNPAltJwlOUTszkWVS0iQF/kviOsSkHPuXnzVjQAIFil6kbFBOKYFE6IFLPSy47+EEvFstMMHSRFUrEoIHGRyzgcxR4f8wxctAdIobM0jvJzn+GDyUd+vkab/lNAq/Zau6XkCa5Si/yQcNkqjTQ; 25:LSgcgz/01qH5GL/ZBtkpMOHQ///yhWjaHyPtfSFQ466gt6lncNzPUjzCcUCiQUgL233reKBnX28rg+cGdQAfEwqTesw1qLvA8YixY7fyOdFWcs6Walqb5WfSkv2c5l/Y+2SzpAPNtGSCqUtRJ4RWPdn9P5jnFCGGX49QcQGZut6ALX64acI6gywiOTv2+iRUXO3Qqr5MQts2jLZ+XgvkXH3/KZFN0Lc+dN4wbDOwJWugABKgEsOWLps3ngKWGARx58Q8tEmE14VgoCwsf976H7c8RGlh49JG9yvpoDkf2BgsU14gHNtIv9/n9Lrx2O4jKq/0sAmXLlZjfcrxvupRmg==; 31:Z6TlPJRFpqY0NhG26zOX0uXKKkVPtl/vChZQOtYxOKf3g6nynqOoNjAXiLKf8eAkH+FDi8AGecRI/7IeZqpKR2jeMwhXuJI099o2DafOlVf3XioF7NLgP01sEC8l7sG+QYoZcSV++m38lvKedNE2yCkHOKrk8euweADuCE71g0lv+E6SISAsj3wD0Qlf6UsSFgAknKPglR/I/wcZJvzBsOLOKtTcAEhAOlVgMGwqPWQ= X-MS-TrafficTypeDiagnostic: BN7PR07MB4899: X-Microsoft-Exchange-Diagnostics: 1; BN7PR07MB4899; 20:JP/IzufZzerrsBU+DkZEt23AGG0x2VITapuXa4GgDenkJLipqCUUkNc0q8XmBEv8ieZtu77W1P2wZOimK5mWEsvtoDMtRXF+1IhBxF/L+AqFrNCunX0kUc4IDE9s9bhVQ83fLtpNZj96fmK5Nh15hLCYHguTkOFZ/40U3mRaN047QhyousHT0IJMax1v1dMy04jcd8cNTBaWTXKtYSzDTUzy47rrW85eMP3aNCrHc51Lg5uug3wwZP6asSsA1iRMf2cTq5F3LgRJ9knDa/zYC7AjI/DvTZtp59E9ovS8riKTyVPA2hdTWfKgG/JjEDJ9i6B86DW5uPOD4ssPlgznIYZH/GOcl26xsi9lBTylmjScXMTQSNUQhTkdi6ieeE85ihHHVmg7cptcEeCMKeMA1O2x+WEKQYiAY5aDLVVpRKnXxggnWKUsng/56yRIrcw6qQQMnKNH17VCholF3dqcB4UEi50dvHBeigbAkg74CVasU3+yJBeaMUFKn8EWRHDNrXp08xmtR5HFN2ALYvdCrhWh8tO+z3sOqjrSi75nzMEGuV8cFMmIs4KeHzqcwzS5oOxTdShIwaxAvfdemE2Rq41TGNu49Md3up2NoF9jxZg=; 4:Leyc/bE+EFZUDpYm3sMO7tvu3Qr5eOCj38VXddlfW0HT4xX4mhHsCXJr1qkYP4DPaat12L1ojOnWNMO4wKcysshCIcSBBh9fe2j6oIgEWRk/bIWSnq+yQMSNoHO+qD8OxRDgvjU5LWB+rCoF4vzTochepCFMmuIN2Fz4GcNAgw+P8lkMHPv27iuD8Mpk/6cc8BnINoDT/mvfu6flUBMiNc7bp28086wbk8rYIUA7rpcMp/Flp0JmvLbPHamoS+gqzAzojH5AvzDYYyDHxw5org== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(3231355)(944501410)(52105095)(93006095)(10201501046)(3002001)(149027)(150027)(6041310)(20161123564045)(20161123558120)(20161123560045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123562045)(201708071742011)(7699050); SRVR:BN7PR07MB4899; BCL:0; PCL:0; RULEID:; SRVR:BN7PR07MB4899; X-Forefront-PRVS: 0798146F16 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(6049001)(39860400002)(366004)(136003)(396003)(376002)(346002)(189003)(199004)(6306002)(36756003)(16526019)(65826007)(31686004)(105586002)(7736002)(6666003)(106356001)(305945005)(26005)(8676002)(77096007)(81156014)(81166006)(486006)(42882007)(5660300001)(68736007)(66066001)(65956001)(53936002)(97736004)(2906002)(25786009)(4326008)(6246003)(65806001)(47776003)(446003)(2616005)(956004)(476003)(107886003)(11346002)(50466002)(3260700006)(316002)(16576012)(2870700001)(31696002)(229853002)(64126003)(8936002)(966005)(23676004)(52146003)(2486003)(52116002)(14444005)(72206003)(76176011)(53546011)(6116002)(3846002)(386003)(110136005)(478600001)(67846002)(58126008)(6486002)(93886005)(54906003); DIR:OUT; SFP:1101; SCL:1; SRVR:BN7PR07MB4899; H:[10.88.100.222]; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtCTjdQUjA3TUI0ODk5OzIzOnBZMWlScE82ZnNDamlwSGhmM2tNODRyZjkw?= =?utf-8?B?Z3ZCUXNPVHRRa2FMMWFTOGk0R2NPTnlvWXBkcmNmL09QU3ZIbDIweEltV0Ji?= =?utf-8?B?Y2dOTTUvZHQ0S2E2bUtVYVBqVTU5SHZlYnlzTE9WTExFYTBrNnduMEZzTzN5?= =?utf-8?B?UFRTRVlyelJFYmROcStKT1dMVThySEt5NjhjSHlIclBDalZEclFJNyt0Z0xY?= =?utf-8?B?cFJZNzlPYXNUZHRMeHFxRW83ajdjeGxTRWpYSFJ0UjJhenhwT2ROaXZhaHlh?= =?utf-8?B?YXliNCtDTVlIT1F1UEFhYVJlZFFRYkRpQUp2ZE4yZk82UnZweG9HVnU5THhx?= =?utf-8?B?cmhncFpyaTFWS2Q4K1VkNGJsU0VNdzNRY1J4bFhJL0NsNFRGWXlhcFU5R1A3?= =?utf-8?B?Z3dReVUrKzB6blk2MWozRlRVR1p3THpiMDNTUmU2NVdGU0hZWmtxTTFLN2RC?= =?utf-8?B?dnNpQWlLNTlZc0hMU1lSOERlTmdUMVBRNEdzWjc2bkx5K056U21ZR0ZOSzdD?= =?utf-8?B?K3BUUFl3Q0xHdVZEMnVXWTlROUhnTEdYNFJMU09PWldFMnpzeERVQzdnWXpB?= =?utf-8?B?OWdwa3dxTlAvRFQ0Yy9YbWtxeWUzY0JXenVyYzV5QjcwVVFUdG9jTjFaeGtl?= =?utf-8?B?eWdVT1MwZDNhQjdkUjc5Skc5NFlRTStadDJXWG1lQkZyQTNjMU1tNW82N1RI?= =?utf-8?B?Y1lDSlZsdjNHSjZyN0s1S1ZHd3p4SHBmcmRadlRzMWl0YXJkbHBLS0x1d0VS?= =?utf-8?B?RnE3Y2VNUDBpR3JkZG5TZzBDbXlkQkNqd1FoYVNEOThJcUpEV2RjYVlYTnBQ?= =?utf-8?B?YkNOMG1nNVp5aEExRk9ydko1UmRTSm43K2t6V1dEZjE1eVdlUmsyUmd6akNp?= =?utf-8?B?TlNRSW0rUTdSUEpTTlduM0dmSVRpakpWZFdLVTVSR1o5Z3Irc1RUdHNsSW9O?= =?utf-8?B?WmpQSk5zVG9hOVVTRWFzdFpmWFdLZHJwaGRIK2F4bzdpWU0yWXA4UUduODlx?= =?utf-8?B?enRGRUlFWWpHTk95Uk9KeWpIR0M0aVFxVlZiZDN0Mk14Zk9wMzVWOHpOTFpk?= =?utf-8?B?WWxTN0xSNWl1UG9ZZko0eWVxRG9rZnloZVdsMVBSelZGY0dMUnAwR1hRblJD?= =?utf-8?B?QjNOVGdVTnRZS3VLUDRVbWJJekJaTmovV210eks3aFpnZVkyVWxxdHU1U1M5?= =?utf-8?B?YkJOY1g4QTNLYmtvMkVvd1dkZVlTRUhXV01lOXg1T0J4RDFacHVHaVMvUUFM?= =?utf-8?B?SHlsQzNKTTl0YzFTUVQ3N1FHVFE4eHpEaXRNQjNtNXRWQTVSdUFsNVI3MjNQ?= =?utf-8?B?bjJDNW5vc0RkSFQ4SjJVVDJlYitoM1p2Z3pKM0ErWkUvOHFlM0RlMzN3QUhl?= =?utf-8?B?NmovdDFZZ1FMYW1vamMzL2FkMEZ5Yit1MSt3em1XbXhrdXFielIrQVhGVnda?= =?utf-8?B?N0tqZlorNU1JSlR2RVRzSEVwNVN2WjBBM0tnUUhNenNlVUthellzcUJCTitp?= =?utf-8?B?aXRTWmR2Zk1DR3A1SGI0VHhCQnpWMUpDWFVpYlRkelIxU3pLSzM3T3U5T2ZE?= =?utf-8?B?cXVYczlZWWs3QitiTFo5K2lLbFdsa2FTcGxPaFpTaVJ6NGN1UTlUZmVaMGNu?= =?utf-8?B?eGladFQ2Q0hGYlI0Nms3blJHeW9TbUdhV0xnUVVuMHdZRFExenN6U3NqU1BG?= =?utf-8?B?YnJYQm5EYXd2YlhiM3ZQbWd1clBtS3Z3Z2RhQngzNnpuL05HWUh1ZGg4OTRJ?= =?utf-8?B?dmd6aDZRdEYwc1VpL0pUS0RxZUhFQk9Ib014OVVzTVpRNHBUd1g2cW9ObTFn?= =?utf-8?B?bElVOE1BSkk1OThVUEJkOWNqbVpZTWcwWFdSTURpeVc2WldwYWhVcEZmTlN4?= =?utf-8?B?Z0QxZXBBMXNMeGZXU3htVEhTMS9yalJ0R1hveldYVTFTUDMrUTFFQytiL01X?= =?utf-8?B?WmdSZVF0bHl3d3VlT1pTQ1IxTlRqTy9CRHBLcmp2TjNlN3JhdmhjY04xOGx0?= =?utf-8?B?T0xXTnNtTE9TYUx3WHUrd3BkMjBWSjhxRThJQWhyUmUwa1VUSFQrM3ZORlZ6?= =?utf-8?B?Zk4zd2o3eVVmWmJ4L3ZDbWcrYzFtSlRWVC9lU2Mram1JVCswSVJQVkFGbklT?= =?utf-8?Q?wfE7WvIJKoYCUewPjsmi1vc=3D?= X-Microsoft-Antispam-Message-Info: qqLSwvBp2+uN/sEoDeaUQeLxp+bxfXYHj7k1WBqK1ItVpT18JVvdNoHpkS9n+9FSGAYgsQ79sJLD8ujf8fZTpqnbSluAn0bQxqSETbagl4voZJkd+OOmL2nHh119N7GwLJo62GfHQBF6Ip0IwvjnhF90jZ2cEj14yd1rw9taemyuEac5+6PN7kzB0SdDf8JPmWqmG2qYWGOsaBbFeXBLtTNBpzxLqxOUm7H1jldIHIqAfpilZ2UuDPCcUB9qdeRW6nbG7Xz82fFbwip4kx+l0/HTFwsQU6lM6RBzzeniKYkxL1xRzhXbBkdO8LCCSN2YiFabNSszh7PkFvSZCdighA== X-Microsoft-Exchange-Diagnostics: 1; BN7PR07MB4899; 6:FjvNLynoWKRA8VlHjAG8mRLiMKm5lwrTn4oxsr5mhSGjxNR9jdVlvnkl3+cWCPu0yc9UanBMGjxoOqz494dmt5gF+9rP/ziTj3acYF8jPWXEIyUnt9/J1cl9bT097F++RmFnMQwRM272BxAIwhgDqzW1w9KyxNWzi8tIMoXhTZd94R1vT9WdOq/HU0S01mGNkEhcRFyfswgzP72SxdxB4iHY52gnJU485jqIueMsYpuFCHmOu3HOGl9XrCuBJhaJpltEwsJjM5xK8RYReiMajcLxC1mEHlTYDKAF6BJvRUp247DduXPM0XPEJ/ethMJdVX7vDMFcaED6n60PNrn1RSNwvxVhGGaBbGgYvaPswxevHQRVJ56nCt0MrfpoNacij8AWW7aC2/3cU7+NhvRmYbvawRzw+WTofraePkka2YrebkRKj1ZclG8UOn+S0qP3Lsu7k6PAnbAFlgi7UWQFVQ==; 5:mjYg7zEyPJcgCf9lDXxnenSpzamE5LPD/sz0bF3/qNB1ivLt1Tf/eAaULpnoJx/T2UVP6+vhPKpzvKlmkybthtxYFD+jNtO/H9DQdQBBLoBdQaa5TcC5dg6XJhiemnz2M310iH0IgqCExcjFMix/97gJX9iScDDEje04SQVyAzc=; 7:xNGt4tzXn7gsfTPwIvmkeylQ82cXgec7IpXoUCIZgYt40PN8UTJZgmMdI0nTsCwErZb4G9bOiLo2Kqr57X46Ykxu2QgkPqTXt6FY1WGjFGctqnk1l7FDPugAkB7VCrJ3zT6EoQawvIatUrrpn62rZ7BPkyTzl6XJsTZLgoOogIWLRmUrtxhYXDSTbKPUnqjnKX/7fTwKcxLL675M2d15KAdnJOKuQi0AqNKHh6JNf3Mh9jrnuuAZJlnS7frIvMeG SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Sep 2018 12:34:07.8073 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: c05ef426-c558-4bd8-a143-08d61c99deb0 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN7PR07MB4899 Subject: Re: [dpdk-dev] [PATCH v2 09/33] crypto/octeontx: adds symmetric capabilities X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 17 Sep 2018 12:36:46 -0000 Hi Akhil, On 17-09-2018 17:31, Akhil Goyal wrote: > External Email > >> diff --git a/drivers/crypto/octeontx/otx_cryptodev_ops.c >> b/drivers/crypto/octeontx/otx_cryptodev_ops.c >> index d25f9c1..cc0030e 100644 >> --- a/drivers/crypto/octeontx/otx_cryptodev_ops.c >> +++ b/drivers/crypto/octeontx/otx_cryptodev_ops.c >> @@ -10,9 +10,15 @@ >>   #include "cpt_pmd_logs.h" >> >>   #include "otx_cryptodev.h" >> +#include "otx_cryptodev_capabilities.h" >>   #include "otx_cryptodev_hw_access.h" >>   #include "otx_cryptodev_ops.h" >> >> +static const struct rte_cryptodev_capabilities otx_capabilities[] = { >> +     OTX_SYM_CAPABILITIES, >> +     RTE_CRYPTODEV_END_OF_CAPABILITIES_LIST() >> +}; >> + > > better to have otx_capabilities structure defined in the > otx_cryptodev_capabilities.h > > I don't see any value addition of creating a macro in one file using > in a separate structure in another file > > which doesn't have anything new in that structure. It would also give > checkpatch error. > > You can directly have a capability structure without the #define. This was the convention followed in qat driver. https://git.dpdk.org/dpdk/tree/drivers/crypto/qat/qat_sym_capabilities.h I guess it was to avoid variable definition in header. May be Pablo too can comment on this. I'll make the change accordingly. Thanks, Anoob