DPDK patches and discussions
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas@monjalon.net>
To: "Pattan, Reshma" <reshma.pattan@intel.com>
Cc: "Somarowthu, Naga SureshX" <naga.sureshx.somarowthu@intel.com>,
	"dev@dpdk.org" <dev@dpdk.org>,
	"Burakov, Anatoly" <anatoly.burakov@intel.com>,
	"Parthasarathy, JananeeX M" <jananeex.m.parthasarathy@intel.com>
Subject: Re: [dpdk-dev] [PATCH v10 0/5] add unit tests for bitrate, latency and pdump libraries
Date: Fri, 03 Aug 2018 16:11:03 +0200	[thread overview]
Message-ID: <2179132.BP2OZL8SCC@xps> (raw)
In-Reply-To: <3AEA2BF9852C6F48A459DA490692831F2A378E6C@IRSMSX109.ger.corp.intel.com>

03/08/2018 15:45, Pattan, Reshma:
> Hi Thomas,
> 
> From: Thomas Monjalon [mailto:thomas@monjalon.net]
> Sent: Wednesday, August 1, 2018 8:52 AM
> > 
> > 01/08/2018 00:18, Reshma Pattan:
> > > v10: fixed clang compiler issues and freed latency stats memzone in
> > > latency stats unit tests.
> > > v9: rebased ontop of latest autotest changes and added new tests to
> > > the autotest list
> > > v8: renamed commit headline and freed the metrics memzone for bitrate
> > > ut
> > > v7: removed unused macros and corrected the comment
> > > v6: updated ring variable appropriately
> > > v5: rebased, freed pools and rings, created common patch set
> > > ---
> > 
> > Sorry, the integration of this patchset is very painful.
> > 
> > After asking for rebase, for clang fix, there are still some basic errors with 32-
> > bit compilation:
> > 
> > 	test_latencystats.c:131:21: error:
> > 	format ‘%ld’ expects argument of type ‘long int’,
> > 	but argument 2 has type ‘uint64_t’ {aka ‘long long unsigned int’}
> > 
> > linkage:
> > 
> > 	test@test@@dpdk-test@exe/test.c.o:(.data+0x18): undefined
> > reference to `test_pdump'
> > 
> > or even MAINTAINERS file:
> > 
> > 	test/test/sample_packet_forward.c
> > 	test/test/sample_packet_forward.h
> > 	test/test/test_bitratestats.c
> > 	test/test/test_latencystats.c
> > 
> > I have already spent too much time on it, despite it is not fixing 18.08.
> > 
> > Please do a complete detailed review of this series, so it can be considered for
> > 18.11.
> > 
> 
> We missed to do these basic checks, apologies for consuming your time.
>  Naga Suresh has now proactively worked on fixing these issues and running pre checks on patches and addressed in v12.
> The earlier versions were reviewed by me, Remy and Anatoly . So we request you to consider latest patches for 18.08,
> until unless they don’t give any last minute  surprises.

Sorry, I consider it is now too late for such patch in 18.08.
It is not fixing any issue.

Last days of 18.08 cycle will be really focus on bugs and doc.

  reply	other threads:[~2018-08-03 14:11 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-31 22:18 Reshma Pattan
2018-07-31 22:18 ` [dpdk-dev] [PATCH v10 1/5] test: add helper functions for tests using ring-PMD Rx/Tx Reshma Pattan
2018-07-31 22:18 ` [dpdk-dev] [PATCH v10 2/5] test: add unit tests for bitrate library Reshma Pattan
2018-07-31 22:18 ` [dpdk-dev] [PATCH v10 3/5] test: add unit tests for latencystats library Reshma Pattan
2018-07-31 22:18 ` [dpdk-dev] [PATCH v10 4/5] test: add unit test for pdump library Reshma Pattan
2018-07-31 22:18 ` [dpdk-dev] [PATCH v10 5/5] autotest: add new unit tests to autotest list Reshma Pattan
2018-07-31 22:30 ` [dpdk-dev] [PATCH v10 0/5] add unit tests for bitrate, latency and pdump libraries Thomas Monjalon
2018-08-01  7:52 ` Thomas Monjalon
2018-08-03 13:45   ` Pattan, Reshma
2018-08-03 14:11     ` Thomas Monjalon [this message]
2018-08-03 14:16     ` Parthasarathy, JananeeX M
2018-08-03 15:01       ` Thomas Monjalon
2018-08-03 12:05 ` [dpdk-dev] [PATCH v11 0/6] " Naga Suresh Somarowthu
2018-08-03 12:05   ` [dpdk-dev] [PATCH v11 1/6] test: add helper functions for tests using ring-PMD Rx/Tx Naga Suresh Somarowthu
2018-08-03 12:05   ` [dpdk-dev] [PATCH v11 2/6] test: add unit tests for bitrate library Naga Suresh Somarowthu
2018-08-03 12:05   ` [dpdk-dev] [PATCH v11 3/6] test: add unit tests for latencystats library Naga Suresh Somarowthu
2018-08-03 12:05   ` [dpdk-dev] [PATCH v11 4/6] test: add unit test for pdump library Naga Suresh Somarowthu
2018-08-03 12:05   ` [dpdk-dev] [PATCH v11 5/6] autotest: add new unit tests to autotest list Naga Suresh Somarowthu
2018-08-03 12:05   ` [dpdk-dev] [PATCH v11 6/6] maintainers: add bitrate latency pdump tests Naga Suresh Somarowthu
2018-08-03 12:34   ` [dpdk-dev] [PATCH v12 0/6] add unit tests for bitrate, latency and pdump libraries Naga Suresh Somarowthu
2018-08-03 12:34     ` [dpdk-dev] [PATCH v12 1/6] test: add helper functions for tests using ring-PMD Rx/Tx Naga Suresh Somarowthu
2018-08-03 12:34     ` [dpdk-dev] [PATCH v12 2/6] test: add unit tests for bitrate library Naga Suresh Somarowthu
2018-08-03 12:34     ` [dpdk-dev] [PATCH v12 3/6] test: add unit tests for latencystats library Naga Suresh Somarowthu
2018-08-03 12:34     ` [dpdk-dev] [PATCH v12 4/6] test: add unit test for pdump library Naga Suresh Somarowthu
2018-08-03 12:34     ` [dpdk-dev] [PATCH v12 5/6] autotest: add new unit tests to autotest list Naga Suresh Somarowthu
2018-08-03 12:34     ` [dpdk-dev] [PATCH v12 6/6] maintainers: add bitrate latency pdump tests Naga Suresh Somarowthu
2018-08-24 12:51     ` [dpdk-dev] [PATCH v13 0/4] add unit tests for bitrate, latency and pdump libraries Naga Suresh Somarowthu
2018-08-24 12:51       ` [dpdk-dev] [PATCH v13 1/4] test: add helper functions for tests using ring-PMD Rx/Tx Naga Suresh Somarowthu
2018-08-24 12:51       ` [dpdk-dev] [PATCH v13 2/4] test: add unit tests for bitrate library Naga Suresh Somarowthu
2018-08-24 12:51       ` [dpdk-dev] [PATCH v13 3/4] test: add unit tests for latencystats library Naga Suresh Somarowthu
2018-08-24 12:51       ` [dpdk-dev] [PATCH v13 4/4] test: add unit test for pdump library Naga Suresh Somarowthu
2018-08-07  8:46   ` [dpdk-dev] [PATCH v11 0/6] add unit tests for bitrate, latency and pdump libraries Burakov, Anatoly

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2179132.BP2OZL8SCC@xps \
    --to=thomas@monjalon.net \
    --cc=anatoly.burakov@intel.com \
    --cc=dev@dpdk.org \
    --cc=jananeex.m.parthasarathy@intel.com \
    --cc=naga.sureshx.somarowthu@intel.com \
    --cc=reshma.pattan@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).