From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 18D851B561 for ; Fri, 3 Aug 2018 16:11:11 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id B07C321EBD; Fri, 3 Aug 2018 10:11:10 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Fri, 03 Aug 2018 10:11:10 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=mesmtp; bh=k559MQKUajnhr1hKoypdQYgH6A 3gAJutXc83S8XQQNs=; b=eqbHhuxjLTp21ufwR4LFRFEBFBmhDleHY+RNyDZhf6 spee+AkG4Npg1rZANGC30iIcTxOWdrHCPY2NFV1YIEcmNOanoVQOgDCxQKhAE7ps pzSO9tebc/npDBgPsrUHteLrVsiIOiSQnN+pwpghivrh3HyJp2pErF58U3ut6QKO 8= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=k559MQ KUajnhr1hKoypdQYgH6A3gAJutXc83S8XQQNs=; b=iBbq0CUEa+QuNorASmTYwW mmfog2HlMyx+l/rohKH040s1HnvcuQTwRMoQUPaHRSn03ZHKp3SOuwjdAJOJk4+G k8rhj2lsG1uGUxPxNZpKtLfFJev2+VgT8pvXNs+akwaMrOiY0rcKqceiJA9KxnZQ nFjCAhbw+5kOvv5zdYN3bvU7pRFM8ACaqS6U6N+A1iy5WM97gbwLB2o2DFwN2y5Q ZgiWuD4G+vRJnD3EGF24GPxdt6p0Qo/IIpa1pQHCWM6KWbqdq8Twm9ep+p91BG0R 3nBp2vjfGIccc/NNt5eeQ9F4vj4yQwrgy39Cc8myZVhzj6kCfxi2lQE4pPgbfy+Q == X-ME-Proxy: X-ME-Sender: Received: from xps.localnet (114.149.6.93.rev.sfr.net [93.6.149.114]) by mail.messagingengine.com (Postfix) with ESMTPA id B875D10286; Fri, 3 Aug 2018 10:11:09 -0400 (EDT) From: Thomas Monjalon To: "Pattan, Reshma" Cc: "Somarowthu, Naga SureshX" , "dev@dpdk.org" , "Burakov, Anatoly" , "Parthasarathy, JananeeX M" Date: Fri, 03 Aug 2018 16:11:03 +0200 Message-ID: <2179132.BP2OZL8SCC@xps> In-Reply-To: <3AEA2BF9852C6F48A459DA490692831F2A378E6C@IRSMSX109.ger.corp.intel.com> References: <1533075501-10135-1-git-send-email-reshma.pattan@intel.com> <29483712.ychiUti4Sd@xps> <3AEA2BF9852C6F48A459DA490692831F2A378E6C@IRSMSX109.ger.corp.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v10 0/5] add unit tests for bitrate, latency and pdump libraries X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 03 Aug 2018 14:11:11 -0000 03/08/2018 15:45, Pattan, Reshma: > Hi Thomas, >=20 > From: Thomas Monjalon [mailto:thomas@monjalon.net] > Sent: Wednesday, August 1, 2018 8:52 AM > >=20 > > 01/08/2018 00:18, Reshma Pattan: > > > v10: fixed clang compiler issues and freed latency stats memzone in > > > latency stats unit tests. > > > v9: rebased ontop of latest autotest changes and added new tests to > > > the autotest list > > > v8: renamed commit headline and freed the metrics memzone for bitrate > > > ut > > > v7: removed unused macros and corrected the comment > > > v6: updated ring variable appropriately > > > v5: rebased, freed pools and rings, created common patch set > > > --- > >=20 > > Sorry, the integration of this patchset is very painful. > >=20 > > After asking for rebase, for clang fix, there are still some basic erro= rs with 32- > > bit compilation: > >=20 > > test_latencystats.c:131:21: error: > > format =E2=80=98%ld=E2=80=99 expects argument of type =E2=80=98long in= t=E2=80=99, > > but argument 2 has type =E2=80=98uint64_t=E2=80=99 {aka =E2=80=98long = long unsigned int=E2=80=99} > >=20 > > linkage: > >=20 > > test@test@@dpdk-test@exe/test.c.o:(.data+0x18): undefined > > reference to `test_pdump' > >=20 > > or even MAINTAINERS file: > >=20 > > test/test/sample_packet_forward.c > > test/test/sample_packet_forward.h > > test/test/test_bitratestats.c > > test/test/test_latencystats.c > >=20 > > I have already spent too much time on it, despite it is not fixing 18.0= 8. > >=20 > > Please do a complete detailed review of this series, so it can be consi= dered for > > 18.11. > >=20 >=20 > We missed to do these basic checks, apologies for consuming your time. > Naga Suresh has now proactively worked on fixing these issues and runnin= g pre checks on patches and addressed in v12. > The earlier versions were reviewed by me, Remy and Anatoly . So we reques= t you to consider latest patches for 18.08, > until unless they don=E2=80=99t give any last minute surprises. Sorry, I consider it is now too late for such patch in 18.08. It is not fixing any issue. Last days of 18.08 cycle will be really focus on bugs and doc.