Re: [dpdk-dev] [PATCH] ethdev: remove deprecated statistics

[Thomas Monjalon <thomas.monjalon@6wind.com>]

2016-04-19 16:03, Thomas Monjalon:
> Some statistics were deprecated since release 2.1 (49f386542af4).
> 
> The last deprecated counter to be used was imcasts.
> 
> The new counters should be added to extended statistics.
> 
> Signed-off-by: Thomas Monjalon <thomas.monjalon@6wind.com>
[...]
> --- a/lib/librte_ether/rte_ethdev.h
> +++ b/lib/librte_ether/rte_ethdev.h
> @@ -200,27 +200,9 @@ struct rte_eth_stats {
>  	/**< Total of RX packets dropped by the HW,
>  	 * because there are no available mbufs (i.e. RX queues are full).
>  	 */
> -	uint64_t ibadcrc __rte_deprecated;
> -	/**< Deprecated; Total of RX packets with CRC error. */
> -	uint64_t ibadlen __rte_deprecated;
> -	/**< Deprecated; Total of RX packets with bad length. */
>  	uint64_t ierrors;   /**< Total number of erroneous received packets. */
>  	uint64_t oerrors;   /**< Total number of failed transmitted packets. */
> -	uint64_t imcasts;
> -	/**< Deprecated; Total number of multicast received packets. */
>  	uint64_t rx_nombuf; /**< Total number of RX mbuf allocation failures. */
> -	uint64_t fdirmatch __rte_deprecated;
> -	/**< Deprecated; Total number of RX packets matching a filter. */
> -	uint64_t fdirmiss __rte_deprecated;
> -	/**< Deprecated; Total number of RX packets not matching any filter. */
> -	uint64_t tx_pause_xon __rte_deprecated;
> -	 /**< Deprecated; Total nb. of XON pause frame sent. */
> -	uint64_t rx_pause_xon __rte_deprecated;
> -	/**< Deprecated; Total nb. of XON pause frame received. */
> -	uint64_t tx_pause_xoff __rte_deprecated;
> -	/**< Deprecated; Total nb. of XOFF pause frame sent. */
> -	uint64_t rx_pause_xoff __rte_deprecated;
> -	/**< Deprecated; Total nb. of XOFF pause frame received. */
>  	uint64_t q_ipackets[RTE_ETHDEV_QUEUE_STAT_CNTRS];
>  	/**< Total number of queue RX packets. */
>  	uint64_t q_opackets[RTE_ETHDEV_QUEUE_STAT_CNTRS];

I suggest to remove also the loopback statistics which are implemented only
for igbvf and available as extended stats:

--- a/lib/librte_ether/rte_ethdev.h
+++ b/lib/librte_ether/rte_ethdev.h
@@ -213,14 +213,6 @@ struct rte_eth_stats {
        /**< Total number of successfully transmitted queue bytes. */
        uint64_t q_errors[RTE_ETHDEV_QUEUE_STAT_CNTRS];
        /**< Total number of queue packets received that are dropped. */
-       uint64_t ilbpackets;
-       /**< Total number of good packets received from loopback,VF Only */
-       uint64_t olbpackets;
-       /**< Total number of good packets transmitted to loopback,VF Only */
-       uint64_t ilbbytes;
-       /**< Total number of good bytes received from loopback,VF Only */
-       uint64_t olbbytes;
-       /**< Total number of good bytes transmitted to loopback,VF Only */
 };

--- a/drivers/net/e1000/igb_ethdev.c
+++ b/drivers/net/e1000/igb_ethdev.c
@@ -1805,10 +1805,6 @@ eth_igbvf_stats_get(struct rte_eth_dev *dev, struct rte_eth_stats *rte_stats)
        rte_stats->ibytes = hw_stats->gorc;
        rte_stats->opackets = hw_stats->gptc;
        rte_stats->obytes = hw_stats->gotc;
-       rte_stats->ilbpackets = hw_stats->gprlbc;
-       rte_stats->ilbbytes = hw_stats->gorlbc;
-       rte_stats->olbpackets = hw_stats->gptlbc;
-       rte_stats->olbbytes = hw_stats->gotlbc;
 }

I'll send a v2 if no objection.