From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
by inbox.dpdk.org (Postfix) with ESMTP id 83EF142D2E;
Fri, 23 Jun 2023 11:32:04 +0200 (CEST)
Received: from mails.dpdk.org (localhost [127.0.0.1])
by mails.dpdk.org (Postfix) with ESMTP id 7107040EE4;
Fri, 23 Jun 2023 11:32:02 +0200 (CEST)
Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com
[66.111.4.25]) by mails.dpdk.org (Postfix) with ESMTP id 2CA3F40E09
for <dev@dpdk.org>; Fri, 23 Jun 2023 11:32:00 +0200 (CEST)
Received: from compute6.internal (compute6.nyi.internal [10.202.2.47])
by mailout.nyi.internal (Postfix) with ESMTP id 43C165C0115;
Fri, 23 Jun 2023 05:31:59 -0400 (EDT)
Received: from mailfrontend1 ([10.202.2.162])
by compute6.internal (MEProxy); Fri, 23 Jun 2023 05:31:59 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=
cc:cc:content-transfer-encoding:content-type:content-type:date
:date:from:from:in-reply-to:in-reply-to:message-id:mime-version
:references:reply-to:sender:subject:subject:to:to; s=fm2; t=
1687512719; x=1687599119; bh=6DWlJswUXeVyx9Howd6/u+G5UzicNgothRs
1dmeb/Xg=; b=Q0IBqYOUhKFmqjkzcauhgYlkEtDNG48xnXk1RLpSG4MUBeR82qM
UU6U2CbJnD5SHfzdDDCqvoiqmrga8THtUWOhenGi5kEMssDk9pm3fVv409pDrE2k
GJU+AF/RvhlQhZ0e+Nt0K/pe1vmCDRPTmGuxoenn2wHGLtQXqhNQS5TGukoakP9l
URWxLv/4h9O8BqhXcR1MTMtzVh0wZkeVIXmEXmjiKHIUaEnmAbgHBzcwoEgrLj0L
GY4oLppmP3p1fZx5oE3eGVQo2+e2W5w6srdf38F4x4LTvhmrbgiHqnoicrHMQx0n
u2bVyyzqtk+nUceW+EePJzU7VTYvNh/kJgQ==
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
messagingengine.com; h=cc:cc:content-transfer-encoding
:content-type:content-type:date:date:feedback-id:feedback-id
:from:from:in-reply-to:in-reply-to:message-id:mime-version
:references:reply-to:sender:subject:subject:to:to:x-me-proxy
:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=
1687512719; x=1687599119; bh=6DWlJswUXeVyx9Howd6/u+G5UzicNgothRs
1dmeb/Xg=; b=dz3GVBhhNFGmIgCKmuxXhy8IhyLPfDNMwD2bWkjoSvdBW4EP62W
+28HUN5OW5jp7TvwjZuOf5KuR0qE+t73F7GgPOEqWPtWCj5ZFa+Z6IokA39XgMQo
VSyR1PPlljIn5uae60NBIbrLthTnUc7vD/WSfMAUHpdxmxho9OO7Qzsm4TzZ8Mjl
IUbokEzsMKisTI9EAzpQXxJqDS4ldf3AhVUgc27m7cKucJfWt3ziYqSBxWDoAXhA
Qmj3NGo3WF1FcJvS9Rj8qRSwAHAJi8g9yjYpPNsSEmkCf/l7h+00EXmxY/VHBP6x
mYZ3UxW5cQTnGG60hJjXuON5ZI+Tg0NXCiQ==
X-ME-Sender: <xms:jmaVZBVEU8Kihfn0ampjTODFSfoE8ABj1kYVkuQF5G5xfrQQMIOriQ>
<xme:jmaVZBn38M2otbjnb_vZ8ierzIpStd0AfhobvvFsb0axaqXNbmYpyukrrbMwweA9k
5MZM6CquUB-xcKAdA>
X-ME-Received: <xmr:jmaVZNYDBp4E8bnTGXtFVDdVKn0RTuDK_f4skRWYPryltmH1xwsmL-GtvYi_ITRm3h8Odl1d7L44dj59roa0--SorA>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrgeeggedgudejucetufdoteggodetrfdotf
fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen
uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne
cujfgurhephffvvefufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhm
rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc
ggtffrrghtthgvrhhnpeehgeehjeeitdeffeejudeivddvleehuddvveekvdehteehjedv
gfeltdffhfduudenucffohhmrghinhepkhgvhidruggrthgrnecuvehluhhsthgvrhfuih
iivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhho
nhdrnhgvth
X-ME-Proxy: <xmx:jmaVZEVSLRIRSF0oYi8ClYSqSDnWFfeVIcYudmUvvbZwP7FrJSPMXQ>
<xmx:jmaVZLnJFV8yy_mZjXTjWaRHw7SLbd8oUbfx4fIcejLB8PQj4INJjg>
<xmx:jmaVZBe29fTwC7T0tDcIzEJOA52h4R4D5zGqtgaoLIPwTb2iJDWJPQ>
<xmx:j2aVZAz1oJV9JofZsP3d943GGmRSZKt2JO-PQCaVNDuLA-0shfsm9A>
Feedback-ID: i47234305:Fastmail
Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri,
23 Jun 2023 05:31:58 -0400 (EDT)
From: Thomas Monjalon <thomas@monjalon.net>
To: Suanming Mou <suanmingm@nvidia.com>, Akhil Goyal <gakhil@marvell.com>
Cc: dev@dpdk.org, "rasland@nvidia.com" <rasland@nvidia.com>
Subject: Re: [EXT] [PATCH v4 0/9] crypto/mlx5: support AES-GCM
Date: Fri, 23 Jun 2023 11:31:56 +0200
Message-ID: <2181949.1BCLMh4Saa@thomas>
In-Reply-To: <CO6PR18MB4484731192246460E520E05AD85CA@CO6PR18MB4484.namprd18.prod.outlook.com>
References: <20230418092325.2578712-1-suanmingm@nvidia.com>
<20230620141115.841226-1-suanmingm@nvidia.com>
<CO6PR18MB4484731192246460E520E05AD85CA@CO6PR18MB4484.namprd18.prod.outlook.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
20/06/2023 20:49, Akhil Goyal:
> > AES-GCM provides both authenticated encryption and the ability to check
> > the integrity and authentication of additional authenticated data (AAD)
> > that is sent in the clear.
[...]
> Series applied to dpdk-next-crypto
This has to be added to avoid a compilation failure with MinGW:
@@ -25,6 +25,8 @@ mlx5_crypto_dek_get_key(struct rte_crypto_sym_xform *xform,
*key = xform->aead.key.data;
*key_len = xform->aead.key.length;
} else {
+ *key = NULL;
+ *key_len = 0;
DRV_LOG(ERR, "Xform dek type not supported.");
rte_errno = -EINVAL;
return -1;
I will squash it where appropriate.