From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id C744EA04E6; Mon, 7 Dec 2020 21:44:06 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 21382E07; Mon, 7 Dec 2020 21:44:05 +0100 (CET) Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by dpdk.org (Postfix) with ESMTP id 2AEC7DE3 for ; Mon, 7 Dec 2020 21:44:04 +0100 (CET) Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.nyi.internal (Postfix) with ESMTP id 7C0B85C0270; Mon, 7 Dec 2020 15:44:02 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Mon, 07 Dec 2020 15:44:02 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm2; bh= vN+8NscuCFBpU/58mNZjghLBUr28ZRsSmI2oWw2lGTQ=; b=vCgQhUZ8xYgrw3Q/ kwCLM8BVEP2HI03yr6Cl6wNf6YF5ECIt0+AyHC13GWZR4enqhXS6/5ZakgF9+siw kb8laaINoyNp62vFm62TxuUHfwjH78KhPXQmNrdBSeC02MTrbg+gSN4AEeabTVwt fjkjspo0dv2cK04SZsLibBS5/TBI49kpj5IB8V6++D3NDVLYMV+Ug2fkCvo71xPG 9dT+w0l8IKXn3DpuVkzJf9hyQPcOPBlpE2fw5B032+DbZCSXXht8vxhJRjEXOKb6 6+YAsrpl5QbJX1jsNQ/QTVGWxVVN/l+dFY64oDksDqBi5G54K0XlFAs0K/SwC9SJ 6JDw3Q== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=vN+8NscuCFBpU/58mNZjghLBUr28ZRsSmI2oWw2lG TQ=; b=DzamwA47Fq5yFdP42HVbXgRWDydVoJd6d6UDCdjThrVmeoNkyaDlWx190 /G90Jcrio42kDCFZQ9tyFAm0RWeQR5WjhRN+3278Y0lq4uwL2bDQy67W1Mees1Id TfOvBzkkSMoQYxRM7cCSc9etVyZsp0CNCuUWOXKyZ0PqKUTq19Ycl0ZemS5y6kKk NqiBOPnU7T2XsPc2C7H6fyS8HpnyqrkVOLy4aEGFkfeeXbPVfJcZpPSmWmRpE6ZD W2iU0Wbkw8mYnDun9CqBZIZhKGYSIf26YCdA5xBUQXJU0/0iSvRBkErkjmzsL052 PgStlA4fqox0HWvVCU81LoElhwn3Q== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedujedrudejgedgudegtdcutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhm rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc ggtffrrghtthgvrhhnpeffvdffjeeuteelfeeileduudeugfetjeelveefkeejfeeigeeh teffvdekfeegudenucffohhmrghinhepughpughkrdhorhhgnecukfhppeejjedrudefge drvddtfedrudekgeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhl fhhrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 9BB411080057; Mon, 7 Dec 2020 15:44:00 -0500 (EST) From: Thomas Monjalon To: Tal Shnaiderman , "Kadam, Pallavi" Cc: dev@dpdk.org, dmitry.kozliuk@gmail.com, navasile@linux.microsoft.com, dmitrym@microsoft.com, david.marchand@redhat.com Date: Mon, 07 Dec 2020 21:43:58 +0100 Message-ID: <2182155.m87HpnhbMa@thomas> In-Reply-To: <2b0afab6-ad6e-10cf-6055-a07a77d075c4@intel.com> References: <20201126080639.16240-1-talshn@nvidia.com> <2b0afab6-ad6e-10cf-6055-a07a77d075c4@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] eal/windows: add stub for rte_intr_callback_register X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 05/12/2020 01:56, Kadam, Pallavi: > Hi Tal, > > On 11/26/2020 12:06 AM, Tal Shnaiderman wrote: > > interrupt callback register is not implemented in Windows. > > Add stub with -ENOTSUP return value and export the function. > > > > Signed-off-by: Tal Shnaiderman > > --- > > lib/librte_eal/rte_eal_exports.def | 1 + > > lib/librte_eal/windows/eal_interrupts.c | 9 +++++++++ > > 2 files changed, 10 insertions(+) > > > > diff --git a/lib/librte_eal/rte_eal_exports.def b/lib/librte_eal/rte_eal_exports.def > > index 6a6be1cfa6..08cf25ea01 100644 > > --- a/lib/librte_eal/rte_eal_exports.def > > +++ b/lib/librte_eal/rte_eal_exports.def > > @@ -63,6 +63,7 @@ EXPORTS > > rte_get_tsc_hz > > rte_hexdump > > rte_hypervisor_get > > + rte_intr_callback_register > > rte_intr_rx_ctl > > rte_lcore_count > > rte_lcore_has_role > > diff --git a/lib/librte_eal/windows/eal_interrupts.c b/lib/librte_eal/windows/eal_interrupts.c > > index 6c64a48f34..fea338d705 100644 > > --- a/lib/librte_eal/windows/eal_interrupts.c > > +++ b/lib/librte_eal/windows/eal_interrupts.c > > @@ -105,3 +105,12 @@ eal_intr_thread_schedule(void (*func)(void *arg), void *arg) > > > > return 0; > > } > > + > > +int > > +rte_intr_callback_register( > > + __rte_unused const struct rte_intr_handle *intr_handle, > > + __rte_unused rte_intr_callback_fn cb, > > + __rte_unused void *cb_arg) > > +{ > > + return -ENOTSUP; > > +} > > We have also included the same code as it is required to compile i40e PMD. > > Will remove it from our patch once this code is merged. It would make more sense to have a patch which introduces all intr-related stubs, including epoll ones. There are already 3 patches around, none of them is complete: https://patches.dpdk.org/patch/84389/ https://patches.dpdk.org/patch/84567/ https://patches.dpdk.org/patch/84771/