Re: [dpdk-dev] [PATCH] test/virtual_pmd: add set MAC address dev op

[Ferruh Yigit <ferruh.yigit@intel.com>]

On 1/29/2018 2:23 PM, Radu Nicolau wrote:
> Needed if used with net/bonding
> 
> Signed-off-by: Radu Nicolau <radu.nicolau@intel.com>
> ---
>  test/test/virtual_pmd.c | 7 ++++++-
>  1 file changed, 6 insertions(+), 1 deletion(-)
> 
> diff --git a/test/test/virtual_pmd.c b/test/test/virtual_pmd.c
> index 7a7adbb..2b5383a 100644
> --- a/test/test/virtual_pmd.c
> +++ b/test/test/virtual_pmd.c
> @@ -216,6 +216,11 @@ static void
>  virtual_ethdev_promiscuous_mode_disable(struct rte_eth_dev *dev __rte_unused)
>  {}
>  
> +static void
> +virtual_ethdev_mac_address_set(struct rte_eth_dev *dev, struct ether_addr *addr)
> +{
> +	memcpy(dev->data->mac_addrs, addr, sizeof(struct ether_addr));

Same comment here, memcpy not required.

> +}
>  
>  static const struct eth_dev_ops virtual_ethdev_default_dev_ops = {
>  	.dev_configure = virtual_ethdev_configure_success,
> @@ -228,13 +233,13 @@ static const struct eth_dev_ops virtual_ethdev_default_dev_ops = {
>  	.rx_queue_release = virtual_ethdev_rx_queue_release,
>  	.tx_queue_release = virtual_ethdev_tx_queue_release,
>  	.link_update = virtual_ethdev_link_update_success,
> +	.mac_addr_set = virtual_ethdev_mac_address_set,
>  	.stats_get = virtual_ethdev_stats_get,
>  	.stats_reset = virtual_ethdev_stats_reset,
>  	.promiscuous_enable = virtual_ethdev_promiscuous_mode_enable,
>  	.promiscuous_disable = virtual_ethdev_promiscuous_mode_disable
>  };
>  
> -
>  void
>  virtual_ethdev_start_fn_set_success(uint16_t port_id, uint8_t success)
>  {
>