Re: [dpdk-dev] [PATCH v3 1/6] szedata2: add new poll mode driver

[Thomas Monjalon <thomas.monjalon@6wind.com>]

Hi,

I'm doing some last checks before merging.

The libsze2 depends on libcommlbr so it would be better to list it on
https://www.liberouter.org/technologies/netcope/access-to-libsze2-library

A patch is needed in mk/ to allow linking these dependencies from a
non-standard directory: http://dpdk.org/dev/patchwork/patch/9023

As only 64-bit versions of the libraries are provided, I guess we
could mention it is currently supported only on x86-64.


2015-11-10 15:18, Matej Vido:
> +static void
> +eth_stats_get(struct rte_eth_dev *dev,
> +		struct rte_eth_stats *igb_stats)
> +{

igb_stats is a name inherited from old times. It is related to the first
DPDK driver (igb).
I will rename it to "stats".

[...]
> +       long int value;
> +
> +       value = strtol(mask_str, &endptr, 0);
> +       if (*endptr != '\0' || value > UINT32_MAX || value < 0)

This check would not compile in 32-bit environment (which is not supported).

[...]
> +static int
> +rte_eth_from_szedata2(const char *name,
> +               struct rxtx_szedata2 *szedata2,
> +               const unsigned numa_node)
> +{
> +       struct pmd_internals *internals = NULL;
> +       struct rte_eth_dev *eth_dev = NULL;
> +       struct rte_eth_dev_data *data = NULL;

This data variable is not used before the patch 4/6.
I will move it.