From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f46.google.com (mail-wm0-f46.google.com [74.125.82.46]) by dpdk.org (Postfix) with ESMTP id 4802E5A6C for ; Fri, 20 Nov 2015 16:05:37 +0100 (CET) Received: by wmec201 with SMTP id c201so24744640wme.1 for ; Fri, 20 Nov 2015 07:05:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:organization:user-agent :in-reply-to:references:mime-version:content-transfer-encoding :content-type; bh=OeHiXK09pwv63Xl7JDXDpJXvFx7mlFBj+V2nolJ9yA4=; b=FWs1WDLKBUID+FAf2CXPGa9lbhyYI7gSmiKUOS05ViZCno9vNQ5LZR69myJVBjojOG pwf77hWTXJjZXSQl5PSfdceothn6BiXAmmxhZQs/WY2AvXx9iFSaCYXhRTHmEzBP3GSR bkbfbSnq7IxOeAliynyIwWpXnqY11Kgakz6GfQYGxAsamx7Hl6EW1vr+Ck0WiT0b8ywv 9TwL+CJex9Tyt5wDSW56Sf/iDr0GrD44dVTuBSijmnQXf2YBvblqYWheYb7BvDuBmJgO YsqcWmyHNr6y0X42q+kZ6Wwhiw/urMZK4haoPhs//drCC9/X8lNfaKbkQP0ol1KnS4/h u+IA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=OeHiXK09pwv63Xl7JDXDpJXvFx7mlFBj+V2nolJ9yA4=; b=VSRGM2fk8kq/BH6cPGnnZwdA/o9FmFqYTUWkvf0YBxKhYO4sdPFS7saGVekm7RoIFu FnnCZ6ZB3JU5ipQCiXe5uJqCGRc1UdkJXgqwZjkmXzagOaMoFg35ADdVBtM7o8Ji726D vviWhmdwFXj1gwkJtARl5KQTglvmvGrum5/8UPI5qXuiOD+mYHBrL9LlsVK8ngjbk/bV X4yo/oofv3iMYyJ4PYM3BeXSsUQcBoNHjv35L2vMRIS3uDGhrBScU/5VQoeL6VXvZ0S2 7DN//VgjJgm2R0K6JlJUjS2RntslcsTJEK97SVIW5UVXDvDrBOSC49YGmGZ4qbd69Lsq vX3g== X-Gm-Message-State: ALoCoQkO4ypYIXqdYbTtdsM0clJI/gINA5jHbV0YQeNNhX1YgygAAxBVKDzblGrZJ4QKDsU+5ZHP X-Received: by 10.194.92.4 with SMTP id ci4mr17658273wjb.175.1448031936724; Fri, 20 Nov 2015 07:05:36 -0800 (PST) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by smtp.gmail.com with ESMTPSA id u134sm3163484wmd.0.2015.11.20.07.05.35 (version=TLSv1/SSLv3 cipher=OTHER); Fri, 20 Nov 2015 07:05:35 -0800 (PST) From: Thomas Monjalon To: Matej Vido Date: Fri, 20 Nov 2015 16:04:21 +0100 Message-ID: <2187677.AtrVqmgt0N@xps13> Organization: 6WIND User-Agent: KMail/4.14.10 (Linux/4.1.6-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <1447165098-6412-2-git-send-email-matejvido@gmail.com> References: <1442565172-5338-1-git-send-email-matejvido@gmail.com> <1447165098-6412-1-git-send-email-matejvido@gmail.com> <1447165098-6412-2-git-send-email-matejvido@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org, Viktor Pus Subject: Re: [dpdk-dev] [PATCH v3 1/6] szedata2: add new poll mode driver X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 20 Nov 2015 15:05:37 -0000 Hi, I'm doing some last checks before merging. The libsze2 depends on libcommlbr so it would be better to list it on https://www.liberouter.org/technologies/netcope/access-to-libsze2-library A patch is needed in mk/ to allow linking these dependencies from a non-standard directory: http://dpdk.org/dev/patchwork/patch/9023 As only 64-bit versions of the libraries are provided, I guess we could mention it is currently supported only on x86-64. 2015-11-10 15:18, Matej Vido: > +static void > +eth_stats_get(struct rte_eth_dev *dev, > + struct rte_eth_stats *igb_stats) > +{ igb_stats is a name inherited from old times. It is related to the first DPDK driver (igb). I will rename it to "stats". [...] > + long int value; > + > + value = strtol(mask_str, &endptr, 0); > + if (*endptr != '\0' || value > UINT32_MAX || value < 0) This check would not compile in 32-bit environment (which is not supported). [...] > +static int > +rte_eth_from_szedata2(const char *name, > + struct rxtx_szedata2 *szedata2, > + const unsigned numa_node) > +{ > + struct pmd_internals *internals = NULL; > + struct rte_eth_dev *eth_dev = NULL; > + struct rte_eth_dev_data *data = NULL; This data variable is not used before the patch 4/6. I will move it.