From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 97D6AA00C5; Thu, 7 May 2020 12:23:12 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id C69B31DA9C; Thu, 7 May 2020 12:23:11 +0200 (CEST) Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by dpdk.org (Postfix) with ESMTP id 2B8A11DA75 for ; Thu, 7 May 2020 12:23:11 +0200 (CEST) Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailout.nyi.internal (Postfix) with ESMTP id B96EB5C00A4; Thu, 7 May 2020 06:23:10 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute7.internal (MEProxy); Thu, 07 May 2020 06:23:10 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm1; bh= a4gURDv7IZwHbC9boBH1s8PsIuiFaez+5XZnbjeH66k=; b=tfeJoN5OvKvgTj7e DO3dc+UI6n8JwPV/TJ/UaOxNQAdb7AODrVJqxsObvAHdX2i/q+4kI13zOSIuMaEi LqzCsJj1PkBPIQMxDSxB3IyAwonYz9w1tii27EPWacbJWdkT0Jc4pwoPfK7iKq6g jukr/d6y/hfMEJR1wmLm2rJf7xpWI04O1IdHp+QLF77oTF/n/L9R7+4a1Yy9mofw kPGzApinj7GKgSwPPGQy7ONMNGqfUcyc9QeEc3Yep2ItuLiHm+jfgU603KqQfeJh oh7l2phxvDheMEP3N3TxDK69JcFdffH9U+hvEJtu8DbUgEwKYzdBDeAaTiRyTmu5 m9GeEA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=a4gURDv7IZwHbC9boBH1s8PsIuiFaez+5XZnbjeH6 6k=; b=SCWj+9WtuzAKqLSMHfKk7Z2pKY/GRejVLR9I6YII8k4urQa9MrFxhsHpd +1zQQyFCIdp+1kyrsQQir1g0PnEZ8vqNNQI8FjTS/yhwyr4xBcigmq5VIGAqgskl DDOBSjPoL+WButqhdoF9cQ0OZ+f+PbgEIrBVY7eqL04y33WWo9jg8fqVC34Fee1a exk9CEIAKqonbIGThVNcRS+t/kbrus/FVM9IbSPr1oZYjE28jqAIldWGjlpULWYu 0SrnT28BWjdgqcb8lLeOew4AKnQTnWMvdG1EUcZLVTaHzV9iK4k0CkgdmnEkMO6V 5nAVmIiZFkZ+DVM4bYchv4jgJyKwA== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduhedrkedtgddviecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucggtf frrghtthgvrhhnpedugefgvdefudfftdefgeelgffhueekgfffhfeujedtteeutdejueei iedvffegheenucfkphepjeejrddufeegrddvtdefrddukeegnecuvehluhhsthgvrhfuih iivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhho nhdrnhgvth X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 4509130660F4; Thu, 7 May 2020 06:23:09 -0400 (EDT) From: Thomas Monjalon To: Ophir Munk Cc: dev@dpdk.org, David Marchand , Ray Kinsella , Matan Azrad , Raslan Darawsheh Date: Thu, 07 May 2020 12:23:08 +0200 Message-ID: <2189631.BjyWNHgNrj@thomas> In-Reply-To: <20200507085634.9589-1-ophirmu@mellanox.com> References: <20200507073702.4047-2-ophirmu@mellanox.com> <20200507085634.9589-1-ophirmu@mellanox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v3 1/2] common/mlx5: add rte internal tag and avoid comparison X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 07/05/2020 10:56, Ophir Munk: > Move mlx5 symbols in the map file to the INTERNAL section and add > __internal tags to their definitions. > Those symbols were exported in 20.02 and now (20.05) they are removed. [...] > --- a/drivers/common/mlx5/rte_common_mlx5_version.map > +++ b/drivers/common/mlx5/rte_common_mlx5_version.map > @@ -1,8 +1,10 @@ > -DPDK_21 { > +INTERNAL { I think you forgot the EXPERIMENTAL section. In my opinion, everything should be in INTERNAL and marked with __rte_internal in source code.