From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f47.google.com (mail-wm0-f47.google.com [74.125.82.47]) by dpdk.org (Postfix) with ESMTP id 9C385388F for ; Wed, 7 Dec 2016 14:13:34 +0100 (CET) Received: by mail-wm0-f47.google.com with SMTP id t79so166101111wmt.0 for ; Wed, 07 Dec 2016 05:13:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:user-agent:in-reply-to :references:mime-version:content-transfer-encoding; bh=tNxcFPjCRaESmyQi1RH9qEr3vLiLO0H9HvUlJalGwHU=; b=xQboPQmyzPZLOYb/ZoWq7FkjzMLegS7xIOFQctFZoGFJPwHzjY1YwHI7TQdbxSZGxs ObPVMZHQCyXObRqhEuvtk6Zp/BkECshSIERTbgjdDV1G3aUTxE7+iJ3mbCCmcGGgtBkA b5ruXDrFh4s4HWzEU0+lf3/zMlgrxoeujF4KZ9XCYB+cyb0AmayGZcKMPsSgRB9r1HTd XmiNgIVF4+50+Q1/ys2miPITuQYLOD7LYmmjvFYDM9ra7fmCfWxyEvijtk55pQzt4WBZ kEiQxUW8o80E0oHsTklSn5lEal5rh3oQCHz/3sj0nWFaHgWBGuQVIA2EQHvYqHrjZUTe OWIA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=tNxcFPjCRaESmyQi1RH9qEr3vLiLO0H9HvUlJalGwHU=; b=JY9QH0hVbx4EDWnbE+NBhqsj6uCtfeNOyMNpOJ9hA40CNBWtEwLq4lka+YR1wmatzZ UVIgaaEXf8SBrTxEkMZG7g+qXTEX2EJefAxTSvWB4mK7W2WkQBhzOGAphxHey8rvYkyK X9uZzeJioPlUryZQRsoj0daSkLaOEiImnlw63Rmp8n+NU6RNFHpNLi2kCVGAvDY/bo8e wb/W46WQgMZw3Ys9MRQ50Vq9nr9pCTfrE7sOD5YmTzz0ZIUeurJf5+ybbFKB8yexJaTZ 8VDo+UTcgI+el4hdOoqZdiGZDnReNuRgvFhvWaH7OD5hEgwrmu7obYF0TO0IKGDlT2lf UJ6A== X-Gm-Message-State: AKaTC03uBIL0krpTdTDMb0ek70KYhm4VLEv8AlXajtT3gNWJkm7d7L2OlbFV0ZQBjOx7Nvtz X-Received: by 10.28.95.85 with SMTP id t82mr2484982wmb.56.1481116414264; Wed, 07 Dec 2016 05:13:34 -0800 (PST) Received: from xps13.localnet (184.203.134.77.rev.sfr.net. [77.134.203.184]) by smtp.gmail.com with ESMTPSA id k11sm9566764wmf.24.2016.12.07.05.13.33 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 07 Dec 2016 05:13:33 -0800 (PST) From: Thomas Monjalon To: Akhil Goyal Cc: dev@dpdk.org, declan.doherty@intel.com, pablo.de.lara.guarch@intel.com, Hemant Agrawal , Horia =?utf-8?B?R2VhbnTEgw==?= Date: Wed, 07 Dec 2016 14:13:31 +0100 Message-ID: <2191747.cEMNQWRsu6@xps13> User-Agent: KMail/4.14.10 (Linux/4.5.4-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: References: <20161205125540.6419-1-akhil.goyal@nxp.com> <13107823.ZnI407z9cY@xps13> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH 1/8] drivers/common/dpaa2: Run time assembler for Descriptor formation X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 07 Dec 2016 13:13:34 -0000 2016-12-07 11:44, Akhil Goyal: > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > 2016-12-07 06:24, Akhil Goyal: > > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > > 2016-12-05 18:25, Akhil Goyal: > > > FLib is a library which helps in making the descriptors which is > > > understood by NXP's SEC hardware. > > > This patch provides header files for command words which can be used > > > for descritptor formation. > > > > It seems this code is old. Does it exist as a standalone library somewhere? > [Akhil] Let me correct here. This is not a library. This is a set of header files. Use the name you want but please be consistent. You said above: "FLib is a library" and now "This is not a library" Funny :) > Yes this is an old code. This is generally shipped with NXP SDK. > > > Where was it hosted before duplicating it in DPDK? > [Akhil] This is part of NXP SDK and also available at git.freescale.com. So it is not a DPDK code. It should be a standalone library (or set of headers) and packaged as well. > > Why do you want to have a common directory drivers/common/dpaa2/flib instead of a sub-directory in the crypto driver? > [Akhil] I agree with your suggestion. This can be maintained within drivers/crypto as a common header files set for different NXP Architecture crypto drivers. Yes it can be in drivers/crypto/ or not in DPDK at all.