From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wi0-f171.google.com (mail-wi0-f171.google.com [209.85.212.171]) by dpdk.org (Postfix) with ESMTP id 25FE95A76 for ; Mon, 26 Oct 2015 15:47:40 +0100 (CET) Received: by wicll6 with SMTP id ll6so117827035wic.0 for ; Mon, 26 Oct 2015 07:47:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind_com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:organization:user-agent :in-reply-to:references:mime-version:content-transfer-encoding :content-type; bh=oZE7ZNbw9xt1TgiEBOdH0dAcFqHvSkNnSn4vV7aqU/o=; b=LkwU/D05K7oyKWxz3/sQlSlzkEmOyAIYghs0H/G33gd6f/FzFTHjekD1xhGxZB9M7J zadtV6i+gKvT6+5tiLSVaVyOuyLl4IsEqgL1sz16mttlKXALTY3ifH1ZxNv+H0Vt1mrD Pdctv692+YEtQNm+yfM1apLxx2LIgfGyAKZKH8XNR7RjTS3FQT/pOP3sJ9oqH/AGJeJ9 3Vy3EvxAey4eYvG0DwaVjN3I+f03uKVCSMl0EwEHfpWzchUOUNZ+oZVMrMYRqTALb7YW 8ETrK1dk9Hxa8Woz1DAznF+StYywtAvHqvHhdoPV5Sie1SAd6GncSb6Xu91FEnkO70pl TnYQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=oZE7ZNbw9xt1TgiEBOdH0dAcFqHvSkNnSn4vV7aqU/o=; b=J380EtlLGeq7I8Ktt2Qh3L8XaK+H8NXR+jtcWBV1P5KnD6mjf41ZAAB2ZoBr6PviE4 xL1ptJ/oVQCmNUWZk7DyHYDECiRZIenTMczxxfHeeTYUa9QNly97WT5GsxikVEl5f+5c PNVJf7wKzIE3iiBlGDgF0HXddBLhJeMVUcytMuXZAplVU8yjV3Sb/i5V7Nh05ypXh8qS dG3unLklR/xY/+PbTmnmc5i7nZMxW8dbWVevWN4xwgX2t7Iq0SDZeHI+ILK+QWV5rzgp qYZ36gq2QRrY8LKamccnE0LaJSApp1HbEHEUyRm+lQjMW3yv8GKzDos/by/pVeeuK8J8 rHhQ== X-Gm-Message-State: ALoCoQl/ulqkY7VIwK/o/i+Coooo1LWnb1AjlHHOrs+JLQMSAcQ8PkNB+rxhEHNmmWbM6zSTJFi5 X-Received: by 10.194.186.238 with SMTP id fn14mr23060463wjc.128.1445870859602; Mon, 26 Oct 2015 07:47:39 -0700 (PDT) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by smtp.gmail.com with ESMTPSA id at4sm9087756wjc.9.2015.10.26.07.47.38 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 26 Oct 2015 07:47:38 -0700 (PDT) From: Thomas Monjalon To: "Alejandro.Lucero" Date: Mon, 26 Oct 2015 15:46:30 +0100 Message-ID: <2192125.8cJDpqYsAL@xps13> Organization: 6WIND User-Agent: KMail/4.14.10 (Linux/4.1.6-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <1445596563-16818-2-git-send-email-alejandro.lucero@netronome.com> References: <1445596563-16818-1-git-send-email-alejandro.lucero@netronome.com> <1445596563-16818-2-git-send-email-alejandro.lucero@netronome.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v4] nfp: new poll mode driver for netronome nfp-6xxx card X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 26 Oct 2015 14:47:40 -0000 2015-10-23 11:36, Alejandro.Lucero: > From: "Alejandro.Lucero" > > This patch adds a new PMD for using PCI Virtual Functions with Netronome > nfp6000 card. > > Signed-off-by: Alejandro.Lucero > Signed-off-by: Rolf.Neugebauer > --- > drivers/net/nfp/Makefile | 88 ++ > drivers/net/nfp/nfp_net.c | 2495 ++++++++++++++++++++++++++++++++++++++++ > drivers/net/nfp/nfp_net_ctrl.h | 290 +++++ > drivers/net/nfp/nfp_net_logs.h | 75 ++ > drivers/net/nfp/nfp_net_pmd.h | 434 +++++++ It seems this driver is not integrated in the build system. Please avoid such huge patch and submit piece by piece. Example: - patch 1 for the basic init - patch 2 for Rx/Tx - patch 3 for RSS - patch 4 for statistics It will be easier to review. It would be also appreciated to have a doc in doc/guides/nics and an entry in the release notes. Thanks