From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas@monjalon.net>
Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com
 [66.111.4.28]) by dpdk.org (Postfix) with ESMTP id 227A21BAC0
 for <dev@dpdk.org>; Thu, 26 Oct 2017 13:40:00 +0200 (CEST)
Received: from compute1.internal (compute1.nyi.internal [10.202.2.41])
 by mailout.nyi.internal (Postfix) with ESMTP id 8DD1F20A5D;
 Thu, 26 Oct 2017 07:39:59 -0400 (EDT)
Received: from frontend1 ([10.202.2.160])
 by compute1.internal (MEProxy); Thu, 26 Oct 2017 07:39:59 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=
 cc:content-transfer-encoding:content-type:date:from:in-reply-to
 :message-id:mime-version:references:subject:to:x-me-sender
 :x-me-sender:x-sasl-enc; s=mesmtp; bh=8fOXuoy2UIA+Z4iTusS15vNgFO
 qYJV6DTQRGzuGYSI4=; b=BEkzrJUnyaU2Dz54hqEcxQ8O9huIl6RGeXWPAWW5hK
 IQkbVPgfxy6gfJmx1CZjdsdUM7cXhygr6x9HPsbNzAAwJTbyxWert2axsnNrXshx
 nFVi5fkKw60Rzmo84FroCwrF44zwU7Vh7eiRUDhAun6hyXNn9a5WQg2GbRx8IPWQ
 8=
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
 messagingengine.com; h=cc:content-transfer-encoding:content-type
 :date:from:in-reply-to:message-id:mime-version:references
 :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=8fOXuo
 y2UIA+Z4iTusS15vNgFOqYJV6DTQRGzuGYSI4=; b=hqX2JtXr3x6YYGQjWpmc0i
 R1XtXpMV5+qpP27mDbp4TmHq/9Gq3lXMlO9gCA+/ssH8Rqz5E+9AvnrbvxiX0R56
 sJcheOWxGtBYPgLIPrzs7Cs9elNJioWvA4HHqYxH61cRS20WAVz+3UEl2Sm4KM0+
 ztT057IcY6avKabCCdyvtwNcYPPQPBGlineBI66wTPgAxqt6jRigAzHk5RvMvyEw
 I3pYx1DBUdmNp9r47xMC0o/WqWRKORpScOw6E1rbNSBxgbGdwSZmo0s27jah55a2
 hmyrK4PjbXiWw2jhA57Fj5Xs7410YM2ca63zkc715KtyXHIZLi7XxueAhlVusL/w
 ==
X-ME-Sender: <xms:j8nxWReAk0iyNRtWGfHV5oK0XBg25QO5vRe_zSYQr6612Cba82OrUw>
Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184])
 by mail.messagingengine.com (Postfix) with ESMTPA id 2D41A7E13B;
 Thu, 26 Oct 2017 07:39:59 -0400 (EDT)
From: Thomas Monjalon <thomas@monjalon.net>
To: David Marchand <david.marchand@6wind.com>,
 Radu Nicolau <radu.nicolau@intel.com>
Cc: dev@dpdk.org, Declan Doherty <declan.doherty@intel.com>,
 Pablo de Lara <pablo.de.lara.guarch@intel.com>,
 Hemant Agrawal <hemant.agrawal@nxp.com>, borisp@mellanox.com,
 aviadye@mellanox.com, sandeep.malik@nxp.com,
 Jerin Jacob <jerin.jacob@caviumnetworks.com>, "Mcnamara,
 John" <john.mcnamara@intel.com>, "Ananyev,
 Konstantin" <konstantin.ananyev@intel.com>, shahafs@mellanox.com,
 Olivier Matz <olivier.matz@6wind.com>, Akhil Goyal <akhil.goyal@nxp.com>
Date: Thu, 26 Oct 2017 13:39:58 +0200
Message-ID: <2193963.B775pDLU5T@xps>
In-Reply-To: <CALwxeUsLoVMxZLXy2YZXXgmzu22y6A3J5EnQy1YvGWyrrd1WEA@mail.gmail.com>
References: <1509013365-13819-1-git-send-email-radu.nicolau@intel.com>
 <36c6304e-cd1b-9bd9-2c5d-c6e20eff85e8@intel.com>
 <CALwxeUsLoVMxZLXy2YZXXgmzu22y6A3J5EnQy1YvGWyrrd1WEA@mail.gmail.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Subject: Re: [dpdk-dev] [PATCH 2/3] net/ixgbe: fix build issue
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 26 Oct 2017 11:40:00 -0000

26/10/2017 13:27, David Marchand:
> On Thu, Oct 26, 2017 at 1:01 PM, Radu Nicolau <radu.nicolau@intel.com> wrote:
> > On 10/26/2017 11:36 AM, David Marchand wrote:
> >> On Thu, Oct 26, 2017 at 12:22 PM, Radu Nicolau <radu.nicolau@intel.com>
> >> wrote:
> >>> --- a/drivers/net/ixgbe/Makefile
> >>> +++ b/drivers/net/ixgbe/Makefile
> >>> +ifneq ($(MAKECMDGOALS),clean)
> >>> +ifneq ($(CONFIG_RTE_LIBRTE_SECURITY),y)
> >>> +$(error "RTE_LIBRTE_SECURITY is required to build RTE_LIBRTE_IXGBE_PMD")
> >>> +endif
> >>> +endif
> >>
> >> This is a no go for me unless you explain how it is impossible to
> >> disable it in the code.
> >>
> >>
> > It can be disabled in the code, but as far as I know there is a general push
> > back against having conditionally compiled code. I originally had the
> > security sections in ixgbe PMD isolated, but the feedback was to have them
> > always on.
> 
> In my mind, this was to stop having features enabled per pmd (and stop
> the nightmare with 10 options in a pmd).
> Having features globally enabled for all or nothing is still
> acceptable, is it not ?

Yes there is a config option for rte_security,
and it is acceptable.
The code depending on it must be ifdef'ed.