From: Thomas Monjalon <thomas@monjalon.net>
To: Michael Santana <msantana@redhat.com>, Aaron Conole <aconole@redhat.com>
Cc: dev@dpdk.org, Bruce Richardson <bruce.richardson@intel.com>,
Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com>
Subject: Re: [dpdk-dev] [PATCH v5 1/2] examples/vhost_scsi: Don't build without virtio_scsi.h
Date: Wed, 27 Feb 2019 15:09:09 +0100 [thread overview]
Message-ID: <2196426.oXKmsQ8SoK@xps> (raw)
In-Reply-To: <20190207220114.8020-2-msantana@redhat.com>
07/02/2019 23:01, Michael Santana:
> From: Aaron Conole <aconole@redhat.com>
>
> The vhost_scsi example code is set to build, even if the requisite header
> file virtio_scsi.h isn't available. This happens on some Ubuntu systems
> when some versions of the libc-dev package aren't available.
>
> Check whether the virtio_scsi.h file exists, and if not, set the build
> flag to false.
>
> Signed-off-by: Aaron Conole <aconole@redhat.com>
> Acked-by: Bruce Richardson <bruce.richardson@intel.com>
> ---
> v5:
> Nothing changed in this patch since v3.
Patch 1 applied alone to allow Travis refinement separately, thanks.
next prev parent reply other threads:[~2019-02-27 14:09 UTC|newest]
Thread overview: 60+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-23 22:07 [dpdk-dev] [PATCH] Introduce travis builds for github repositories Michael Santana
2019-01-24 9:35 ` Bruce Richardson
2019-01-24 9:41 ` Bruce Richardson
2019-01-24 18:11 ` Aaron Conole
2019-01-24 18:31 ` Bruce Richardson
2019-01-24 18:18 ` Thomas Monjalon
2019-01-24 20:02 ` Aaron Conole
2019-01-24 19:26 ` Honnappa Nagarahalli
2019-01-24 19:51 ` Michael Santana Francisco
2019-01-30 22:16 ` [dpdk-dev] [PATCH v2 0/2] Introduce travis support Michael Santana
2019-01-30 22:16 ` [dpdk-dev] [PATCH v2 1/2] examples/vhost_scsi: Don't build without virtio_scsi.h Michael Santana
2019-01-31 9:15 ` Bruce Richardson
2019-01-30 22:16 ` [dpdk-dev] [PATCH v2 2/2] ci: Introduce travis builds for github repositories Michael Santana
2019-01-31 9:25 ` Bruce Richardson
2019-01-31 16:43 ` Aaron Conole
2019-01-31 20:32 ` Bruce Richardson
2019-01-31 20:43 ` Aaron Conole
2019-02-01 16:48 ` [dpdk-dev] [PATCH v3 0/2] Introduce travis support Michael Santana
2019-02-01 16:48 ` [dpdk-dev] [PATCH v3 1/2] examples/vhost_scsi: Don't build without virtio_scsi.h Michael Santana
2019-02-01 16:48 ` [dpdk-dev] [PATCH v3 2/2] ci: Introduce travis builds for github repositories Michael Santana
2019-02-04 9:41 ` Bruce Richardson
2019-02-06 19:17 ` Honnappa Nagarahalli
2019-02-06 20:18 ` Aaron Conole
2019-02-06 22:13 ` [dpdk-dev] [PATCH v4 0/2] Introduce travis support Michael Santana
2019-02-06 22:13 ` [dpdk-dev] [PATCH v4 1/2] examples/vhost_scsi: Don't build without virtio_scsi.h Michael Santana
2019-02-06 22:13 ` [dpdk-dev] [PATCH v4 2/2] ci: Introduce travis builds for github repositories Michael Santana
2019-02-07 17:16 ` Honnappa Nagarahalli
2019-02-07 22:01 ` [dpdk-dev] [PATCH v5 0/2] Introduce travis support Michael Santana
2019-02-07 22:01 ` [dpdk-dev] [PATCH v5 1/2] examples/vhost_scsi: Don't build without virtio_scsi.h Michael Santana
2019-02-27 14:09 ` Thomas Monjalon [this message]
2019-02-07 22:01 ` [dpdk-dev] [PATCH v5 2/2] ci: Introduce travis builds for github repositories Michael Santana
2019-02-27 13:56 ` Thomas Monjalon
2019-02-27 14:35 ` Aaron Conole
2019-02-27 15:23 ` Thomas Monjalon
2019-02-27 15:53 ` Aaron Conole
2019-02-27 16:06 ` Luca Boccassi
2019-02-27 16:17 ` Aaron Conole
2019-02-14 14:30 ` [dpdk-dev] [PATCH v5 0/2] Introduce travis support Michael Santana Francisco
2019-02-25 18:40 ` Aaron Conole
2019-03-04 16:12 ` [dpdk-dev] [PATCH v6 0/1] " Michael Santana
2019-03-04 16:12 ` [dpdk-dev] [PATCH v6 1/1] ci: Introduce travis builds for github repositories Michael Santana
2019-03-04 18:14 ` Luca Boccassi
2019-03-14 13:21 ` Michael Santana Francisco
2019-03-14 13:21 ` Michael Santana Francisco
2019-03-20 16:01 ` Thomas Monjalon
2019-03-20 16:01 ` Thomas Monjalon
2019-03-20 19:28 ` Michael Santana Francisco
2019-03-20 19:28 ` Michael Santana Francisco
2019-03-20 21:11 ` Luca Boccassi
2019-03-20 21:11 ` Luca Boccassi
2019-03-21 15:45 ` Michael Santana Francisco
2019-03-21 15:45 ` Michael Santana Francisco
2019-03-22 16:56 ` [dpdk-dev] [PATCH v7] " Michael Santana
2019-03-22 16:56 ` Michael Santana
2019-03-25 15:32 ` [dpdk-dev] [PATCH v8] " Michael Santana
2019-03-25 15:32 ` Michael Santana
2019-03-25 16:10 ` Thomas Monjalon
2019-03-25 16:10 ` Thomas Monjalon
2019-03-26 21:54 ` Thomas Monjalon
2019-03-26 21:54 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2196426.oXKmsQ8SoK@xps \
--to=thomas@monjalon.net \
--cc=Honnappa.Nagarahalli@arm.com \
--cc=aconole@redhat.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=msantana@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).