From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas.monjalon@6wind.com>
Received: from mail-wm0-f54.google.com (mail-wm0-f54.google.com [74.125.82.54])
 by dpdk.org (Postfix) with ESMTP id E4F1E9418
 for <dev@dpdk.org>; Mon,  7 Dec 2015 03:37:24 +0100 (CET)
Received: by wmuu63 with SMTP id u63so123356575wmu.0
 for <dev@dpdk.org>; Sun, 06 Dec 2015 18:37:24 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=6wind-com.20150623.gappssmtp.com; s=20150623;
 h=from:to:cc:subject:date:message-id:organization:user-agent
 :in-reply-to:references:mime-version:content-transfer-encoding
 :content-type; bh=ntI4lDpYhW84oh9rsn4Zo15q7SEqs2p7TNKaYbCG/gM=;
 b=XLszio0InF1z61+Lxb7Mc0KeP2gNevOgdSXl+IL0Hefw7Hh9pVswYYTjC7Ya1sVJwi
 nNnr2oa8y3FuyYxD8xjM2Cdrl7jPoLS7xul58q9YiWv2Gp/zvm79109ECnwuf+nPuaJc
 YrBhSilicyEAlnNr7eflJLNP9oJITNZBtvA0iUYGvdmor0QsaYGxV8d0+Zt1DCSTazzN
 8UWcCqnB+cXnro6eLB/Bp2OWTx5xbG22Pru1iuLKb4Ic1KqRU+jt7w8oGWtCWqAFojRz
 o2BUaeJ5EkzIHGEfspYkDCFSA6bf6Q6PZZ7rDy38F73PngOYfhasJv9prc0OVjKw/jAk
 d2KQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:from:to:cc:subject:date:message-id:organization
 :user-agent:in-reply-to:references:mime-version
 :content-transfer-encoding:content-type;
 bh=ntI4lDpYhW84oh9rsn4Zo15q7SEqs2p7TNKaYbCG/gM=;
 b=RwLvrZp9zERBoJTeoRWAk9546CpCxxdtaAGa/iJix55DEWwgfpuY/haeNgaHRxHJ+q
 lz58RoBrd3ZZXGHBz888Ezk14YE9kboKr0MRt/XzW3mK6eAjtfD6gfS3izaKYceQ+GIx
 DQdjDtOrG8lCXWzaRCojocD6iEoIckKgBNvOlH2E4UXYKN+SQvJpFiwi43VF4eaIf3IZ
 RMi9y5h9KLe5elyZRo0UUHSFbEQJuiZtMwPEGFl9WFg4mZxYgSYoJbPwLfW9APdLMcwJ
 +itrG2TzGNwMkygMbVqsXhUGN5hmHWBU7ZOLep1YTy1fSWeUEHkNrrnwQ5vA5edvHVLa
 5vuw==
X-Gm-Message-State: ALoCoQmX0WonlPF5a7xpNNmVfXafUQeGN9JCayre84dwjfacxE4ZrOLbQPg/MAUKUFOAd6cjCidE
X-Received: by 10.28.172.129 with SMTP id v123mr17933725wme.47.1449455844794; 
 Sun, 06 Dec 2015 18:37:24 -0800 (PST)
Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136])
 by smtp.gmail.com with ESMTPSA id u205sm14245303wmb.12.2015.12.06.18.37.23
 (version=TLSv1/SSLv3 cipher=OTHER);
 Sun, 06 Dec 2015 18:37:24 -0800 (PST)
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Ian Betts <ian.betts@intel.com>
Date: Mon, 07 Dec 2015 03:36:12 +0100
Message-ID: <21971802.WvAiNsWy31@xps13>
Organization: 6WIND
User-Agent: KMail/4.14.10 (Linux/4.1.6-1-ARCH; KDE/4.14.11; x86_64; ; )
In-Reply-To: <1449225265-14480-4-git-send-email-ian.betts@intel.com>
References: <1449159683-7092-3-git-send-email-ian.betts@intel.com>
 <1449225265-14480-1-git-send-email-ian.betts@intel.com>
 <1449225265-14480-4-git-send-email-ian.betts@intel.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v8 3/4] examples: add l3fwd-thread example in
	performance-thread
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Mon, 07 Dec 2015 02:37:25 -0000

Hi,

I had no time to check how it works.
I'm just surprised that you introduce a new config option.

2015-12-04 10:34, Ian Betts:
> --- a/config/defconfig_x86_64-native-linuxapp-gcc
> +++ b/config/defconfig_x86_64-native-linuxapp-gcc
> @@ -40,3 +40,5 @@ CONFIG_RTE_ARCH_64=y
>  
>  CONFIG_RTE_TOOLCHAIN="gcc"
>  CONFIG_RTE_TOOLCHAIN_GCC=y
> +
> +CONFIG_RTE_PERFORMANCE_THREAD=y
> diff --git a/config/defconfig_x86_64-native-linuxapp-icc b/config/defconfig_x86_64-native-linuxapp-icc
> index 71d1e28..4c8e6ac 100644
> --- a/config/defconfig_x86_64-native-linuxapp-icc
> +++ b/config/defconfig_x86_64-native-linuxapp-icc
> @@ -40,3 +40,5 @@ CONFIG_RTE_ARCH_64=y
>  
>  CONFIG_RTE_TOOLCHAIN="icc"
>  CONFIG_RTE_TOOLCHAIN_ICC=y
> +
> +CONFIG_RTE_PERFORMANCE_THREAD=y
> diff --git a/examples/Makefile b/examples/Makefile
> index 5dd2c53..c7e786d 100644
> --- a/examples/Makefile
> +++ b/examples/Makefile
> @@ -77,5 +77,6 @@ DIRS-y += vmdq
>  DIRS-y += vmdq_dcb
>  DIRS-$(CONFIG_RTE_LIBRTE_POWER) += vm_power_manager
>  DIRS-$(CONFIG_RTE_LIBRTE_CRYPTODEV) += l2fwd-crypto
> +DIRS-$(CONFIG_RTE_PERFORMANCE_THREAD) += performance-thread

I think this option should be removed.