From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id C578BA0536; Tue, 4 Feb 2020 23:08:52 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 178851C1F2; Tue, 4 Feb 2020 23:08:52 +0100 (CET) Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by dpdk.org (Postfix) with ESMTP id 16C361C1F1 for ; Tue, 4 Feb 2020 23:08:51 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 95E53220E7; Tue, 4 Feb 2020 17:08:50 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Tue, 04 Feb 2020 17:08:50 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=OwC7Cmbdza8O7AmGhg7HsafA4ItAz0zdZkvvenYJd9o=; b=UNMdgeB/PMAt CadeXELAG6wXqFyvoluXfnKGrFw9UuT7WsYRVfWroSI9RwX0daiIqn2+igWwrO/L Js67tzKJm8DnEMiBBLCJDXGuCihLdwkuLm4Ht1ulr6BbC9/DyotNmcv0QBKeLxyL gdOaYpySw18tpQ+eY2fdSJjoCWYiXD4= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=OwC7Cmbdza8O7AmGhg7HsafA4ItAz0zdZkvvenYJd 9o=; b=HXV8qRzrVRyEr45/jMSUE6rbA7hcnxeSopJZAh7AV38s+1v/7yyb2MkKU hvfaJBGCOJIYdnDOsdmT3Z9Ax5xwS2MKI7SzZWMM9BzRDU8Zh/weUIa0Zc0+Qcv5 zMlPRUk75Xa2FGyYG2sIaxAmMWsA1GF1MXE9KSSzedfz3PrhY6nG3Z50rqhFH0XQ Qhdncz8FORF9DIoChR7qaj0NCVzcH9yxOx27yj834hODs3j6qm8HYl1uwMRszdfp rKpc/M7cMlO9DnXTLt2PwIsFEBeEnpTyYzfCuwYVS42Ru7rP4m0eQ0GQlXX/F3Fb bZUyCrYfVOaohoHxJchNThvLVgmAQ== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedugedrgeelgdduheefucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecukf hppeejjedrudefgedrvddtfedrudekgeenucevlhhushhtvghrufhiiigvpedtnecurfgr rhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 69C483280059; Tue, 4 Feb 2020 17:08:49 -0500 (EST) From: Thomas Monjalon To: Dmitry Kozlyuk Cc: dev@dpdk.org, Bruce Richardson , harini.ramakrishnan@microsoft.com Date: Tue, 04 Feb 2020 23:08:48 +0100 Message-ID: <2199644.NG923GbCHz@xps> In-Reply-To: <20200131030744.19596-5-dmitry.kozliuk@gmail.com> References: <20200131030744.19596-1-dmitry.kozliuk@gmail.com> <20200131030744.19596-5-dmitry.kozliuk@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH 4/6] build: MinGW-w64 support for Meson X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 31/01/2020 04:07, Dmitry Kozlyuk: > MinGW-w64 linker does not mimic MS linker options, so the build system > must differentiate between linkers on Windows. Use GNU linker options > with GCC and MS linker options with Clang. > > MinGW-w64 by default uses MSVCRT stdio, which does not comply to ANSI, > most notably its formatting and string handling functions. MinGW-w64 > support for the Universal CRT (UCRT) is ongoing, but the toolchain > provides its own standard-complying implementation of stdio. The latter > is used in the patch to support formatting in DPDK. > > Signed-off-by: Dmitry Kozlyuk I really like this patch. So both GCC (with MinGW) and native clang are supported? [...] > +# MS linker requires special treatment. > +# FIXME: use cc.get_linker_id() after upgrading to Meson >=0.53. What does it mean? It won't work with meson 0.53? > +is_ms_linker = is_windows and (cc.get_id() == 'clang') [...] > +if is_windows > + # Require platform SDK for Windows 7 and above. > + add_project_arguments('-D_WIN32_WINNT=0x0601', language: 'c') Please explain. Why Windows 7 is needed? What this define is doing? [...] > - if is_windows > + > + if is_ms_linker > lk_args = ['-Wl,/def:' + def_file.full_path(), > '-Wl,/implib:lib\\' + implib] > else > lk_args = ['-Wl,--version-script=' + version_map] > + endif Looks good.