Re: [PATCH v7 2/8] drivers: remove incorrect exported symbols

[Hemant Agrawal <hemant.agrawal@oss.nxp.com>]

On 03-04-2025 22:28, David Marchand wrote:
> Declaring inline helpers in version.map is unnecessary.
> There is no exported symbol and this will probably be treated as an
> error by MSVC linker.
>
> rte_dpaa2_dev_type is an enum token.
> roc_se_ctx_swap has no implementation (leftover from a previous rework)
> and can be removed.

The commit message comments are not matching with the changes in the patch?


> Signed-off-by: David Marchand <david.marchand@redhat.com>
> ---
>   drivers/bus/dpaa/version.map    | 1 -
>   drivers/bus/fslmc/version.map   | 2 --
>   drivers/common/cnxk/roc_se.h    | 1 -
>   drivers/common/cnxk/version.map | 2 --
>   4 files changed, 6 deletions(-)
>
> diff --git a/drivers/bus/dpaa/version.map b/drivers/bus/dpaa/version.map
> index a17d57632e..8f09b72757 100644
> --- a/drivers/bus/dpaa/version.map
> +++ b/drivers/bus/dpaa/version.map
> @@ -18,7 +18,6 @@ INTERNAL {
>   	dpaa_update_link_speed;
>   	dpaa_intr_disable;
>   	dpaa_intr_enable;
> -	dpaa_seqn;
>   	dpaa_svr_family;
>   	dpaa_update_link_status;
>   	fman_dealloc_bufs_mask_hi;
> diff --git a/drivers/bus/fslmc/version.map b/drivers/bus/fslmc/version.map
> index 2c36895285..ba3c7f36e3 100644
> --- a/drivers/bus/fslmc/version.map
> +++ b/drivers/bus/fslmc/version.map
> @@ -22,7 +22,6 @@ INTERNAL {
>   	dpaa2_get_mcp_ptr;
>   	dpaa2_io_portal;
>   	dpaa2_seqn_dynfield_offset;
> -	dpaa2_seqn;
>   	dpaa2_svr_family;
>   	dpbp_disable;
>   	dpbp_enable;
> @@ -108,7 +107,6 @@ INTERNAL {
>   	qbman_swp_push_set;
>   	qbman_swp_release;
>   	rte_dpaa2_alloc_dpci_dev;
> -	rte_dpaa2_dev_type;
>   	rte_dpaa2_free_dpci_dev;
>   	rte_dpaa2_intr_disable;
>   	rte_dpaa2_intr_enable;
> diff --git a/drivers/common/cnxk/roc_se.h b/drivers/common/cnxk/roc_se.h
> index ede8d69c0e..f2c4056169 100644
> --- a/drivers/common/cnxk/roc_se.h
> +++ b/drivers/common/cnxk/roc_se.h
> @@ -405,7 +405,6 @@ int __roc_api roc_se_auth_key_set(struct roc_se_ctx *se_ctx, roc_se_auth_type ty
>   int __roc_api roc_se_ciph_key_set(struct roc_se_ctx *se_ctx, roc_se_cipher_type type,
>   				  const uint8_t *key, uint16_t key_len);
>   
> -void __roc_api roc_se_ctx_swap(struct roc_se_ctx *se_ctx);
>   void __roc_api roc_se_ctx_init(struct roc_se_ctx *se_ctx);
>   
>   void __roc_api roc_se_hmac_opad_ipad_gen(roc_se_auth_type auth_type, const uint8_t *key,
> diff --git a/drivers/common/cnxk/version.map b/drivers/common/cnxk/version.map
> index cdbfc1d39a..7f40dcced2 100644
> --- a/drivers/common/cnxk/version.map
> +++ b/drivers/common/cnxk/version.map
> @@ -164,7 +164,6 @@ INTERNAL {
>   	roc_mcs_custom_tag_cfg_get;
>   	roc_mcs_dev_init;
>   	roc_mcs_dev_fini;
> -	roc_mcs_dev_get;
>   	roc_mcs_event_cb_register;
>   	roc_mcs_event_cb_unregister;
>   	roc_mcs_flowid_entry_enable;
> @@ -546,7 +545,6 @@ INTERNAL {
>   	roc_tim_lf_enable;
>   	roc_tim_lf_free;
>   	roc_tim_lf_interval;
> -	roc_se_ctx_swap;
>   	roc_ree_af_reg_read;
>   	roc_ree_af_reg_write;
>   	roc_ree_config_lf;