From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 37A37A04DB; Fri, 16 Oct 2020 12:05:46 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 0CF161EC65; Fri, 16 Oct 2020 12:05:45 +0200 (CEST) Received: from huawei.com (szxga04-in.huawei.com [45.249.212.190]) by dpdk.org (Postfix) with ESMTP id 4F2A01EC5E for ; Fri, 16 Oct 2020 12:05:42 +0200 (CEST) Received: from DGGEMS407-HUB.china.huawei.com (unknown [172.30.72.60]) by Forcepoint Email with ESMTP id E65548C36949921DF5E7; Fri, 16 Oct 2020 18:05:39 +0800 (CST) Received: from [10.67.103.119] (10.67.103.119) by DGGEMS407-HUB.china.huawei.com (10.3.19.207) with Microsoft SMTP Server id 14.3.487.0; Fri, 16 Oct 2020 18:05:32 +0800 To: Ophir Munk , Ferruh Yigit , "wenzhuo.lu@intel.com" , "beilei.xing@intel.com" , NBU-Contact-Adrien Mazarguil CC: "dev@dpdk.org" , "linuxarm@huawei.com" , Ori Kam References: <1600955105-53176-2-git-send-email-oulijun@huawei.com> <1602765662-43299-1-git-send-email-oulijun@huawei.com> <1b2b0e11-1458-e2d9-5fde-91db35b8bc73@intel.com> <51676746-ec95-aff2-dc00-b76480ab6cba@huawei.com> <8c543941-e881-aa88-b52a-a70bfe8f6fcf@intel.com> From: oulijun Message-ID: <21dfaee9-0a63-c154-779a-c932715ae6dd@huawei.com> Date: Fri, 16 Oct 2020 18:05:32 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.1.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.67.103.119] X-CFilter-Loop: Reflected Subject: Re: [dpdk-dev] [PATCH v5] app/testpmd: fix the default RSS key configuration X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 在 2020/10/16 14:46, Ophir Munk 写道: > > >> -----Original Message----- >> From: Ferruh Yigit > <..> >>>> >>> >>> Ferruh, your suggestion ([1] + update) looks correct. I also verified it on >> mlx5 PMD. >>> Advantage: it's a generic fix for all dpdk applications using rte_flows (not >> just testpmd). >>> It reduces code. >>> With this fix the responsibility of handling key==NULL and/or len==0 is >> moved to the PMDs (which is good). >>> >>> With regard to Lijun patch - I liked the approach of overriding the default >> testpmd key with the default PMD key. >>> But it only addresses testpmd. More code was added. >>> It seems OK to call rte_eth_dev_rss_hash_conf_get() as part of parsing >> RSS, but it would feel more confident if we could confirm it for all the PMDs >> (by testing) or at least review the PMDs rss_hash_conf_get() >> implementations. >>> >> >> Lijun's idea can work. There was a problem in implementation related to the >> key size assumption, which can be fixed. >> >> Even it is fixed, when user gives a rss rule without a key, we are getting key >> from device and feeding same key back to device, this is unnecessary I think. > > I agree. > >> When user didn't provide a key, rss rule shouldn't touch the key at all. > > Agreed as well. > >> Complication was when user provides key_len without a key, I think both >> ignoring or returning error in this case is OK. > > I think that in general flow rules should arrive "as is" to the PMD which has its > validation and translation APIs to handle all cases. > Do you agree with [1] + Ferruh update solution？