From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8BF53A00C2; Thu, 10 Feb 2022 12:51:34 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7729440140; Thu, 10 Feb 2022 12:51:34 +0100 (CET) Received: from shelob.oktetlabs.ru (shelob.oktetlabs.ru [91.220.146.113]) by mails.dpdk.org (Postfix) with ESMTP id 3979C4013F for ; Thu, 10 Feb 2022 12:51:33 +0100 (CET) Received: from [192.168.1.126] (unknown [188.242.181.57]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by shelob.oktetlabs.ru (Postfix) with ESMTPSA id 330B87D; Thu, 10 Feb 2022 14:51:32 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 shelob.oktetlabs.ru 330B87D DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=oktetlabs.ru; s=default; t=1644493892; bh=qTFnnx7sQtzoMP/bP/ozpad0BV9hz3soUdAlfM2bQqU=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=ibGpgKuL8w1E8UjDizcYw1P2+2F+ugOhn9PYOI5pYPwBjrOt+KHvUQ5Dxp2hsn3aL 4DSfyibaU5fT06XE0j8A9Wep/sfePnddRvFMqGdZtUqNBpv+UZRTvDQkbaXVvvKnzF Pquh+9ziyN1BV0ZFHUXJDDpqn/PNIxvM91NvII6s= Message-ID: <21fd32c9-d8d5-9807-3839-ee33af84bf8c@oktetlabs.ru> Date: Thu, 10 Feb 2022 14:51:31 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [PATCH] ethdev: introduce generic dummy packet burst function Content-Language: en-US To: =?UTF-8?Q?Morten_Br=c3=b8rup?= , Ferruh Yigit , Shepard Siegel , Ed Czeck , John Miller , Rasesh Mody , Shahed Shaikh , Ajit Khaparde , Somnath Kotur , Nithin Dabilpuram , Kiran Kumar K , Sunil Kumar Kori , Satha Rao , Hemant Agrawal , Sachin Saxena , John Daley , Hyong Youb Kim , "Min Hu (Connor)" , Yisen Zhuang , Lijun Ou , Matan Azrad , Viacheslav Ovsiienko , Gagandeep Singh , Devendra Singh Rawat , Thomas Monjalon Cc: dev@dpdk.org, Ciara Loftus References: <20220208194437.426143-1-ferruh.yigit@intel.com> <98CBD80474FA8B44BF855DF32C47DC35D86E7F@smartserver.smartshare.dk> <420e7dbf-856d-674f-bf32-021df572ed63@oktetlabs.ru> <98CBD80474FA8B44BF855DF32C47DC35D86E80@smartserver.smartshare.dk> From: Andrew Rybchenko In-Reply-To: <98CBD80474FA8B44BF855DF32C47DC35D86E80@smartserver.smartshare.dk> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 2/10/22 14:47, Morten Brørup wrote: >> From: Andrew Rybchenko [mailto:andrew.rybchenko@oktetlabs.ru] >> Sent: Thursday, 10 February 2022 12.39 >> >> On 2/10/22 14:04, Morten Brørup wrote: >>>> From: Ferruh Yigit [mailto:ferruh.yigit@intel.com] >>>> Sent: Tuesday, 8 February 2022 20.45 >>>> >>>> Multiple PMDs have dummy/noop Rx/Tx packet burst functions. >>>> >>>> These dummy functions are very simple, introduce a common function >> in >>>> the ethdev and update drivers to use it instead of each driver >> having >>>> its own functions. >>>> >>>> Signed-off-by: Ferruh Yigit >>> >>> After briefly considering if the dummy TX should free the burst, I >> concluded that the current behavior is correct. >> >> Could you share your thoughts, please. I'm wondering as well. > > Returning 0 means that the packets were not transmitted. > > This leaves it up to the application to decide what to do: drop or retransmit. > > If the dummy TX function frees the burst, it would effectively mean that the driver dropped the packets. (In that case, some drop counters should probably also be updated in the driver; but that is irrelevant now.) Makes sense, thank you. > > Not dropping the packets could be significant during startup. > >> >>> >>> Good clean-up. :-) >>> >>> Acked-by: Morten Brørup >>> >> >