DPDK patches and discussions
 help / color / mirror / Atom feed
From: yang_y_yi  <yang_y_yi@163.com>
To: "Thomas Monjalon" <thomas@monjalon.net>
Cc: Yi Yang (杨燚)-云服务集团 <yangyi01@inspur.com>,
	"dev@dpdk.org" <dev@dpdk.org>,
	 "jiayu.hu@intel.com" <jiayu.hu@intel.com>,
	 "olivier.matz@6wind.com" <olivier.matz@6wind.com>
Subject: Re: [dpdk-dev] 答复: [PATCH 2/3] mbuf: change free_cb interface to adapt to GSO case
Date: Thu, 30 Jul 2020 20:18:27 +0800 (CST)
Message-ID: <21feda39.7284.1739fa8cfd6.Coremail.yang_y_yi@163.com> (raw)
In-Reply-To: <26165953.ALDsH63Fg3@thomas>

Unfortunately, git send-email in windows can't work with -cc-cmd, I just tried it but maintainers weren't added to cc list. Here is my get-maintainer.sh. Anybody knows why it can't work.


$ ./get-maintainer.sh dpdk-patches/0000-cover-letter.patch

yangyi01@yangyi0100 MINGW64 ~
$ ./get-maintainer.sh dpdk-patches/0001-gso-fix-refcnt-update-issue-for-external-mbuf.patch
Jiayu Hu <jiayu.hu@intel.com>
Mark Kavanagh <mark.b.kavanagh@intel.com>
Konstantin Ananyev <konstantin.ananyev@intel.com>

yangyi01@yangyi0100 MINGW64 ~
$ ./get-maintainer.sh dpdk-patches/0002-mbuf-change-free_cb-interface-to-adapt-to-GSO-case.patch
Fiona Trahe <fiona.trahe@intel.com>
Ashish Gupta <ashish.gupta@marvell.com>
Olivier Matz <olivier.matz@6wind.com>
Matan Azrad <matan@mellanox.com>
Shahaf Shuler <shahafs@mellanox.com>
Viacheslav Ovsiienko <viacheslavo@mellanox.com>
Stephen Hemminger <sthemmin@microsoft.com>
K. Y. Srinivasan <kys@microsoft.com>
Haiyang Zhang <haiyangz@microsoft.com>
Long Li <longli@microsoft.com>
Maxime Coquelin <maxime.coquelin@redhat.com>
Zhihong Wang <zhihong.wang@intel.com>

yangyi01@yangyi0100 MINGW64 ~
$ ./get-maintainer.sh dpdk-patches/0003-vhost-use-new-free_cb-interface-to-fix-mbuf-free-iss.patch
Maxime Coquelin <maxime.coquelin@redhat.com>
Zhihong Wang <zhihong.wang@intel.com>

yangyi01@yangyi0100 MINGW64 ~















在 2020-07-30 18:42:38,"Thomas Monjalon" <thomas@monjalon.net> 写道:
>30/07/2020 12:39, Yi Yang (杨燚)-云服务集团:
>> Thomas, do you mean I need to change  the below files to add deprecation notice about free_cb?
>
>No it should be a separate patch for announing the deprecation in 20.08.
>
>Below patches cannot be applied in 20.08.
>
>
>> 
>> doc/guides/rel_notes/deprecation.rst
>> doc/guides/rel_notes/release_20_08.rst
>> 
>> I'll use --cc-cmd devtools/get-maintainer.sh to send a new version including deprecation notice you mentioned.
>> 
>> -----邮件原件-----
>> 发件人: Thomas Monjalon [mailto:thomas@monjalon.net] 
>> 发送时间: 2020年7月30日 18:17
>> 收件人: yang_y_yi@163.com
>> 抄送: dev@dpdk.org; jiayu.hu@intel.com; Yi Yang (杨燚)-云服务集团 <yangyi01@inspur.com>; yang_y_yi@163.com; olivier.matz@6wind.com
>> 主题: Re: [PATCH 2/3] mbuf: change free_cb interface to adapt to GSO case
>> 
>> 30/07/2020 11:56, yang_y_yi@163.com:
>> > --- a/lib/librte_mbuf/rte_mbuf.h
>> > +++ b/lib/librte_mbuf/rte_mbuf.h
>> > @@ -1193,7 +1193,7 @@ static inline void rte_pktmbuf_attach(struct rte_mbuf *mi, struct rte_mbuf *m)
>> >  	RTE_ASSERT(m->shinfo != NULL);
>> >  
>> >  	if (rte_mbuf_ext_refcnt_update(m->shinfo, -1) == 0)
>> > -		m->shinfo->free_cb(m->buf_addr, m->shinfo->fcb_opaque);
>> > +		m->shinfo->free_cb(m, m->shinfo->fcb_opaque);
>> >  }
>> >  
>> >  /**
>> > diff --git a/lib/librte_mbuf/rte_mbuf_core.h 
>> > b/lib/librte_mbuf/rte_mbuf_core.h index 8cd7137..d194429 100644
>> > --- a/lib/librte_mbuf/rte_mbuf_core.h
>> > +++ b/lib/librte_mbuf/rte_mbuf_core.h
>> > @@ -671,7 +671,7 @@ struct rte_mbuf {
>> >  /**
>> >   * Function typedef of callback to free externally attached buffer.
>> >   */
>> > -typedef void (*rte_mbuf_extbuf_free_callback_t)(void *addr, void 
>> > *opaque);
>> > +typedef void (*rte_mbuf_extbuf_free_callback_t)(struct rte_mbuf *, 
>> > +void *);
>> 
>> I think a deprecation notice is required in 20.08 in order to apply such change in 20.11.
>> 
>> Please use --cc-cmd devtools/get-maintainer.sh when sending a patch.
>> 
>> 
>> 
>
>
>
>

  parent reply	other threads:[~2020-07-30 12:18 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-30  9:56 [dpdk-dev] [PATCH 0/3] Fix external mbuf free issue in " yang_y_yi
2020-07-30  9:56 ` [dpdk-dev] [PATCH 1/3] gso: fix refcnt update issue for external mbuf yang_y_yi
2020-07-30  9:56 ` [dpdk-dev] [PATCH 2/3] mbuf: change free_cb interface to adapt to GSO case yang_y_yi
2020-07-30 10:16   ` Thomas Monjalon
     [not found]     ` <f16b530ed9234b988241d5c4b4329d1b@inspur.com>
2020-07-30 10:42       ` [dpdk-dev] 答复: " Thomas Monjalon
2020-07-30 10:44         ` yang_y_yi
2020-07-30 12:18         ` yang_y_yi [this message]
2020-07-30  9:56 ` [dpdk-dev] [PATCH 3/3] vhost: use new free_cb interface to fix mbuf free issue yang_y_yi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=21feda39.7284.1739fa8cfd6.Coremail.yang_y_yi@163.com \
    --to=yang_y_yi@163.com \
    --cc=dev@dpdk.org \
    --cc=jiayu.hu@intel.com \
    --cc=olivier.matz@6wind.com \
    --cc=thomas@monjalon.net \
    --cc=yangyi01@inspur.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git