From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
by inbox.dpdk.org (Postfix) with ESMTP id 6A4C2A0A0C;
Thu, 15 Apr 2021 09:27:47 +0200 (CEST)
Received: from [217.70.189.124] (localhost [127.0.0.1])
by mails.dpdk.org (Postfix) with ESMTP id 50E3816208B;
Thu, 15 Apr 2021 09:27:47 +0200 (CEST)
Received: from mga04.intel.com (mga04.intel.com [192.55.52.120])
by mails.dpdk.org (Postfix) with ESMTP id 18C8C162084
for <dev@dpdk.org>; Thu, 15 Apr 2021 09:27:45 +0200 (CEST)
IronPort-SDR: 1CtC6BrOvT6v6Xq2lcHReIxrGhYkFcOWpw0aSz7liWQM/SJU1zcmCU+7MmUKIOZLTX3bzHM3Mk
/ZBeMeQKj4Vw==
X-IronPort-AV: E=McAfee;i="6200,9189,9954"; a="192678744"
X-IronPort-AV: E=Sophos;i="5.82,223,1613462400"; d="scan'208";a="192678744"
Received: from orsmga008.jf.intel.com ([10.7.209.65])
by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;
15 Apr 2021 00:27:45 -0700
IronPort-SDR: Fxei/dPEnFiFdQ2NP29lG8gfP6dTBpjEMbKV3e8j0K26gvCbNm1Lv4aPSc4GsVNfRwxVudtg+V
y/79jd9s/BuQ==
X-IronPort-AV: E=Sophos;i="5.82,223,1613462400"; d="scan'208";a="425073883"
Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.213.204.163])
([10.213.204.163])
by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;
15 Apr 2021 00:27:44 -0700
To: "Min Hu (Connor)" <humin29@huawei.com>, dev@dpdk.org
References: <1618314611-47978-1-git-send-email-humin29@huawei.com>
<1618314611-47978-11-git-send-email-humin29@huawei.com>
<698abc7a-8c81-de22-7b20-7c2526ec3391@intel.com>
<b478296c-6a03-6055-9b7a-2e544d566a51@huawei.com>
From: Ferruh Yigit <ferruh.yigit@intel.com>
X-User: ferruhy
Message-ID: <21feef66-955b-c1d2-27f0-48e004a65f51@intel.com>
Date: Thu, 15 Apr 2021 08:27:40 +0100
MIME-Version: 1.0
In-Reply-To: <b478296c-6a03-6055-9b7a-2e544d566a51@huawei.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Subject: Re: [dpdk-dev] [PATCH 10/12] net/hns3: rename Rx burst API
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>
On 4/15/2021 2:58 AM, Min Hu (Connor) wrote:
>
>
> 在 2021/4/15 1:41, Ferruh Yigit 写道:
>> On 4/13/2021 12:50 PM, Min Hu (Connor) wrote:
>>> From: Chengwen Feng <fengchengwen@huawei.com>
>>>
>>> Currently, user could use runtime config "rx_func_hint=simple" to
>>> select the hns3_recv_pkts API, but the API's name get from
>>> rte_eth_rx_burst_mode_get is "Scalar" which has not reflected "simple".
>>>
>>> So this patch renames hns3_recv_pkts to hns3_recv_pkts_simple, and
>>> also change it's name which gets from rte_eth_rx_burst_mode_get to
>>> "Scalar Simple" to maintain conceptual consistency.
>>>
>>> Also changes the hns3_recv_scattered_pkts API's name which gets from
>>> rte_eth_rx_burst_mode_get to "Scalar".
>>>
>>> Fixes: 521ab3e93361 ("net/hns3: add simple Rx path")
>>> Cc: stable@dpdk.org
>>>
>>> Signed-off-by: Chengwen Feng <fengchengwen@huawei.com>
>>> Signed-off-by: Min Hu (Connor) <humin29@huawei.com>
>>
>> <...>
>>
>>> @@ -2743,10 +2745,10 @@ hns3_rx_burst_mode_get(struct rte_eth_dev *dev,
>>> __rte_unused uint16_t queue_id,
>>> eth_rx_burst_t pkt_burst;
>>> const char *info;
>>> } burst_infos[] = {
>>> - { hns3_recv_pkts, "Scalar" },
>>> - { hns3_recv_scattered_pkts, "Scalar Scattered" },
>>> - { hns3_recv_pkts_vec, "Vector Neon" },
>>> - { hns3_recv_pkts_vec_sve, "Vector Sve" },
>>> + { hns3_recv_pkts_simple, "Scalar Simple" },
>>> + { hns3_recv_scattered_pkts, "Scalar" },
>>> + { hns3_recv_pkts_vec, "Vector Neon" },
>>> + { hns3_recv_pkts_vec_sve, "Vector Sve" },
>>
>> No concern on the burst function rename, that is driver internal, but related
>> to the above change, I think new value "Scalar Simple" is not clear, what does
>> 'Simple' mean?
>> At least previously "Scalar Scattered" vs "Scalar" was more clear, one can
>> easily say difference is scattered Rx support, but with "Scalar" vs "Scalar
>> Simple" the difference is not clear.
>>
> Agreed to retain the hns3_recv_scattered_pkts name "Scalar Scattered",
> but suggests changing the hns3_recv_pkts_simple name to "Scalar Simple"
> for the following reasons:
> 1. Currently, the transmit and receive algorithms implemented in C language
> only process single-BD algorithms. The Rx direction is Scalar, while the
> Tx direction is Scalar Simple. The two do not correspond with each other.
> 2. The algorithm name selected by using rx_func_hint=simple does not contain
> simple. The DPDK user may be confused.
>
ack
> BTW, v2 has been sent, please check it out, thanks.
>> .