From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id EEA4BA0523; Fri, 3 Jul 2020 18:12:59 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id B4A901DC78; Fri, 3 Jul 2020 18:12:58 +0200 (CEST) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by dpdk.org (Postfix) with ESMTP id B9A211DC6B for ; Fri, 3 Jul 2020 18:12:55 +0200 (CEST) IronPort-SDR: VIcTKaBSk4BeWok2/hZZVHDuIPenAgvpulkuKaIUi99ipTAzC0SEFxjWhfcsjww4qRLe6mWxMQ RB55mRCBhHsA== X-IronPort-AV: E=McAfee;i="6000,8403,9671"; a="126778355" X-IronPort-AV: E=Sophos;i="5.75,308,1589266800"; d="scan'208";a="126778355" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Jul 2020 09:12:54 -0700 IronPort-SDR: LvgfhuJb47kLgItXJcyqI3dLUUcaQBcEvhZ8VJa110c+lVS7vt85BQSjpHN1nLwEx04lMRFmc5 BAXl0rpJ0Deg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.75,308,1589266800"; d="scan'208";a="282329575" Received: from fyigit-mobl.ger.corp.intel.com (HELO [10.252.2.200]) ([10.252.2.200]) by orsmga006.jf.intel.com with ESMTP; 03 Jul 2020 09:12:53 -0700 To: Thomas Monjalon , Kalesh Anakkur Purayil Cc: dev@dpdk.org, declan.doherty@intel.com, arybchenko@solarflare.com, Ajit Khaparde References: <20200122101654.20824-1-kalesh-anakkur.purayil@broadcom.com> <1946963.KlZ2vcFHjT@xps> <1632406.X513TT2pbd@xps> From: Ferruh Yigit Autocrypt: addr=ferruh.yigit@intel.com; keydata= mQINBFXZCFABEADCujshBOAaqPZpwShdkzkyGpJ15lmxiSr3jVMqOtQS/sB3FYLT0/d3+bvy qbL9YnlbPyRvZfnP3pXiKwkRoR1RJwEo2BOf6hxdzTmLRtGtwWzI9MwrUPj6n/ldiD58VAGQ +iR1I/z9UBUN/ZMksElA2D7Jgg7vZ78iKwNnd+vLBD6I61kVrZ45Vjo3r+pPOByUBXOUlxp9 GWEKKIrJ4eogqkVNSixN16VYK7xR+5OUkBYUO+sE6etSxCr7BahMPKxH+XPlZZjKrxciaWQb +dElz3Ab4Opl+ZT/bK2huX+W+NJBEBVzjTkhjSTjcyRdxvS1gwWRuXqAml/sh+KQjPV1PPHF YK5LcqLkle+OKTCa82OvUb7cr+ALxATIZXQkgmn+zFT8UzSS3aiBBohg3BtbTIWy51jNlYdy ezUZ4UxKSsFuUTPt+JjHQBvF7WKbmNGS3fCid5Iag4tWOfZoqiCNzxApkVugltxoc6rG2TyX CmI2rP0mQ0GOsGXA3+3c1MCdQFzdIn/5tLBZyKy4F54UFo35eOX8/g7OaE+xrgY/4bZjpxC1 1pd66AAtKb3aNXpHvIfkVV6NYloo52H+FUE5ZDPNCGD0/btFGPWmWRmkPybzColTy7fmPaGz cBcEEqHK4T0aY4UJmE7Ylvg255Kz7s6wGZe6IR3N0cKNv++O7QARAQABtCVGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBpbnRlbC5jb20+iQJsBBMBCgBWAhsDAh4BAheABQsJCAcDBRUK CQgLBRYCAwEABQkKqZZ8FiEE0jZTh0IuwoTjmYHH+TPrQ98TYR8FAl6ha3sXGHZrczovL2tl eXMub3BlbnBncC5vcmcACgkQ+TPrQ98TYR8uLA//QwltuFliUWe60xwmu9sY38c1DXvX67wk UryQ1WijVdIoj4H8cf/s2KtyIBjc89R254KMEfJDao/LrXqJ69KyGKXFhFPlF3VmFLsN4XiT PSfxkx8s6kHVaB3O183p4xAqnnl/ql8nJ5ph9HuwdL8CyO5/7dC/MjZ/mc4NGq5O9zk3YRGO lvdZAp5HW9VKW4iynvy7rl3tKyEqaAE62MbGyfJDH3C/nV/4+mPc8Av5rRH2hV+DBQourwuC ci6noiDP6GCNQqTh1FHYvXaN4GPMHD9DX6LtT8Fc5mL/V9i9kEVikPohlI0WJqhE+vQHFzR2 1q5nznE+pweYsBi3LXIMYpmha9oJh03dJOdKAEhkfBr6n8BWkWQMMiwfdzg20JX0o7a/iF8H 4dshBs+dXdIKzPfJhMjHxLDFNPNH8zRQkB02JceY9ESEah3wAbzTwz+e/9qQ5OyDTQjKkVOo cxC2U7CqeNt0JZi0tmuzIWrfxjAUulVhBmnceqyMOzGpSCQIkvalb6+eXsC9V1DZ4zsHZ2Mx Hi+7pCksdraXUhKdg5bOVCt8XFmx1MX4AoV3GWy6mZ4eMMvJN2hjXcrreQgG25BdCdcxKgqp e9cMbCtF+RZax8U6LkAWueJJ1QXrav1Jk5SnG8/5xANQoBQKGz+yFiWcgEs9Tpxth15o2v59 gXK5Ag0EV9ZMvgEQAKc0Db17xNqtSwEvmfp4tkddwW9XA0tWWKtY4KUdd/jijYqc3fDD54ES YpV8QWj0xK4YM0dLxnDU2IYxjEshSB1TqAatVWz9WtBYvzalsyTqMKP3w34FciuL7orXP4Ai bPtrHuIXWQOBECcVZTTOdZYGAzaYzxiAONzF9eTiwIqe9/oaOjTwTLnOarHt16QApTYQSnxD UQljeNvKYt1lZE/gAUUxNLWsYyTT+22/vU0GDUahsJxs1+f1yEr+OGrFiEAmqrzpF0lCS3f/ 3HVTU6rS9cK3glVUeaTF4+1SK5ZNO35piVQCwphmxa+dwTG/DvvHYCtgOZorTJ+OHfvCnSVj sM4kcXGjJPy3JZmUtyL9UxEbYlrffGPQI3gLXIGD5AN5XdAXFCjjaID/KR1c9RHd7Oaw0Pdc q9UtMLgM1vdX8RlDuMGPrj5sQrRVbgYHfVU/TQCk1C9KhzOwg4Ap2T3tE1umY/DqrXQgsgH7 1PXFucVjOyHMYXXugLT8YQ0gcBPHy9mZqw5mgOI5lCl6d4uCcUT0l/OEtPG/rA1lxz8ctdFB VOQOxCvwRG2QCgcJ/UTn5vlivul+cThi6ERPvjqjblLncQtRg8izj2qgmwQkvfj+h7Ex88bI 8iWtu5+I3K3LmNz/UxHBSWEmUnkg4fJlRr7oItHsZ0ia6wWQ8lQnABEBAAGJAjwEGAEKACYC GwwWIQTSNlOHQi7ChOOZgcf5M+tD3xNhHwUCXqFrngUJCKxSYAAKCRD5M+tD3xNhH3YWD/9b cUiWaHJasX+OpiuZ1Li5GG3m9aw4lR/k2lET0UPRer2Jy1JsL+uqzdkxGvPqzFTBXgx/6Byz EMa2mt6R9BCyR286s3lxVS5Bgr5JGB3EkpPcoJT3A7QOYMV95jBiiJTy78Qdzi5LrIu4tW6H o0MWUjpjdbR01cnj6EagKrDx9kAsqQTfvz4ff5JIFyKSKEHQMaz1YGHyCWhsTwqONhs0G7V2 0taQS1bGiaWND0dIBJ/u0pU998XZhmMzn765H+/MqXsyDXwoHv1rcaX/kcZIcN3sLUVcbdxA WHXOktGTQemQfEpCNuf2jeeJlp8sHmAQmV3dLS1R49h0q7hH4qOPEIvXjQebJGs5W7s2vxbA 5u5nLujmMkkfg1XHsds0u7Zdp2n200VC4GQf8vsUp6CSMgjedHeF9zKv1W4lYXpHp576ZV7T GgsEsvveAE1xvHnpV9d7ZehPuZfYlP4qgo2iutA1c0AXZLn5LPcDBgZ+KQZTzm05RU1gkx7n gL9CdTzVrYFy7Y5R+TrE9HFUnsaXaGsJwOB/emByGPQEKrupz8CZFi9pkqPuAPwjN6Wonokv ChAewHXPUadcJmCTj78Oeg9uXR6yjpxyFjx3vdijQIYgi5TEGpeTQBymLANOYxYWYOjXk+ae dYuOYKR9nbPv+2zK9pwwQ2NXbUBystaGyQ== Message-ID: <21ff7b78-c178-5499-5f50-26d84ed47a0a@intel.com> Date: Fri, 3 Jul 2020 17:12:52 +0100 MIME-Version: 1.0 In-Reply-To: <1632406.X513TT2pbd@xps> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [RFC PATCH 0/3] librte_ethdev: error recovery support X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 3/12/2020 7:34 AM, Thomas Monjalon wrote: > 12/03/2020 04:25, Kalesh Anakkur Purayil: >> Hi Thomas, >> >> On Wed, Mar 11, 2020 at 6:49 PM Thomas Monjalon wrote: >> >>> 22/01/2020 11:16, Kalesh A P: >>>> From: Kalesh AP >>>> >>>> This patch adds support for recovery event in rte_eth_event framework. >>>> FW error and FW reset conditions would be managed by PMD. Driver uses >>> >>> "Driver"? THE driver? :) >>> >>>> RTE_ETH_EVENT_INTR_RESET event to notify the applications about the >>>> FW reset or error. >>> >>> Which drivers doe that? >>> >> [Kalesh]: Second patch in this series implements this behavior in bnxt PMD. >> Error recovery is a new feature added in bnxt PMD in 19.11. This change is >> needed to support error recovery functionality. >> >>> >>>> In such cases, PMD would need recovery events to >>>> notify application about PMD has recovered from FW reset or FW error. >>> >>> Sorry I don't understand. You said application is notified of any error. >>> But the PMD can recover from this error? So what is the error at the end? >>> If the error is recovered why notifying the application? >>> >> [Kalesh] : Let me give you some insight on this. >> >> The error recovery solution is a protocol implemented between firmware and >> bnxt PMD to recover from the fatal errors without a system reboot. There is >> an alarm thread which constantly monitors the health of the firmware and >> initiates a recovery when needed. >> >> There are two scenarios here: >> >> 1. Hardware or firmware encountered an error which firmware detected. >> Firmware is in operational status here. In this case, firmware can reset >> the chip and notify the driver about the reset. >> 2. Hardware or firmware encountered an error but firmware is dead/hung. >> Firmware is not in operational status. In this case, the only possible way >> to recover the adapter is through host driver(bnxt PMD). >> >> In both cases, bnxt PMD reinitializes with the FW again after the reset. >> During that recovery process, data path will be halted and any control path >> operation would fail. So, bnxt PMD has to notify the application about this >> reset/error event to prevent any activities from application during this >> time. > > I think you are changing the meaning of the reset event. > It was described like this: > RTE_ETH_EVENT_INTR_RESET, > /**< reset interrupt event, sent to VF on PF reset */ > > Please update this description as well. > > Of course, we'll need approval from other PMD maintainers > to accept the new recovery API. > Hi Kalesh, Is this RFC still relevant/valid?