From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f53.google.com (mail-wm0-f53.google.com [74.125.82.53]) by dpdk.org (Postfix) with ESMTP id 06CA42B98 for ; Thu, 3 Mar 2016 10:30:03 +0100 (CET) Received: by mail-wm0-f53.google.com with SMTP id l68so122155586wml.0 for ; Thu, 03 Mar 2016 01:30:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:organization:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=LmiT6Gnt3qSaknOesD0CHJZD8xLi2kQ3PIgYJoGR/bg=; b=I2IFxSbUAAvM1AYOhiSgbnK4Ijv/HuOljq/2i/BRmJN4BSQfedAMrEofwFJhNjxD/X 6YJ45skTYRjlclY6cmT+n/1Bj7CzUpJdjEYqcP3lQFJyAwyaMGEvbY/tLF6AOrMYCOZi t8Cu+IWSU3S0isZHL2qXfjBgMoOT4J6CHY7uHAt4nJElPT/Ab7G6FIbkWzlChjZHwAxB 7uglMEK7b8V4XswCmJ2zraauJlrIFwUx3VlxeAvMjbp5IShKk37SL0IE1cZUNbjj32bD oVLSgE4tm/AR6y9wVkxoHcUVzUfdknZGxwJVlY/d8sktpOTsxtnUV89KN8Il85MN7fOM Mj1g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding; bh=LmiT6Gnt3qSaknOesD0CHJZD8xLi2kQ3PIgYJoGR/bg=; b=IAoJgu+2qp81ypw84riWF7JjoUn6c0kNFLILELLjXu2ef4ADylsTgT9ugToIHYM2Mt bKANRGMVF3XZVTO/F8p5JsXZatnsUukm9OU4vF1SPvmGzJC4j4+dgusy/KkGDSKsH9Nd bWaRe80yTwWja1UQViZNAtszceqxsNYcw/iQimHsgU2T05wTWAIMuS4yakZmz8Z5S94A l+i3SFITwPUXR7ueTEzZYRUI+9QNsv7zpSr2IiT+vtfB3QoUckp4l7y1r70nZlJaEDWa LwZEjXvwTN0QByjuAMN7XDb04V83tZoVSvGsxLOVzq9L+EtNp5th5/MSs/s376AbRzYn WQUA== X-Gm-Message-State: AD7BkJJQTf60PyXQS5c9tcClmqzM92I6EIIIzJQEuyh4BO1OK9zlFeUdebopP7z3FxccRAoh X-Received: by 10.28.135.1 with SMTP id j1mr4533365wmd.20.1456997402854; Thu, 03 Mar 2016 01:30:02 -0800 (PST) Received: from xps13.localnet (guy78-3-82-239-227-177.fbx.proxad.net. [82.239.227.177]) by smtp.gmail.com with ESMTPSA id av3sm39856439wjc.44.2016.03.03.01.30.01 (version=TLSv1/SSLv3 cipher=OTHER); Thu, 03 Mar 2016 01:30:02 -0800 (PST) From: Thomas Monjalon To: Simon =?ISO-8859-1?Q?K=E5gstr=F6m?= , Stephen Hurd Date: Thu, 03 Mar 2016 10:28:27 +0100 Message-ID: <2201521.3lr0Br3EYS@xps13> Organization: 6WIND User-Agent: KMail/4.14.10 (Linux/4.1.6-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <56D7ED89.8060903@netinsight.net> References: <1456954614-119304-1-git-send-email-stephen.hurd@broadcom.com> <1456978137-98097-2-git-send-email-stephen.hurd@broadcom.com> <56D7ED89.8060903@netinsight.net> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="iso-8859-1" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH 1/7] lib/librte_ether: Add 2/2.5/25/50Gbps link speeds X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 03 Mar 2016 09:30:03 -0000 Hi, 2016-03-03 08:53, Simon K=E5gstr=F6m: > Hi! >=20 > On 2016-03-03 05:08, Stephen Hurd wrote: > > Add additional ETH_LINK_SPEED_* macros for 2, 2.5, 25, and 50 Gbps = links Stephen, you could be interested in the rework done by Marc Sune: =09http://dpdk.org/dev/patchwork/patch/10919/ > I realize this is a more general question, but is it really meaningfu= l > to have macros for all possible link speeds? We're working on a PMD > driver with a channelized interface exposed as DPDK ports. Each chann= el > can be configured with an arbitrary speed, so e.g., 1337 Mbps is also= > possible. What is the benefit? Why not negotiate the maximum capability of the pe= er? > To me, it would seem more natural to just have a number in mbits for = the > link speed. Please jump in the thread initiated by Marc Sune months ago.