From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: "De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com>
Cc: dev@dpdk.org, Yu Nemo Wenbin <yuwb_bjy@ctbri.com.cn>
Subject: Re: [dpdk-dev] [PATCH v3 1/3] hash: add rte_hash_set_cmp_func() function.
Date: Mon, 07 Dec 2015 00:43:43 +0100 [thread overview]
Message-ID: <2203157.9kzBf8srYb@xps13> (raw)
In-Reply-To: <E115CCD9D858EF4F90C690B0DCB4D8973C86609B@IRSMSX108.ger.corp.intel.com>
2015-12-04 08:54, De Lara Guarch, Pablo:
> Hi Nemo,
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Yu Nemo Wenbin
> > Give user a chance to costomize the hash key compare function.
> > The default rte_hash_cmp_eq function is set in the rte_hash_create
> > function, but these builtin ones may not good enough, so the user
> > may call this to override the default one.
> >
> > Signed-off-by: Yu Nemo Wenbin <yuwb_bjy@ctbri.com.cn>
>
> What I meant with all the changes in one go is to include them in a single patch, not three,
> where your starting point is the current code in mainline.
> Please, check that the commit message is fixed as we discussed,
> and that the new function is in DPDK_2.2, and not DPDK_2.1
I think I've understood what Nemo wants to do.
I've fixed the indent, fixed the doxygen comment and dropped the third patch.
At the end, applied with your previous ack.
prev parent reply other threads:[~2015-12-06 23:44 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-19 1:15 [dpdk-dev] [PATCH] " Yu Nemo Wenbin
2015-11-24 14:06 ` De Lara Guarch, Pablo
2015-12-03 5:23 ` [dpdk-dev] [PATCH v2] hash: move rte_hash_set_cmp_func() to ver DPDK_2.2 Yu Nemo Wenbin
2015-12-03 9:25 ` De Lara Guarch, Pablo
2015-12-04 3:11 ` [dpdk-dev] [PATCH v3 1/3] hash: add rte_hash_set_cmp_func() function Yu Nemo Wenbin
2015-12-04 3:11 ` [dpdk-dev] [PATCH v3 2/3] " Yu Nemo Wenbin
2015-12-04 3:11 ` [dpdk-dev] [PATCH v3 3/3] hash: put rte_hash_set_cmp_func() back to DPDK_2.1 Yu Nemo Wenbin
2015-12-04 8:54 ` [dpdk-dev] [PATCH v3 1/3] hash: add rte_hash_set_cmp_func() function De Lara Guarch, Pablo
2015-12-06 23:43 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2203157.9kzBf8srYb@xps13 \
--to=thomas.monjalon@6wind.com \
--cc=dev@dpdk.org \
--cc=pablo.de.lara.guarch@intel.com \
--cc=yuwb_bjy@ctbri.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).