From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <thomas.monjalon@6wind.com> Received: from mail-wm0-f48.google.com (mail-wm0-f48.google.com [74.125.82.48]) by dpdk.org (Postfix) with ESMTP id 2489993A6 for <dev@dpdk.org>; Mon, 7 Dec 2015 00:44:55 +0100 (CET) Received: by wmuu63 with SMTP id u63so120821913wmu.0 for <dev@dpdk.org>; Sun, 06 Dec 2015 15:44:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:organization:user-agent :in-reply-to:references:mime-version:content-transfer-encoding :content-type; bh=prFLQA0dASUf/bCbwVklCdn4XyKN/7mAs5Nj9PvSDk8=; b=2BtwsKXITKxU654bKSDGg040AZwIJxGvgh+972VDJBjwsNVHNjScpGs8TPUi4/6mPU N9Rt37Qs00OIcoZnhauNTVbck6uJkUoz6tzAL4KbhTNg+HDvTFRC4ZfDs4FPLCOROokc 7j2+3l0Fa+VBpf6Rzpw6roBszyLl/OqKQkSli2vY+Y6VV0iQHpRImPlux5pchwVuThlJ SzP6197pXFVQZc0MGjU7Fh3EJnAH8YBIbrcDpxy/owvaylMgKBQg4TfTUS5hyehAblAq Ak1LYSw5PmibgL5YjskK5MRNeAMGyk58W4qBp/OFrX/LwvadcflWO+Pipz5tlIZwa6uh 6geQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=prFLQA0dASUf/bCbwVklCdn4XyKN/7mAs5Nj9PvSDk8=; b=T2zCwWPy0XD4X+SNjiD1kHYGXlb9euOFSIlH8n3PxPJAPlAEA3E6J7ck057rsm6NKD cJ36W9b+xIYnuY3I3tLhSw2UbWBhF2SI+XxFLMBBPkWS/Ae2SWY0hqW5ndooLBVDW+fD VPAAEM7pXswss5YcwahHduHAhaTZAnn7TFKvyL2k4yhUTpdMBe8xSgEMSU9IzbB0mpe/ c3rL4yviE2qS3hK7PJt8sqxgrw5lm/7zDgP5PTbE0WP1Rb75wfvq2ngGPzfxFNOC9OE4 43hHkihxoh6I8CesUE0l+cTApDliN3KpahRGNh2vMFtOu7JHCBzbRMstz0Opq62Oo7w4 mR+A== X-Gm-Message-State: ALoCoQnU4UlZ0Cvj2FqArYu08QJEDwhfHMt6Kxus3h0rSFxe/7TfXyEK9t3rBbTiegXvjRDt3Q26 X-Received: by 10.194.114.164 with SMTP id jh4mr710488wjb.153.1449445494991; Sun, 06 Dec 2015 15:44:54 -0800 (PST) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by smtp.gmail.com with ESMTPSA id k125sm13900874wmf.2.2015.12.06.15.44.53 (version=TLSv1/SSLv3 cipher=OTHER); Sun, 06 Dec 2015 15:44:54 -0800 (PST) From: Thomas Monjalon <thomas.monjalon@6wind.com> To: "De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com> Date: Mon, 07 Dec 2015 00:43:43 +0100 Message-ID: <2203157.9kzBf8srYb@xps13> Organization: 6WIND User-Agent: KMail/4.14.10 (Linux/4.1.6-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <E115CCD9D858EF4F90C690B0DCB4D8973C86609B@IRSMSX108.ger.corp.intel.com> References: <1447895712-12159-1-git-send-email-yuwb_bjy@ctbri.com.cn> <1449198703-8585-1-git-send-email-yuwb_bjy@ctbri.com.cn> <E115CCD9D858EF4F90C690B0DCB4D8973C86609B@IRSMSX108.ger.corp.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org, Yu Nemo Wenbin <yuwb_bjy@ctbri.com.cn> Subject: Re: [dpdk-dev] [PATCH v3 1/3] hash: add rte_hash_set_cmp_func() function. X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK <dev.dpdk.org> List-Unsubscribe: <http://dpdk.org/ml/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://dpdk.org/ml/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <http://dpdk.org/ml/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> X-List-Received-Date: Sun, 06 Dec 2015 23:44:55 -0000 2015-12-04 08:54, De Lara Guarch, Pablo: > Hi Nemo, > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Yu Nemo Wenbin > > Give user a chance to costomize the hash key compare function. > > The default rte_hash_cmp_eq function is set in the rte_hash_create > > function, but these builtin ones may not good enough, so the user > > may call this to override the default one. > > > > Signed-off-by: Yu Nemo Wenbin <yuwb_bjy@ctbri.com.cn> > > What I meant with all the changes in one go is to include them in a single patch, not three, > where your starting point is the current code in mainline. > Please, check that the commit message is fixed as we discussed, > and that the new function is in DPDK_2.2, and not DPDK_2.1 I think I've understood what Nemo wants to do. I've fixed the indent, fixed the doxygen comment and dropped the third patch. At the end, applied with your previous ack.