From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id BCA774221C; Fri, 1 Sep 2023 09:28:47 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4C7F340285; Fri, 1 Sep 2023 09:28:47 +0200 (CEST) Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by mails.dpdk.org (Postfix) with ESMTP id 3B4CD4014F; Fri, 1 Sep 2023 09:28:45 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id ADB475C0120; Fri, 1 Sep 2023 03:28:44 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Fri, 01 Sep 2023 03:28:44 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm1; t= 1693553324; x=1693639724; bh=bV662zyE0sgYF6Mn1GOr3jATgErhP/bcjr9 5xk3eFx4=; b=FnYB8E7nO1EAe05G/jQ4pxjLeglBBev8FFZTSO/NZIbGj0YCRh/ uGXyQPvGfwdaAkcwVJHpZt3sozmH62wfz/8aMdNzPYYKrc0GPcQiZT30QxYD/2R0 4I4c3Uc+Fei+186YwCuG0cpSwzcTMK12vfmV8xgY1iUV9lE3PZzS0u51dLbThPHl uHadI7Dfn/5tgjluPvpoq0/lrJ5RhjWZ2fJMhyS1Os75kjMtOhH5Z5RP7MpQGHQ0 bspiKHRM8t3SzkaHUIwvlDbzqh9LKymBZJw1KPNu77y8R5NGkEatW/Y4zZsqRTCj JjfuPMCweiZfwzXcdcWLjUHEJ6mBD0PvLLg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t= 1693553324; x=1693639724; bh=bV662zyE0sgYF6Mn1GOr3jATgErhP/bcjr9 5xk3eFx4=; b=2UPPVNZc+W6NEqdx32ep9VYxdVubJ+WW/35zXTw6KO4gw1LFsD5 LwER/yNY2Ibx7F56n+f3hpkI4agxDmBUUDwc6zEaW4dk0luGrS+QL6+yL8BLi+/z tNmo68tyNB+CE8VstkQMPQHWcYw9gGhngcadyBpCvvmfQFn8H8DHvkAQfgkN5kNi hOpwCqlWg/MumYY3Mg18zvA+VUbafexUg5J4Wz1NHTBlnS3a1QcjiUcg75rK5nUj alceoWc7lpkQ147lRzTjw64LBedvFXwr46oaddZocW+G05kil6t9yPfNAAqQaBCo 3t1q5r4V/sRdkkYBtBEZvfRaRXxvjAPD6rw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedviedrudeguddguddulecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefhvfevufffkfgjfhgggfgtsehtqhertddttdejnecuhfhrohhmpefvhhho mhgrshcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqne cuggftrfgrthhtvghrnhepgedttdeljeejgeffkeekkedtjeevtdehvedtkeeivdeuuedv ieduvdelveejueejnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilh hfrhhomhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 1 Sep 2023 03:28:43 -0400 (EDT) From: Thomas Monjalon To: Morten =?ISO-8859-1?Q?Br=F8rup?= , Jerin Jacob Cc: Ankur Dwivedi , Stephen Hemminger , Jerin Jacob Kollanukkaran , dev@dpdk.org, techboard@dpdk.org Subject: Re: [EXT] Re: [PATCH v5 1/1] devtools: add tracepoint check in checkpatch Date: Fri, 01 Sep 2023 09:28:41 +0200 Message-ID: <2204009.72vocr9iq0@thomas> In-Reply-To: References: <20230303155811.2751210-1-adwivedi@marvell.com> <98CBD80474FA8B44BF855DF32C47DC35D87B5D@smartserver.smartshare.dk> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Let's decide in a techboard meeting whether traces are mandatory or not. 01/09/2023 04:32, Jerin Jacob: > On Thu, Aug 31, 2023 at 12:08=E2=80=AFAM Morten Br=C3=B8rup wrote: > > > > > From: Thomas Monjalon [mailto:thomas@monjalon.net] > > > Sent: Wednesday, 30 August 2023 18.24 > > > > > > 21/08/2023 16:46, Morten Br=C3=B8rup: > > > > > From: Ankur Dwivedi [mailto:adwivedi@marvell.com] > > > > > Sent: Monday, 21 August 2023 15.54 >=20 > > > > > > In general, I wonder how much the check is useful compared to the > > > complexity. > > > > > > > > > > The bigger question is: Do we really want to change tracepoints in > > > functions from opt-in to opt-out? > > > > > > Yes that's the question: should traces be mandatory in some libs? > > > > > > > In my opinion, opt-in for trace is more appropriate. > > > > > > There was some work to add traces everywhere in few libs, so why not > > > maintaining this state? > > > > I still think it's a silly and burdening requirement, but I'm not again= st it for the libs where it is already a de facto standard. > > > > > > I can imagine similar requirements regarding logging, telemetry and dum= p functions being imposed on select libs. > > > > Perhaps we should also require that new libs implement all four types o= f instrumentation, to ensure that only high quality (i.e. fully instrumente= d) libs are accepted into DPDK. >=20 > IMO, There is a lot of effort to put trace points to existing > libraries, without these check, soon the disparity shows up when > someone adds new APIs to library and forget > to add trace points. >=20 > It is pretty easy to add trace point and there are a lot of > references, so I don't think there is burden for a developer > comparing to the effort of adding a new API. >=20 > Most of the time, contributors forgets to add trace point because > there is no automatic way to find it. > Also, additional git commits are needs if some decide to add it later. >=20 > No strong opinion, If not find not useful, we could mark this patch is > not appliable. Keeping the patch is limbo state is the issue. It is > already reached to v5. > So please decide one way or another. >=20 >=20 >=20 >=20 > > > > > > > I don't really like adding a skip list as one more burden for future > > > authors. > > > > If the warning omitted from checkpatches refers to the skip list and it= s location, it is relatively easy for developers to manage. > > > > And reviewers will notice if new functions have been added to the skip = list, indicating that trace has been omitted. So there are also advantages = to the skip list.