From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D4F40A0C47; Wed, 27 Oct 2021 16:59:15 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id BF870411C3; Wed, 27 Oct 2021 16:59:15 +0200 (CEST) Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by mails.dpdk.org (Postfix) with ESMTP id 00152411B8 for ; Wed, 27 Oct 2021 16:59:13 +0200 (CEST) Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.nyi.internal (Postfix) with ESMTP id 907615C006D; Wed, 27 Oct 2021 10:59:13 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Wed, 27 Oct 2021 10:59:13 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm2; bh= NKOf9LyeXqzv21HHTVkguaYtDEQZmIpYSXD23d58KqQ=; b=sZSVYE+Fztc0sPSG 6kthCZ85RQU1FwHw+DxhqqEP70HGaBujL7lS8CpPVq63AwcUHWzsTNmEe1zUcDKW xszv+BftKgyZtWFTNnsV+jpW/OhL9ctHIfgYBuV9pwZ2cJ5+CCbGAfY2AY6W7m7J GjX44ArhQvzsY2KgotjcbZX4+gyKezdOpG7Ztn0ZWjjvf4ajE3/aouL5QobtWfk4 VS6TMMo4eo19xAU6QV+jn/W08twaIJgxCu1FrknpFAClJuTOY0OcyxaJR6cXpYYd 4OgKbBOI2/jgKu50u8aJkVIl5JaQRqXRYcgwQtgrbBH+Km37UAbeauSSF11UPiHy eV3EOw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=NKOf9LyeXqzv21HHTVkguaYtDEQZmIpYSXD23d58K qQ=; b=Tfv2as7igYqhSNiEoYFxPmbSL31gFTYhu9Tz5KoRvidfK5O9xeJlQEms7 CIW5AltC8TgelK901q7wtrIN29kz26uGwcnawHoMzD52f/nLzSPKX8UwNVeWRnj8 I8M1B28nJN68lqVAy46AZP2hbcGtkyCS4KlRWrp6hGbB5yJLZI/NxAeYo+ei0koi QX6ozapFlJkb2lk5bERhFjT6LG78X3+6dBibAtYBlw925PmCnUkrz/AFO6Tzobc5 Q7Yg/B9x75HUEs1EpCQ/gjNawBhx6OZiMdltrN7h77GQcQ3iBYolLuwY+fSHnIEk edGIk7uyG4c5RkGFBowVYuIn6xacg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvtddrvdegtddgkedtucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepffdvffejueetleefieeludduuefgteejleevfeekjeefieegheet ffdvkeefgedunecuffhomhgrihhnpeguphgukhdrohhrghenucevlhhushhtvghrufhiii gvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghlohhn rdhnvght X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 27 Oct 2021 10:59:12 -0400 (EDT) From: Thomas Monjalon To: Selwin Sebastian Cc: dev@dpdk.org, David Marchand Date: Wed, 27 Oct 2021 16:59:11 +0200 Message-ID: <2206052.W0LVaOh8SP@thomas> In-Reply-To: References: <20210906165556.65015-1-selwin.sebastian@amd.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [RFC PATCH v2] raw/ptdma: introduce ptdma driver X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Any update please? 06/09/2021 19:17, David Marchand: > On Mon, Sep 6, 2021 at 6:56 PM Selwin Sebastian > wrote: > > > > Add support for PTDMA driver > > - This description is rather short. > > Can this new driver be implemented as a dmadev? > See (current revision): > https://patchwork.dpdk.org/project/dpdk/list/?series=18677&state=%2A&archive=both > > > - In any case, quick comments on this patch: > Please update release notes. > vfio-pci should be preferred over igb_uio. > Please check indent in meson. > ABI version is incorrect in version.map. > RTE_LOG_REGISTER_DEFAULT should be preferred. > The patch is monolithic, could it be split per functionnality to ease review? > > Copy relevant maintainers and/or (sub-)tree maintainers to make them > aware of this work, and get those patches reviewed. > Please submit new revisions of patchsets with increased revision > number in title + changelog that helps track what changed between > revisions. > > Some of those points are described in: > https://doc.dpdk.org/guides/contributing/patches.html > > > Thanks.