* [dpdk-dev] [PATCH] eal: call plugin init before device parse
@ 2017-10-13 11:55 Santosh Shukla
2017-10-13 12:35 ` Maxime Coquelin
0 siblings, 1 reply; 3+ messages in thread
From: Santosh Shukla @ 2017-10-13 11:55 UTC (permalink / raw)
To: dev; +Cc: thomas, jerin.jacob, maxime.coquelin, Santosh Shukla
Default eal_init code calls
0. eal_plugins_init
1. eal_option_device_parse
2. rte_bus_scan
IOVA commit:cf408c224 missed on calling eal_plugins_init before
eal_option_device_parse, rte_bus_scan and that introduced below
regression for shared mode:
with CONFIG_RTE_BUILD_SHARED_LIB=y:
'net_vhost0,iface=/tmp/vhost-user2' -d ./install/lib/librte_pmd_vhost.so
-- --portmask=1 --disable-hw-vlan -i --rxq=1 --txq=1 --nb-cores=1
--eth-peer=0,52:54:00:11:22:12
EAL: Detected 4 lcore(s)
ERROR: failed to parse device "net_vhost0"
EAL: Unable to parse device 'net_vhost0,iface=/tmp/vhost-user2'
PANIC in main():
Cannot init EAL
Fixes: cf408c224 ("eal: auto detect IOVA mode")
Reported-by: Maxime Coquelin <maxime.coquelin@redhat.com>
Signed-off-by: Santosh Shukla <santosh.shukla@caviumnetworks.com>
---
lib/librte_eal/bsdapp/eal/eal.c | 10 +++++++---
lib/librte_eal/linuxapp/eal/eal.c | 10 +++++++---
2 files changed, 14 insertions(+), 6 deletions(-)
diff --git a/lib/librte_eal/bsdapp/eal/eal.c b/lib/librte_eal/bsdapp/eal/eal.c
index 30d3bd5b5..e981721aa 100644
--- a/lib/librte_eal/bsdapp/eal/eal.c
+++ b/lib/librte_eal/bsdapp/eal/eal.c
@@ -551,6 +551,13 @@ rte_eal_init(int argc, char **argv)
return -1;
}
+ if (eal_plugins_init() < 0) {
+ rte_eal_init_alert("Cannot init plugins\n");
+ rte_errno = EINVAL;
+ rte_atomic32_clear(&run_once);
+ return -1;
+ }
+
if (eal_option_device_parse()) {
rte_errno = ENODEV;
rte_atomic32_clear(&run_once);
@@ -635,9 +642,6 @@ rte_eal_init(int argc, char **argv)
eal_check_mem_on_local_socket();
- if (eal_plugins_init() < 0)
- rte_eal_init_alert("Cannot init plugins\n");
-
eal_thread_init_master(rte_config.master_lcore);
ret = eal_thread_dump_affinity(cpuset, RTE_CPU_AFFINITY_STR_LEN);
diff --git a/lib/librte_eal/linuxapp/eal/eal.c b/lib/librte_eal/linuxapp/eal/eal.c
index ec37c52c0..ad7278989 100644
--- a/lib/librte_eal/linuxapp/eal/eal.c
+++ b/lib/librte_eal/linuxapp/eal/eal.c
@@ -786,6 +786,13 @@ rte_eal_init(int argc, char **argv)
return -1;
}
+ if (eal_plugins_init() < 0) {
+ rte_eal_init_alert("Cannot init plugins\n");
+ rte_errno = EINVAL;
+ rte_atomic32_clear(&run_once);
+ return -1;
+ }
+
if (eal_option_device_parse()) {
rte_errno = ENODEV;
rte_atomic32_clear(&run_once);
@@ -882,9 +889,6 @@ rte_eal_init(int argc, char **argv)
eal_check_mem_on_local_socket();
- if (eal_plugins_init() < 0)
- rte_eal_init_alert("Cannot init plugins\n");
-
eal_thread_init_master(rte_config.master_lcore);
ret = eal_thread_dump_affinity(cpuset, RTE_CPU_AFFINITY_STR_LEN);
--
2.13.0
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-dev] [PATCH] eal: call plugin init before device parse
2017-10-13 11:55 [dpdk-dev] [PATCH] eal: call plugin init before device parse Santosh Shukla
@ 2017-10-13 12:35 ` Maxime Coquelin
2017-10-13 13:40 ` Thomas Monjalon
0 siblings, 1 reply; 3+ messages in thread
From: Maxime Coquelin @ 2017-10-13 12:35 UTC (permalink / raw)
To: Santosh Shukla, dev; +Cc: thomas, jerin.jacob
On 10/13/2017 01:55 PM, Santosh Shukla wrote:
> Default eal_init code calls
> 0. eal_plugins_init
> 1. eal_option_device_parse
> 2. rte_bus_scan
>
> IOVA commit:cf408c224 missed on calling eal_plugins_init before
> eal_option_device_parse, rte_bus_scan and that introduced below
> regression for shared mode:
>
> with CONFIG_RTE_BUILD_SHARED_LIB=y:
>
> 'net_vhost0,iface=/tmp/vhost-user2' -d ./install/lib/librte_pmd_vhost.so
> -- --portmask=1 --disable-hw-vlan -i --rxq=1 --txq=1 --nb-cores=1
> --eth-peer=0,52:54:00:11:22:12
> EAL: Detected 4 lcore(s)
> ERROR: failed to parse device "net_vhost0"
> EAL: Unable to parse device 'net_vhost0,iface=/tmp/vhost-user2'
> PANIC in main():
> Cannot init EAL
>
> Fixes: cf408c224 ("eal: auto detect IOVA mode")
>
> Reported-by: Maxime Coquelin <maxime.coquelin@redhat.com>
> Signed-off-by: Santosh Shukla <santosh.shukla@caviumnetworks.com>
> ---
> lib/librte_eal/bsdapp/eal/eal.c | 10 +++++++---
> lib/librte_eal/linuxapp/eal/eal.c | 10 +++++++---
> 2 files changed, 14 insertions(+), 6 deletions(-)
Tested-by: Maxime Coquelin <maxime.coquelin@redhat.com>
Thanks,
Maxime
>
> diff --git a/lib/librte_eal/bsdapp/eal/eal.c b/lib/librte_eal/bsdapp/eal/eal.c
> index 30d3bd5b5..e981721aa 100644
> --- a/lib/librte_eal/bsdapp/eal/eal.c
> +++ b/lib/librte_eal/bsdapp/eal/eal.c
> @@ -551,6 +551,13 @@ rte_eal_init(int argc, char **argv)
> return -1;
> }
>
> + if (eal_plugins_init() < 0) {
> + rte_eal_init_alert("Cannot init plugins\n");
> + rte_errno = EINVAL;
> + rte_atomic32_clear(&run_once);
> + return -1;
> + }
> +
> if (eal_option_device_parse()) {
> rte_errno = ENODEV;
> rte_atomic32_clear(&run_once);
> @@ -635,9 +642,6 @@ rte_eal_init(int argc, char **argv)
>
> eal_check_mem_on_local_socket();
>
> - if (eal_plugins_init() < 0)
> - rte_eal_init_alert("Cannot init plugins\n");
> -
> eal_thread_init_master(rte_config.master_lcore);
>
> ret = eal_thread_dump_affinity(cpuset, RTE_CPU_AFFINITY_STR_LEN);
> diff --git a/lib/librte_eal/linuxapp/eal/eal.c b/lib/librte_eal/linuxapp/eal/eal.c
> index ec37c52c0..ad7278989 100644
> --- a/lib/librte_eal/linuxapp/eal/eal.c
> +++ b/lib/librte_eal/linuxapp/eal/eal.c
> @@ -786,6 +786,13 @@ rte_eal_init(int argc, char **argv)
> return -1;
> }
>
> + if (eal_plugins_init() < 0) {
> + rte_eal_init_alert("Cannot init plugins\n");
> + rte_errno = EINVAL;
> + rte_atomic32_clear(&run_once);
> + return -1;
> + }
> +
> if (eal_option_device_parse()) {
> rte_errno = ENODEV;
> rte_atomic32_clear(&run_once);
> @@ -882,9 +889,6 @@ rte_eal_init(int argc, char **argv)
>
> eal_check_mem_on_local_socket();
>
> - if (eal_plugins_init() < 0)
> - rte_eal_init_alert("Cannot init plugins\n");
> -
> eal_thread_init_master(rte_config.master_lcore);
>
> ret = eal_thread_dump_affinity(cpuset, RTE_CPU_AFFINITY_STR_LEN);
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-dev] [PATCH] eal: call plugin init before device parse
2017-10-13 12:35 ` Maxime Coquelin
@ 2017-10-13 13:40 ` Thomas Monjalon
0 siblings, 0 replies; 3+ messages in thread
From: Thomas Monjalon @ 2017-10-13 13:40 UTC (permalink / raw)
To: Santosh Shukla; +Cc: dev, Maxime Coquelin, jerin.jacob
13/10/2017 14:35, Maxime Coquelin:
>
> On 10/13/2017 01:55 PM, Santosh Shukla wrote:
> > Default eal_init code calls
> > 0. eal_plugins_init
> > 1. eal_option_device_parse
> > 2. rte_bus_scan
> >
> > IOVA commit:cf408c224 missed on calling eal_plugins_init before
> > eal_option_device_parse, rte_bus_scan and that introduced below
> > regression for shared mode:
> >
> > with CONFIG_RTE_BUILD_SHARED_LIB=y:
> >
> > 'net_vhost0,iface=/tmp/vhost-user2' -d ./install/lib/librte_pmd_vhost.so
> > -- --portmask=1 --disable-hw-vlan -i --rxq=1 --txq=1 --nb-cores=1
> > --eth-peer=0,52:54:00:11:22:12
> > EAL: Detected 4 lcore(s)
> > ERROR: failed to parse device "net_vhost0"
> > EAL: Unable to parse device 'net_vhost0,iface=/tmp/vhost-user2'
> > PANIC in main():
> > Cannot init EAL
> >
> > Fixes: cf408c224 ("eal: auto detect IOVA mode")
> >
> > Reported-by: Maxime Coquelin <maxime.coquelin@redhat.com>
> > Signed-off-by: Santosh Shukla <santosh.shukla@caviumnetworks.com>
> > ---
> > lib/librte_eal/bsdapp/eal/eal.c | 10 +++++++---
> > lib/librte_eal/linuxapp/eal/eal.c | 10 +++++++---
> > 2 files changed, 14 insertions(+), 6 deletions(-)
>
> Tested-by: Maxime Coquelin <maxime.coquelin@redhat.com>
Applied, thanks
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-10-13 13:40 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-10-13 11:55 [dpdk-dev] [PATCH] eal: call plugin init before device parse Santosh Shukla
2017-10-13 12:35 ` Maxime Coquelin
2017-10-13 13:40 ` Thomas Monjalon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).