From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f50.google.com (mail-wm0-f50.google.com [74.125.82.50]) by dpdk.org (Postfix) with ESMTP id B51152BF6 for ; Fri, 11 Mar 2016 14:52:02 +0100 (CET) Received: by mail-wm0-f50.google.com with SMTP id n186so19597140wmn.1 for ; Fri, 11 Mar 2016 05:52:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:organization:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=DzT2/RM47nuIWY2CixZa97d5/p1xJsXWEkfYeogFB6M=; b=CGXyQ7tEiSzWMxPtcRQvozmlwyxZgmaKV1rPxnCofFDuBFkNEtVH+6nBcxE1JkRDAr yIEZTXqOPtfjeMNqldaKo9IUkfrdwpgVnbSw7/zdV8vilJ1y1Aly+1pu2wPkSCUvXnPj GsuvOHUkyCnsBuh3AvSWV2jRjbISrxTPSDYleh0aqTL09NyiLKyeYe3KmvxYBIZaxACg wy4yd9U38sLvNK1FDexeyng8Z597x42M1FdBNlS7UhmofECqHZN5XkdwzZq4FaQe3wJ+ BYItzTZ9QMMg19DsbZrzTNXigz/HtVDNV503nje6xn3SzAc9RYZuIRhZEvEVi0LmqyjZ NN8g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding; bh=DzT2/RM47nuIWY2CixZa97d5/p1xJsXWEkfYeogFB6M=; b=ks+DkCb0LcwZ39mz5DsPI3nMMsoQItJMdKPMHaBBvDJsCD9zr6Q5I4997h4/6jH7Nn scVQes+oIC0V63aBCaK1owIuMTKWE6ljw7qy5UPpjyBrXaZT0Xd4XY/focEyfc8ZK8rf qixyXNQqoiTBNYfuaxNVpaIbqBK3GYqgtJlf/vVdiJ3X65PuHhzewDXiq8sBPo/uSJj4 uCBb8v0O88ay2zo2ikrbkIYxtYdzG1TcCI9ySv2yAEMcyrtVJcpbqXKXABFCz4wbBZNQ nrff09kvCXYIvQiqXZrQEAeCD3P/+NHuwW6PYhe1cLk1hPX+GauPEE1HWhE/9X49xO5E 7rJA== X-Gm-Message-State: AD7BkJIJ1gC01NKUk5fS77JbaDEMUSwCMR6LnYRfRTx8o8IVbSMiFEyWDU7JhjhgCZCM3dF5 X-Received: by 10.28.137.139 with SMTP id l133mr3248254wmd.1.1457704322570; Fri, 11 Mar 2016 05:52:02 -0800 (PST) Received: from xps13.localnet (91.111.75.86.rev.sfr.net. [86.75.111.91]) by smtp.gmail.com with ESMTPSA id i5sm8607510wjx.15.2016.03.11.05.52.01 (version=TLSv1/SSLv3 cipher=OTHER); Fri, 11 Mar 2016 05:52:02 -0800 (PST) From: Thomas Monjalon To: Wojciech Andralojc Date: Fri, 11 Mar 2016 14:50:18 +0100 Message-ID: <2207879.MgxKVmgPIQ@xps13> Organization: 6WIND User-Agent: KMail/4.14.10 (Linux/4.1.6-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <1457369659-101377-1-git-send-email-wojciechx.andralojc@intel.com> References: <1456499233-66251-1-git-send-email-wojciechx.andralojc@intel.com> <1457369659-101377-1-git-send-email-wojciechx.andralojc@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org, Marcel D Cornu , Tomasz Kantecki Subject: Re: [dpdk-dev] [PATCH v3] examples/skeleton-cat: PQoS CAT and CDP, example of libpqos usage X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 11 Mar 2016 13:52:02 -0000 2016-03-07 16:54, Wojciech Andralojc: > +M: Tomasz Kantecki > +F: examples/skeleton-cat/ > +F: doc/guides/sample_app_ug/skeleton-cat.rst Please keep the alphabetical order. > +Basic Forwarding sample application is a simple *skeleton* example of > +a forwarding application. It has been extended to make use of CAT via extended > +command line options and linking against the libpqos library. The skeleton aims to show a minimal piece of code (but bigger than hello world). For any other usage, I think the "l2fwd" name is more appropriate. > +DIRS-y += skeleton-cat It cannot be enabled everytime, because of the dependency. We already have this problem with examples/vm_power_manager and libvirt dependency. It must be solved by improving the build system. In this case, we can simply use the variable PQOS_LIBRARY_PATH to enable the build. [...] > +# Default location of PQoS library and includes, > +# can be overridden by command line or environment > +PQOS_INSTALL_PATH ?= /usr/local/ This default value is useless because we should detect the dependency before trying to compile. [...] > +LDLIBS += $(PQOS_LIBRARY_PATH) \ Why this backslash?