From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by dpdk.org (Postfix) with ESMTP id F2A8F1B20D for ; Mon, 14 Jan 2019 15:30:16 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 646242CC76; Mon, 14 Jan 2019 09:30:16 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Mon, 14 Jan 2019 09:30:16 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=GEUO9FegpKmzIcZ3ni/cHBJg+rVja0xgBI0yCuPL/4Y=; b=m0cZs34XTEv4 vvJyc6dAVnoagrQGCBdTjzoHZfclmigc5OJ/DgBQ/aiHJLwxJAWbDIlwCGsVGn1+ jpSuOrly8KBfoAGoIbzCK91rWvEEWZTmGqv0aIbOitAWTY9lds1cU07jBNUEi7/P ptYjs8FTZWFvcDfV6eRHey42xlMdQs4= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=GEUO9FegpKmzIcZ3ni/cHBJg+rVja0xgBI0yCuPL/ 4Y=; b=VL0TFyygNYeaBWHW/YB3BsW9Yuaw5NmK3/H55wjCklTGi/qYeKfDR0VkT sNfLgr17Yk21GczyYmh0yduQBYrO7OCYwV/zWoFhmaWHA6AnK/5u4bVK9AckhRdE 8Sg916QX7BOheLWWX8MOawA5tHWiXhouuCujiFZ9udGXvjcZofgDcxwdzzC6aNUk Ao+8BYLP1PlOdA+dIaoIv2cZU22mB7cURGT8cMl2Yc0G6vwXFB4VyR6bnyE13YAD Y3gB5ZcmB5w0i5ipPxFNOVO/H0/5uLtotUBeVFGULKXpS36kIXKkAtlN79OmN5L9 eEtKpcrXPeCb0qXU69k1AAxnS2a/Q== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedtledrgedugdeiiecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfhuthenuceurghilhhouhhtmecufedt tdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujfgurhephffvufffkfgjfh gggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgrshcuofhonhhjrghlohhnuceo thhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecukfhppeejjedrudefgedrvddtfe drudekgeenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhho nhdrnhgvthenucevlhhushhtvghrufhiiigvpedt X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id C397BE4741; Mon, 14 Jan 2019 09:30:14 -0500 (EST) From: Thomas Monjalon To: Nithin Kumar Dabilpuram Cc: dev@dpdk.org, Ferruh Yigit , Andrew Rybchenko , Jerin Jacob Kollanukkaran Date: Mon, 14 Jan 2019 15:30:13 +0100 Message-ID: <2210030.V8WD4YKsKK@xps> In-Reply-To: <20190113153749.3540-1-ndabilpuram@marvell.com> References: <20190107143951.30076-1-ndabilpuram@marvell.com> <20190113153749.3540-1-ndabilpuram@marvell.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v2] ethdev: report error on name truncation X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 14 Jan 2019 14:30:17 -0000 13/01/2019 16:38, Nithin Kumar Dabilpuram: > Currently this api doesn't report error if name is > truncated and so user is not sure about uniqueness > of name. This change reports error to help user. > > Signed-off-by: Nithin Dabilpuram > --- > + if (rc >= RTE_MEMZONE_NAMESIZE) { > + RTE_ETHDEV_LOG(ERR, "truncated name"); It would be better understandable from an user perspective by saying "ring name too long". And it would be even better with \n at the end ;) > + rte_errno = ENAMETOOLONG; > + return NULL; > + }