From: Thomas Monjalon <thomas@monjalon.net>
To: Shreyansh Jain <shreyansh.jain@nxp.com>
Cc: dev@dpdk.org, Olivier MATZ <olivier.matz@6wind.com>,
"bruce.richardson@intel.com" <bruce.richardson@intel.com>,
"john.miller@atomicrules.com" <john.miller@atomicrules.com>
Subject: Re: [dpdk-dev] [PATCH] mk: link ring mempool by default for app build
Date: Wed, 19 Apr 2017 14:26:47 +0200 [thread overview]
Message-ID: <2210656.H7V8bvkmcr@xps> (raw)
In-Reply-To: <VI1PR0401MB24641153524F2F6730CF385C90190@VI1PR0401MB2464.eurprd04.prod.outlook.com>
18/04/2017 14:25, Shreyansh Jain:
> Hi Olivier,
> From: Olivier MATZ [mailto:olivier.matz@6wind.com]
> > On Thu, 13 Apr 2017 14:32:07 +0530, Shreyansh Jain
> > <shreyansh.jain@nxp.com> wrote:
> > > Signed-off-by: Shreyansh Jain <shreyansh.jain@nxp.com>
> >
> > Fixes: 9a8e9b57f544 ("mempool: move ring handler as a driver")
> >
> > Acked-by: Olivier Matz <olivier.matz@6wind.com>
> >
> > > ---
> > >
> > > Context:
> > > From the discussion in [1], it was observed that application should
> > > have a default pool already linked even in case of shared builds.
> > > Ring is especially important because packet mbuf creation API refer to
> > > ring_mp_mc as default handler.
> > >
> > > Documentation for this is pending.
> > >
> > > [1] http://dpdk.org/ml/archives/dev/2017-April/063819.html
> >
> > Maybe this comment could go in the patch.
>
> I can send another version of the patch with some part of the above
> documentation within the patch commit.
Moved the mempool ring line below the mempool line,
Added the explanations, and
Applied, thanks
prev parent reply other threads:[~2017-04-19 12:26 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-13 9:02 Shreyansh Jain
2017-04-18 12:04 ` Olivier MATZ
2017-04-18 12:25 ` Shreyansh Jain
2017-04-19 12:26 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2210656.H7V8bvkmcr@xps \
--to=thomas@monjalon.net \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=john.miller@atomicrules.com \
--cc=olivier.matz@6wind.com \
--cc=shreyansh.jain@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).