Re: [dpdk-dev] [PATCH] drivers/net/bnxt New driver for Broadcom bnxt

[Thomas Monjalon <thomas.monjalon@6wind.com>]

Please do not submit some disabled code and avoid #ifdef.

2016-03-02 13:36, Stephen Hurd:
> +static struct eth_dev_ops bnxt_dev_ops = {
> +       .dev_infos_get = bnxt_dev_info_get_op,
> +       .dev_configure = bnxt_dev_configure_op,
> +       .dev_start = bnxt_dev_start_op,
> +       .dev_stop = bnxt_dev_stop_op,
> +       .dev_set_link_up = bnxt_dev_set_link_up_op,
> +       .dev_set_link_down = bnxt_dev_set_link_down_op,
> +       .dev_close = bnxt_dev_close_op,
> +       .stats_get = bnxt_stats_get_op,
> +       .stats_reset = bnxt_stats_reset_op,
> +       .rx_queue_setup = bnxt_rx_queue_setup_op,
> +       .rx_queue_release = bnxt_rx_queue_release_op,
> +//        .rx_queue_count       = bnxt_rx_queue_count_op,
> +//        .rx_descriptor_done   = bnxt_rx_descriptor_done_op,
> +       .tx_queue_setup = bnxt_tx_queue_setup_op,
> +       .tx_queue_release = bnxt_tx_queue_release_op,
> +//        .rx_queue_start       = bnxt_rx_queue_start_op,
> +//        .rx_queue_stop        = bnxt_rx_queue_stop_op,
> +//        .tx_queue_start       = bnxt_tx_queue_start_op,
> +//        .tx_queue_stop        = bnxt_tx_queue_stop_op,
> +       .reta_update = bnxt_reta_update_op,
> +       .reta_query = bnxt_reta_query_op,
> +       .rss_hash_update = bnxt_rss_hash_update_op,
> +       .rss_hash_conf_get = bnxt_rss_hash_conf_get_op,
> +       .link_update = bnxt_link_update_op,
> +       .promiscuous_enable = bnxt_promiscuous_enable_op,
> +       .promiscuous_disable = bnxt_promiscuous_disable_op,
> +       .allmulticast_enable = bnxt_allmulticast_enable_op,
> +       .allmulticast_disable = bnxt_allmulticast_disable_op,
> +       .mtu_set = bnxt_mtu_set_op,
> +       .mac_addr_add = bnxt_mac_addr_add_op,
> +       .mac_addr_remove = bnxt_mac_addr_remove_op,
> +       .vlan_filter_set = bnxt_vlan_filter_set_op,
> +       .vlan_strip_queue_set = bnxt_vlan_strip_queue_set_op,
> +       .flow_ctrl_get = bnxt_flow_ctrl_get_op,
> +       .flow_ctrl_set = bnxt_flow_ctrl_set_op,
> +#if 0                          // Phase 2/3
> +       .dev_led_on = bnxt_dev_led_on_op,
> +       .dev_led_off = bnxt_dev_led_off_op,
> +       .queue_stats_mapping_set = bnxt_queue_stats_mapping_set_op,
> +       .vlan_tpid_set = bnxt_vlan_tpid_set_op,
> +       .vlan_offload_set = bnxt_vlan_offload_set_op,
> +       .priority_flow_ctrl_set = bnxt_priority_flow_ctrl_set_op,
> +       .uc_hash_table_set = bnxt_uc_hash_table_set_op,
> +       .uc_all_hash_table_set = bnxt_uc_all_hash_table_set_op,
> +       .mirror_rule_set = bnxt_mirror_rule_set_op,
> +       .mirror_rule_reset = bnxt_mirror_rule_reset_op,
> +       .set_vf_rx_mode = bnxt_set_vf_rx_mode_op,
> +       .set_vf_rx = bnxt_set_vf_rx_op,
> +       .set_vf_tx = bnxt_set_vf_tx_op,
> +       .set_vf_vlan_filter = bnxt_set_vf_vlan_filter_op,
> +       .set_queue_rate_limit = bnxt_set_queue_rate_limit_op,
> +       .set_vf_rate_limit = bnxt_set_vf_rate_limit_op,
> +       .fdir_add_signature_filter = bnxt_fdir_add_signature_filter_op,
> +       .fdir_update_signature_filter = bnxt_fdir_update_signature_filter_op,
> +       .fdir_remove_signature_filter = bnxt_fdir_remove_signature_filter_op,
> +       .fdir_infos_get = bnxt_fdir_info_get_op,
> +       .fdir_add_perfect_filter = bnxt_fdir_add_perfect_filter_op,
> +       .fdir_update_perfect_filter = bnxt_fdir_update_perfect_filter_op,
> +       .fdir_remove_perfect_filter = bnxt_fdir_remove_perfect_filter_op,
> +       .fdir_set_masks = bnxt_fdir_set_masks_op,
> +       .add_syn_filter = bnxt_add_syn_filter_op,
> +       .remove_syn_filter = bnxt_remove_syn_filter_op,
> +       .get_syn_filter = bnxt_get_syn_filter_op,
> +       .add_ethertype_filter = bnxt_add_ethertype_filter_op,
> +       .remove_ethertype_filter = bnxt_remove_ethertype_filter_op,
> +       .get_ethertype_filter = bnxt_get_ethertype_filter_op,
> +       .add_5tuple_filter = bnxt_add_5tuple_filter_op,
> +       .remove_5tuple_filter = bnxt_remove_5tuple_filter_op,
> +       .get_5tuple_filter = bnxt_get_5tuple_filter_op,
> +#endif
> +};