From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wi0-f180.google.com (mail-wi0-f180.google.com [209.85.212.180]) by dpdk.org (Postfix) with ESMTP id 3175D7F49 for ; Fri, 7 Nov 2014 13:21:42 +0100 (CET) Received: by mail-wi0-f180.google.com with SMTP id hi2so4390998wib.7 for ; Fri, 07 Nov 2014 04:31:13 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=PPYRm7TGsSTmEegM5WgyZ924m9Qtgbe8SmBKUFeWvLc=; b=gCbodOsBbqeRAyUc3l/GBf5owiQEgJJlraUVzs+9GBDvZObxj42iXTMgw7hDo4LrsJ Ty9DW56mQ/ShAOWErsiW9h2NryPgyZ5DLcPOYH9Iu3NkeORUJgEkPTD5gAuplEA53Lz8 mRKu/xkYMDBMABHmH11BMCACvvb5AxyFZOkG+4eNs6JhbNJjoRICt1uanQLVFb58VMrI j4eyZRRHa88V0hK4MltYsYKD7N68VnoipQhNj2YQWCUxgF2gtx+I2Tw0sj6dw3wjcnaE 1OvgHApaCKIMvtYCS8F0SbgA3O8muCE12K/CC+7CbAAfcQQ1MmG3umsxa8GQT/jJhhfW 9RkQ== X-Gm-Message-State: ALoCoQm/FxYwf5gc62+ZBhGxQtKFCKii0cfAPj6pwrrN9ETtNEqyvDsd02BX+6Xc1dCip/++Jbmq X-Received: by 10.194.243.164 with SMTP id wz4mr13997007wjc.129.1415363472947; Fri, 07 Nov 2014 04:31:12 -0800 (PST) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by mx.google.com with ESMTPSA id u2sm11646725wjz.11.2014.11.07.04.31.11 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 07 Nov 2014 04:31:11 -0800 (PST) From: Thomas Monjalon To: "Richardson, Bruce" Date: Fri, 07 Nov 2014 13:30:53 +0100 Message-ID: <2215672.o2GmOzFsZU@xps13> Organization: 6WIND User-Agent: KMail/4.14.2 (Linux/3.17.2-1-ARCH; KDE/4.14.2; x86_64; ; ) In-Reply-To: <59AF69C657FD0841A61C55336867B5B03440521B@IRSMSX103.ger.corp.intel.com> References: <1410948102-12740-1-git-send-email-bruce.richardson@intel.com> <20140923170231.GC12884@hmsreliant.think-freely.org> <59AF69C657FD0841A61C55336867B5B03440521B@IRSMSX103.ger.corp.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v2 3/5] testpmd: Change rxfreet default to 32 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 07 Nov 2014 12:21:42 -0000 Hi Bruce, 2014-09-24 09:03, Richardson, Bruce: > From: Neil Horman [mailto:nhorman@tuxdriver.com] > > On Tue, Sep 23, 2014 at 12:08:15PM +0100, Bruce Richardson wrote: > > > --- a/app/test-pmd/testpmd.c > > > +++ b/app/test-pmd/testpmd.c > > > @@ -225,7 +225,9 @@ struct rte_eth_thresh tx_thresh = { > > > /* > > > * Configurable value of RX free threshold. > > > */ > > > -uint16_t rx_free_thresh = 0; /* Immediately free RX descriptors by default. */ > > > +uint16_t rx_free_thresh = 32; /* Refill RX descriptors once every 32 packets, > > > + This setting is needed for ixgbe to enable bulk alloc or vector > > > + receive functionality. */ > > > > I thought we were talking about making this a pmd private selectable item, > > or allowing a reserved "let the pmd decide" setting. Or are we saving > > that for a later time? > > Yes, we are looking at that - and hopefully we can also get a patch for that > in for our next release. However, I've left this patch in just in case that > doesn't actually happen, as the performance improvements for 10G are just > too good to leave aside for the sake of a 1-line change. Ideally, I'd like > this go to in, and then be replaced by a "proper" fix. Now the patch for PMD defaults is integrated: http://dpdk.org/ml/archives/dev/2014-October/006511.html Are you working on getting these defaults in testpmd? Thanks -- Thomas